Cleanup from passing PR to remove the diagnostics info

marcpopMSFT · web-flow · commit 81d1aee6ff12 · 2025-08-20T19:11:35.000-07:00
diff --git a/src/Tasks/sdk-tasks/OverrideAndCreateBundledNETCoreAppPackageVersion.cs b/src/Tasks/sdk-tasks/OverrideAndCreateBundledNETCoreAppPackageVersion.cs
@@ -59,7 +59,7 @@ public static string ExecuteInternal(
             string microsoftNETCoreAppRefPackageVersion,
             string newSDKVersion,
             string targetRid,
-            TaskLoggingHelper log = null)
+            TaskLoggingHelper log)
         {
             var projectXml = XDocument.Parse(stage0MicrosoftNETCoreAppRefPackageVersionContent);
 
@@ -102,14 +102,13 @@ void CheckAndReplaceElement(XElement element)
                         element.ToString(), element.Value, originalBundledNETCoreAppPackageVersion));
                 }
 
-                log?.LogMessage(MessageImportance.High,
+                log.LogMessage(MessageImportance.High,
                     $"Replacing element {element.Name} value '{element.Value}' with '{newBundledPackageVersion}'");
                 element.Value = newBundledPackageVersion;
             }
 
             void CheckAndReplaceAttribute(XAttribute attribute)
             {
-
                 if (attribute.Value != originalBundledNETCoreAppPackageVersion)
                 {
                     throw new InvalidOperationException(string.Format(
@@ -118,7 +117,7 @@ void CheckAndReplaceAttribute(XAttribute attribute)
                         originalBundledNETCoreAppPackageVersion));
                 }
 
-                log?.LogMessage(MessageImportance.High,
+                log.LogMessage(MessageImportance.High,
                     $"Replacing attribute {attribute.Name} value '{attribute.Value}' with '{newBundledPackageVersion}' in element {attribute.Parent.Name}");
                 attribute.Value = newBundledPackageVersion;
             }
diff --git a/test/EndToEnd.Tests/GivenDotNetUsesMSBuild.cs b/test/EndToEnd.Tests/GivenDotNetUsesMSBuild.cs
@@ -27,7 +27,7 @@ public void ItCanNewRestoreBuildRunCleanMSBuildProject()
 
             new DotnetCommand(Log, "run")
                 .WithWorkingDirectory(projectDirectory)
-                .Execute("/bl:helixfailure.binlog")
+                .Execute()
                 .Should().Pass()
                     .And.HaveStdOutContaining("Hello, World!");
 
diff --git a/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs b/test/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
@@ -728,7 +728,7 @@ public void NativeAot_compiler_runs_when_PublishAot_is_enabled(string targetFram
 
             var publishCommand = new PublishCommand(testAsset);
             publishCommand
-                .Execute("/bl:helixfailure.binlog")
+                .Execute()
                 .Should().Pass()
                 .And.HaveStdOutContaining("warning IL3050")
                 .And.HaveStdOutContaining("warning IL3056")
diff --git a/test/UnitTests.proj b/test/UnitTests.proj
@@ -139,7 +139,6 @@
       <HelixPostCommands Condition="!$(IsPosixShell)">PowerShell -ExecutionPolicy ByPass "dotnet nuget locals all -l | ForEach-Object { $_.Split(' ')[1]} | Where-Object{$_ -like '*cache'} | Get-ChildItem -Recurse -File -Filter '*.dat' | Measure";$(HelixPostCommands)</HelixPostCommands>
       <HelixPostCommands Condition="!$(IsPosixShell)">PowerShell -ExecutionPolicy ByPass "Get-ChildItem -Recurse -File -Filter '*hangdump.dmp' | Copy-Item -Destination $env:HELIX_WORKITEM_UPLOAD_ROOT";$(HelixPostCommands)</HelixPostCommands>
       <HelixPostCommands Condition="$(IsPosixShell)">find "$HELIX_WORKITEM_UPLOAD_ROOT/../../.." -name '*hangdump.dmp' -exec cp {} "$HELIX_WORKITEM_UPLOAD_ROOT" \%3B;$(HelixPostCommands)</HelixPostCommands>
-      <HelixPostCommands Condition="$(IsPosixShell)">find "$HELIX_WORKITEM_UPLOAD_ROOT/../../.." -name '*helixfailure.binlog' -exec cp {} "$HELIX_WORKITEM_UPLOAD_ROOT" \%3B;$(HelixPostCommands)</HelixPostCommands>
       <TestDotnetVersion>$(Version)</TestDotnetVersion>
       <MSBuildSdkResolverDir>$(RepoRoot)artifacts\bin\Microsoft.DotNet.MSBuildSdkResolver</MSBuildSdkResolverDir>
       <HelixStage0Targz>$(RepoRoot)artifacts\tmp\HelixStage0.tar.gz</HelixStage0Targz>
diff --git a/test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTests.cs b/test/dotnet.Tests/CommandTests/Test/GivenDotnetTestBuildsAndRunsTests.cs
@@ -132,7 +132,7 @@ public void RunTestProjectWithTestsAndLaunchSettings_ShouldReturnExitCodeSuccess
 
             CommandResult result = new DotnetTestCommand(Log, disableNewOutput: false)
                                     .WithWorkingDirectory(testInstance.Path)
-                                    .Execute(TestingPlatformOptions.ConfigurationOption.Name, configuration, "/bl:helixfailure.binlog");
+                                    .Execute(TestingPlatformOptions.ConfigurationOption.Name, configuration);
 
             if (!TestContext.IsLocalized())
             {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public static string ExecuteInternal(`
`59`	`59`	`string microsoftNETCoreAppRefPackageVersion,`
`60`	`60`	`string newSDKVersion,`
`61`	`61`	`string targetRid,`
`62`		`- TaskLoggingHelper log = null)`
	`62`	`+ TaskLoggingHelper log)`
`63`	`63`	`{`
`64`	`64`	`var projectXml = XDocument.Parse(stage0MicrosoftNETCoreAppRefPackageVersionContent);`
`65`	`65`
`@@ -102,14 +102,13 @@ void CheckAndReplaceElement(XElement element)`
`102`	`102`	`element.ToString(), element.Value, originalBundledNETCoreAppPackageVersion));`
`103`	`103`	`}`
`104`	`104`
`105`		`- log?.LogMessage(MessageImportance.High,`
	`105`	`+ log.LogMessage(MessageImportance.High,`
`106`	`106`	`$"Replacing element {element.Name} value '{element.Value}' with '{newBundledPackageVersion}'");`
`107`	`107`	`element.Value = newBundledPackageVersion;`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`void CheckAndReplaceAttribute(XAttribute attribute)`
`111`	`111`	`{`
`112`		`-`
`113`	`112`	`if (attribute.Value != originalBundledNETCoreAppPackageVersion)`
`114`	`113`	`{`
`115`	`114`	`throw new InvalidOperationException(string.Format(`
`@@ -118,7 +117,7 @@ void CheckAndReplaceAttribute(XAttribute attribute)`
`118`	`117`	`originalBundledNETCoreAppPackageVersion));`
`119`	`118`	`}`
`120`	`119`
`121`		`- log?.LogMessage(MessageImportance.High,`
	`120`	`+ log.LogMessage(MessageImportance.High,`
`122`	`121`	`$"Replacing attribute {attribute.Name} value '{attribute.Value}' with '{newBundledPackageVersion}' in element {attribute.Parent.Name}");`
`123`	`122`	`attribute.Value = newBundledPackageVersion;`
`124`	`123`	`}`
Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ public void RunTestProjectWithTestsAndLaunchSettings_ShouldReturnExitCodeSuccess`
`132`	`132`
`133`	`133`	`CommandResult result = new DotnetTestCommand(Log, disableNewOutput: false)`
`134`	`134`	`.WithWorkingDirectory(testInstance.Path)`
`135`		`- .Execute(TestingPlatformOptions.ConfigurationOption.Name, configuration, "/bl:helixfailure.binlog");`
	`135`	`+ .Execute(TestingPlatformOptions.ConfigurationOption.Name, configuration);`
`136`	`136`
`137`	`137`	`if (!TestContext.IsLocalized())`
`138`	`138`	`{`