Skip to content

Commit d7fba07

Browse files
authored
Disable several tests incompatible with interpreter (#121401)
These tests use COM interop, native varargs, marshalled pinvoke or handle exception thrown in pinvoked native code.
1 parent 11702c4 commit d7fba07

File tree

4 files changed

+14
-1
lines changed

4 files changed

+14
-1
lines changed

src/tests/Interop/COM/Directory.Build.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
<CLRTestTargetUnsupported Condition="'$(TargetsWindows)' != 'true'">true</CLRTestTargetUnsupported>
77
<!-- COM is not supported on Mono -->
88
<DisableProjectBuild Condition="'$(RuntimeFlavor)' == 'mono'">true</DisableProjectBuild>
9+
<!-- COM is not supported with Interpreter. See https://github.com/dotnet/runtime/issues/118965 -->
10+
<InterpreterIncompatible>true</InterpreterIncompatible>
911
</PropertyGroup>
1012

1113
</Project>

src/tests/Interop/IJW/NativeVarargs/NativeVarargsTest.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
<RequiresProcessIsolation>true</RequiresProcessIsolation>
55
<!-- Native varargs not supported on ARM -->
66
<CLRTestTargetUnsupported Condition="'$(TargetArchitecture)' == 'arm' or '$(TargetArchitecture)' == 'armel'">true</CLRTestTargetUnsupported>
7+
<!-- Native varargs are not supported with Interpreter. See https://github.com/dotnet/runtime/issues/118965 -->
8+
<InterpreterIncompatible>true</InterpreterIncompatible>
79
</PropertyGroup>
810
<PropertyGroup>
911
<CopyDebugCRTDllsToOutputDirectory>true</CopyDebugCRTDllsToOutputDirectory>

src/tests/JIT/Directed/pinvoke/calli_excep.il

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@
2727
.custom instance void [xunit.core]Xunit.FactAttribute::.ctor() = (
2828
01 00 00 00
2929
)
30+
.custom instance void [Microsoft.DotNet.XUnitExtensions]Xunit.ActiveIssueAttribute::.ctor(string, class [mscorlib]System.Type, string[]) = {
31+
string('https://github.com/dotnet/runtime/issues/118965')
32+
type([TestLibrary]TestLibrary.Utilities)
33+
string[1] ('IsCoreClrInterpreter')
34+
}
3035
.entrypoint
3136
.custom instance void [mscorlib]System.Runtime.ExceptionServices.HandleProcessCorruptedStateExceptionsAttribute::.ctor() = ( 01 00 00 00 )
3237
.custom instance void [mscorlib]System.Security.SecurityCriticalAttribute::.ctor() = ( 01 00 00 00 )

src/tests/baseservices/callconvs/TestCallingConventions.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,11 @@ public static int TestEntryPoint()
170170
try
171171
{
172172
BlittableFunctionPointers();
173-
NonblittableFunctionPointers();
173+
// This requires pinvoke marshalling which is not currently supported by the interpreter. See https://github.com/dotnet/runtime/issues/118965
174+
if (!TestLibrary.Utilities.IsCoreClrInterpreter)
175+
{
176+
NonblittableFunctionPointers();
177+
}
174178
}
175179
catch (Exception e)
176180
{

0 commit comments

Comments
 (0)