Disable tests that consistently fail in the VM queues for performance-ci runs, but keep them for internal runs. (#5001)

Author: LoopedBard3

eng/performance/scenarios.proj

@@ -31,11 +31,15 @@
       <ScenarioDirectoryName>emptyvbconsoletemplate</ScenarioDirectoryName>
       <PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
     </Scenario>
-    <UIScenario Include="Static Winforms Template" Condition="'$(TargetsWindows)' == 'true' AND '$(OS)' == 'Windows_NT'">
+    <!-- Static Winforms Template: limited to internal (SYSTEM_TEAMPROJECT=internal) runs due to flakiness (CloseFailed) on generic CI VMs.
+      Override with /p:IncludeVMFlakyScenarios=true to include on other builds. -->
+    <UIScenario Include="Static Winforms Template" Condition="'$(TargetsWindows)' == 'true' AND '$(OS)' == 'Windows_NT' AND ( '$(SYSTEM_TEAMPROJECT)' == 'internal' OR '$(IncludeVMFlakyScenarios)' == 'true' )">
       <ScenarioDirectoryName>staticwinformstemplate</ScenarioDirectoryName>
       <PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
     </UIScenario>
-    <UIScenario Include="WinForms Large" Condition="'$(TargetsWindows)' == 'true' AND '$(OS)' == 'Windows_NT'">
+    <!-- WinForms Large: gated for consistency with Static Winforms Template.
+      Override with /p:IncludeVMFlakyScenarios=true to include on other builds. -->
+    <UIScenario Include="WinForms Large" Condition="'$(TargetsWindows)' == 'true' AND '$(OS)' == 'Windows_NT' AND ( '$(SYSTEM_TEAMPROJECT)' == 'internal' OR '$(IncludeVMFlakyScenarios)' == 'true' )">
       <ScenarioDirectoryName>windowsformslarge</ScenarioDirectoryName>
       <PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
     </UIScenario>

eng/performance/sdk_scenarios.proj

@@ -2,6 +2,7 @@
 
   <Import Project="Scenarios.Common.props" />
 
+
   <ItemGroup>
       <Framework Include="netcoreapp2.1" FrameworkName="%(Identity)"/>
       <Framework Include="netcoreapp3.0" FrameworkName="%(Identity)" Condition="'$(FrameworkVersion)' &gt; '2.1'"/>
@@ -168,7 +169,9 @@
       <Command>$(Python) test.py innerloopmsbuild --scenario-name &quot;%(Identity)&quot; $(ScenarioArgs)</Command>
       <PostCommands>$(Python) post.py</PostCommands>
     </HelixWorkItem>
-    <HelixWorkItem Include="Inner Loop Blazor Client">
+    <!-- Inner Loop Blazor Client: gated to internal (SYSTEM_TEAMPROJECT=internal) by default due to higher resource usage.
+      Override with /p:IncludeVMFlakyScenarios=true to include elsewhere. -->
+    <HelixWorkItem Include="Inner Loop Blazor Client" Condition="'$(SYSTEM_TEAMPROJECT)' == 'internal' OR '$(IncludeVMFlakyScenarios)' == 'true'">
       <ScenarioDirectoryName>blazorwasminnerloop</ScenarioDirectoryName>
       <PayloadDirectory>$(ScenariosDir)%(ScenarioDirectoryName)</PayloadDirectory>
       <PreCommands>$(Python) pre.py default -f $(PERFLAB_Framework)</PreCommands>