Skip to content

Commit 8a3478a

Browse files
committed
A few more
1 parent 8b3c681 commit 8a3478a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

msbuild/Xamarin.Shared/Xamarin.Shared.targets

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ Copyright (C) 2018 Microsoft. All rights reserved.
365365
<RemoveDir Directories="$(BindingResourcePath);" />
366366
</Target>
367367

368-
<Target Name="_CleanDebugSymbols" Condition="'$(_CanOutputAppBundle)' == 'true'" DependsOnTargets="_GenerateBundleName">
368+
<Target Name="_CleanDebugSymbols" Condition="'$(_CanOutputAppBundle)' == 'true'" DependsOnTargets="_GenerateBundleName;_DetectSdkLocations">
369369
<GetDirectories SessionId="$(BuildSessionId)" Condition="'$(IsMacEnabled)' == 'true'" Path="$(DeviceSpecificOutputPath)" Pattern="*.dSYM" SdkDevPath="$(_SdkDevPath)">
370370
<Output TaskParameter="Directories" ItemName="_DebugSymbolDir" />
371371
</GetDirectories>
@@ -439,6 +439,7 @@ Copyright (C) 2018 Microsoft. All rights reserved.
439439
_CompileTextureAtlases;
440440
_CompileCoreMLModels;
441441
_SetResourceMetadata;
442+
_DetectSdkLocations;
442443
</CollectBundleResourcesDependsOn>
443444
</PropertyGroup>
444445

@@ -465,6 +466,7 @@ Copyright (C) 2018 Microsoft. All rights reserved.
465466
BundleResources="@(Content);@(BundleResource)"
466467
ProjectDir="$(MSBuildProjectDirectory)"
467468
ResourcePrefix="$(_ResourcePrefix)"
469+
SdkDevPath="$(_SdkDevPath)"
468470
TargetFrameworkMoniker="$(_ComputedTargetFrameworkMoniker)"
469471
UnpackedResources="@(_UnpackedBundleResourceWithLogicalName)"
470472
>

msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Common.After.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ Copyright (C) 2011-2013 Xamarin. All rights reserved.
177177
</CopyLongPaths>
178178
</Target>
179179

180-
<Target Name="CopyDSYMFromMac" DependsOnTargets="_SayHello" Condition="'$(IsMacEnabled)' == 'true' And '$(IsAppExtension)' == 'false' And '$(ComputedPlatform)' == 'iPhone' And '$(CopyDSYM)' == 'true' And ('$(BuildIpa)' == 'true' Or '$(CopyAppBundle)' == 'true')" BeforeTargets="BeforeDisconnect">
180+
<Target Name="CopyDSYMFromMac" DependsOnTargets="_SayHello;_DetectSdkLocations" Condition="'$(IsMacEnabled)' == 'true' And '$(IsAppExtension)' == 'false' And '$(ComputedPlatform)' == 'iPhone' And '$(CopyDSYM)' == 'true' And ('$(BuildIpa)' == 'true' Or '$(CopyAppBundle)' == 'true')" BeforeTargets="BeforeDisconnect">
181181
<!--Copy watchOS Dsym folders from Mac-->
182182
<MSBuild Projects="@(_WatchAppReferenceWithConfigurationExistent)" Targets="CopyDSYMFromMac" Properties="%(_WatchAppReferenceWithConfigurationExistent.SetConfiguration); %(_WatchAppReferenceWithConfigurationExistent.SetPlatform); BuildIpa=true" Condition="'$(IsWatchApp)' == 'false' And '@(_WatchAppReferenceWithConfigurationExistent)' != '' And '$(_BuildReferencedExtensionProjects)' != 'true'"></MSBuild>
183183
<!--Look for all *.dsym folders int the output path of the main app -->

0 commit comments

Comments
 (0)