Skip to content

Commit 59f00d5

Browse files
committed
[msbuild] Fix building apps with extensions remotely.
Pending: the actual fix. For now this only has a test. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2542958.
1 parent 8ae4452 commit 59f00d5

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

tests/dotnet/UnitTests/ProjectTest.cs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1806,6 +1806,19 @@ public void KillEverything ()
18061806
[TestCase (ApplePlatform.MacOSX, "osx-x64;osx-arm64", true)]
18071807
// [TestCase ("MacCatalyst", "")] - No extension support yet
18081808
public void BuildProjectsWithExtensions (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot)
1809+
{
1810+
BuildProjectsWithExtensionsImpl (platform, runtimeIdentifier, isNativeAot);
1811+
}
1812+
1813+
[TestCase (ApplePlatform.iOS, "ios-arm64", false)]
1814+
[Category ("RemoteWindows")]
1815+
public void BuildProjectsWithExtensionsOnRemoteWindows (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot)
1816+
{
1817+
Configuration.IgnoreIfNotOnWindows ();
1818+
BuildProjectsWithExtensionsImpl (platform, runtimeIdentifier, isNativeAot, AddRemoteProperties ());
1819+
}
1820+
1821+
void BuildProjectsWithExtensionsImpl (ApplePlatform platform, string runtimeIdentifier, bool isNativeAot, Dictionary<string, string>? properties = null)
18091822
{
18101823
Configuration.IgnoreIfIgnoredPlatform (platform);
18111824
var consumingProjectDir = GetProjectPath ("ExtensionConsumer", runtimeIdentifier, platform, out var appPath);
@@ -1814,7 +1827,7 @@ public void BuildProjectsWithExtensions (ApplePlatform platform, string runtimeI
18141827
Clean (extensionProjectDir);
18151828
Clean (consumingProjectDir);
18161829

1817-
var properties = GetDefaultProperties (runtimeIdentifier);
1830+
properties = GetDefaultProperties (runtimeIdentifier, extraProperties: properties);
18181831

18191832
if (isNativeAot) {
18201833
properties ["PublishAot"] = "true";

0 commit comments

Comments
 (0)