improvements

Author: rolfbjarne

dotnet/targets/Xamarin.Shared.Sdk.targets

@@ -2279,6 +2279,7 @@
 			Condition="'$(IsMacEnabled)' == 'true'"
 			ZipFilePath="%(_CompressedPlugIns.Identity)"
 			ExtractionPath="%(_CompressedPlugIns.ExtractionPath)"
+			SdkDevPath="$(_SdkDevPath)"
 			>
 			<Output TaskParameter="TouchedFiles" ItemName="FileWrites" />
 		</Unzip>
@@ -2322,6 +2323,7 @@
 			CopyToWindows="true"
 			ZipFilePath="%(_CompressedXpcServices.Identity)"
 			ExtractionPath="%(_CompressedXpcServices.ExtractionPath)"
+			SdkDevPath="$(_SdkDevPath)"
 			>
 			<Output TaskParameter="TouchedFiles" ItemName="FileWrites" />
 		</Unzip>

msbuild/Xamarin.Localization.MSBuild/MSBStrings.resx

@@ -1629,4 +1629,8 @@
     <data name="E7163" xml:space="preserve">
         <value>Unable to copy the inputs to this task to the remote build server for unknown reasons. The build log may have more information.</value>
     </data>
+
+    <data name="E7164" xml:space="preserve">
+        <value>The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose.</value>
+    </data>
 </root>

msbuild/Xamarin.MacDev.Tasks/Tasks/XamarinTask.cs

@@ -113,8 +113,10 @@ static async System.Threading.Tasks.Task<Execution> ExecuteAsync (Task task, str
 			if (!string.IsNullOrEmpty (sdkDevPath))
 				launchEnvironment ["DEVELOPER_DIR"] = sdkDevPath;
 
-			if (string.IsNullOrEmpty (sdkDevPath))
-				log.LogError ($"Calling external processes without specifying the Xcode path in the task {(task?.GetType ()?.Name ?? "?")}! StackTrace: {Environment.StackTrace}");
+			if (string.IsNullOrEmpty (sdkDevPath)) {
+				log.LogError (MSBStrings.E7164 /* The task '{0}' is trying to call an external process, but a path to Xcode has not been provided. Please file an issue at https://github.com/dotnet/macios/issues/new/choose. */, task.GetType ().Name);
+				log.LogMessage (MessageImportance.Low, Environment.StackTrace);
+			}
 
 			var currentId = Interlocked.Increment (ref executionCounter);
 			log.LogMessage (MessageImportance.Normal, MSBStrings.M0001, currentId, fileName, StringUtils.FormatArguments (arguments)); // Started external tool execution #{0}: {1} {2}

tests/msbuild/Xamarin.MacDev.Tasks.Tests/TaskTests/CreateBindingResourceTaskTests.cs

@@ -9,6 +9,7 @@
 
 using NUnit.Framework;
 
+using Xamarin.Tests;
 using Xamarin.Utils;
 
 namespace Xamarin.MacDev.Tasks {
@@ -22,11 +23,12 @@ CreateBindingResourcePackage ExecuteTask (string compress, bool symlinks, out st
 			task.BindingResourcePath = Path.Combine (tmpdir, "CreateBindingResourceTaskTest");
 			task.IntermediateOutputPath = Path.Combine (tmpdir, "IntermediateOutputPath");
 			task.NativeReferences = CreateNativeReferences (tmpdir, symlinks);
+			task.SdkDevPath = Configuration.xcode_root;
 
 			var currentDir = Environment.CurrentDirectory;
 			try {
 				Environment.CurrentDirectory = tmpdir;
-				Assert.IsTrue (task.Execute (), "Execute");
+				ExecuteTask (task);
 			} finally {
 				Environment.CurrentDirectory = currentDir;
 			}