From 6389d09f8057725062d5f1db8625228f03c15345 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Sun, 29 Mar 2020 14:06:16 -0400 Subject: [PATCH 1/6] Remove incorrect nullable information from GetIPv4Properties It doesn't return null. --- xml/System.Net.NetworkInformation/IPInterfaceProperties.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xml/System.Net.NetworkInformation/IPInterfaceProperties.xml b/xml/System.Net.NetworkInformation/IPInterfaceProperties.xml index 6d2669201cf..6bd7be74ed2 100644 --- a/xml/System.Net.NetworkInformation/IPInterfaceProperties.xml +++ b/xml/System.Net.NetworkInformation/IPInterfaceProperties.xml @@ -387,13 +387,11 @@ Provides Internet Protocol version 4 (IPv4) configuration data for this network interface. - An object that contains IPv4 configuration data, or if no data is available for the interface. + An object that contains IPv4 configuration data. interfaces. - For a detailed description of the information available for an interface that supports IPv4, see the class documentation. Note that the object returned by the method reflects the configuration as of the time the object is created. This information is not updated dynamically. ]]> From d409aae8db0748bdbfc705286307193b5dc8bf8f Mon Sep 17 00:00:00 2001 From: Abel Braaksma Date: Mon, 30 Mar 2020 01:26:39 +0200 Subject: [PATCH 2/6] Add F# to supported langs of ConditionalAttribute F# was not listed in the summary of languages that support the `ConditionalAttribute`. Just a small change, added `F#` there ;). --- xml/System.Diagnostics/ConditionalAttribute.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Diagnostics/ConditionalAttribute.xml b/xml/System.Diagnostics/ConditionalAttribute.xml index e189bff6ab0..6880214e6c1 100644 --- a/xml/System.Diagnostics/ConditionalAttribute.xml +++ b/xml/System.Diagnostics/ConditionalAttribute.xml @@ -86,7 +86,7 @@ #Const DEBUG=False ``` - Compilers that comply with the Common Language Specification (CLS) are permitted to ignore . The C#, Visual Basic, and C++ compilers support ; the JScript compiler does not support the attribute. + Compilers that comply with the Common Language Specification (CLS) are permitted to ignore . The C#, F#, Visual Basic, and C++ compilers support ; the JScript compiler does not support the attribute. > [!NOTE] > In Visual Basic, the `AddressOf` operator is not affected by this attribute. For example, `Call CType(AddressOf delegate, Action)` always invokes `delegate`, although `Call delegate()` might not. From 8bb37c3a3fba5eb91be12d138b793f136026a0e9 Mon Sep 17 00:00:00 2001 From: Asugakoisi <51259305+Asugakoisi@users.noreply.github.com> Date: Mon, 30 Mar 2020 22:28:55 +0900 Subject: [PATCH 3/6] Update installcontext_installcontext.cs (#4047) --- .../CS/installcontext_installcontext.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/samples/snippets/csharp/VS_Snippets_CLR/InstallContext_InstallContext/CS/installcontext_installcontext.cs b/samples/snippets/csharp/VS_Snippets_CLR/InstallContext_InstallContext/CS/installcontext_installcontext.cs index c95c65d483c..098a81c83f7 100644 --- a/samples/snippets/csharp/VS_Snippets_CLR/InstallContext_InstallContext/CS/installcontext_installcontext.cs +++ b/samples/snippets/csharp/VS_Snippets_CLR/InstallContext_InstallContext/CS/installcontext_installcontext.cs @@ -34,6 +34,7 @@ class InstallContext_Example : Installer public override void Install( IDictionary mySavedState ) { + base.Install( mySavedState ); // StringDictionary myStringDictionary = myInstallContext.Parameters; if( myStringDictionary.Count == 0 ) @@ -61,11 +62,13 @@ public override void Install( IDictionary mySavedState ) public override void Uninstall( IDictionary mySavedState ) { + base.Uninstall( mySavedState ); // The 'Uninstall' procedure should be added here. } public override void Rollback( IDictionary mySavedState ) { + base.Rollback( mySavedState ); if( myInstallContext.IsParameterTrue( "LogtoConsole" ) == true ) { myInstallContext.LogMessage( "The 'Rollback' method has been called" ); @@ -76,6 +79,7 @@ public override void Rollback( IDictionary mySavedState ) public override void Commit( IDictionary mySavedState ) { + base.Commit( mySavedState ); if( myInstallContext.IsParameterTrue( "LogtoConsole" ) == true ) { myInstallContext.LogMessage( "The 'Commit' method has been called" ); From defcafd14bcd51928f033a6e5127b4d81924666c Mon Sep 17 00:00:00 2001 From: slozier Date: Mon, 30 Mar 2020 14:29:12 -0400 Subject: [PATCH 4/6] Update BigInteger.xml (#4041) Fix copy/paste error. --- xml/System.Numerics/BigInteger.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Numerics/BigInteger.xml b/xml/System.Numerics/BigInteger.xml index f591ae8f700..d9a43bff54c 100644 --- a/xml/System.Numerics/BigInteger.xml +++ b/xml/System.Numerics/BigInteger.xml @@ -3554,7 +3554,7 @@ value Mod 2 = 0 ## Remarks The overloads of the method define the types to which or from which a object can be converted. Language compilers do not perform this conversion automatically because it can involve data loss. Instead, they perform the conversion only if a casting operator (in C#) or a conversion function (such as `CType` or `CInt` in Visual Basic) is used. Otherwise, they display a compiler error. - Because this operation defines a narrowing conversion, it can throw an at run time if the value is outside the range of the data type. There is no loss of precision in the resulting value if the conversion is successful. + Because this operation defines a narrowing conversion, it can throw an at run time if the value is outside the range of the data type. There is no loss of precision in the resulting value if the conversion is successful. ## Examples The following example illustrates the conversion of to values. It also handles an that is thrown because the value is outside the range of the data type. From 460526ed6c0aad9bdf6e44377a8c394c46d087bf Mon Sep 17 00:00:00 2001 From: Judit Varsanyi Rozsa Date: Mon, 30 Mar 2020 12:18:54 -0700 Subject: [PATCH 5/6] Update missing Winforms documentation (#3959) * Update missing Winforms documentation * Update xml/System.Windows.Forms/ToolStripControlHost+ToolStripHostedControlAccessibleObject.xml Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Update xml/System.Windows.Forms/ComboBox.xml Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Update xml/System.Windows.Forms/ComboBox.xml Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Update xml/System.Windows.Forms/Form.xml Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Update xml/System.Windows.Forms/ListBox.xml Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Update xml/System.Windows.Forms/MonthCalendar.xml Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Update xml/System.Windows.Forms/ToolStripControlHost+ToolStripHostedControlAccessibleObject.xml Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Update xml/System.ComponentModel.Design/DesignerActionService.xml * Apply suggestions from code review Co-Authored-By: Merrie McGaw Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Apply suggestions from code review Co-Authored-By: Merrie McGaw Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> * Apply suggestions from code review * Update xml/System.ComponentModel.Design/ObjectSelectorEditor.xml * added article to describe new Explorer style theme * add exception documentation * Update xml/System.ComponentModel.Design/DesignerActionService.xml Co-Authored-By: Andy De George <2672110+Thraka@users.noreply.github.com> * Change TreeView to cref link Co-authored-by: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Co-authored-by: Merrie McGaw Co-authored-by: Andy De George <2672110+Thraka@users.noreply.github.com> --- .../DesignerActionService.xml | 26 +++++++++++++++---- .../ObjectSelectorEditor.xml | 5 ++-- .../ComponentActionsType.xml | 8 +++--- xml/System.Windows.Forms/ComboBox.xml | 20 ++++++++++---- xml/System.Windows.Forms/DataGridView.xml | 8 +++--- xml/System.Windows.Forms/Form.xml | 5 ++-- xml/System.Windows.Forms/ListBox.xml | 5 ++-- xml/System.Windows.Forms/MonthCalendar.xml | 5 ++-- ...ToolStripHostedControlAccessibleObject.xml | 9 +++---- 9 files changed, 56 insertions(+), 35 deletions(-) diff --git a/xml/System.ComponentModel.Design/DesignerActionService.xml b/xml/System.ComponentModel.Design/DesignerActionService.xml index 70d4036ac3a..2614bc99d69 100644 --- a/xml/System.ComponentModel.Design/DesignerActionService.xml +++ b/xml/System.ComponentModel.Design/DesignerActionService.xml @@ -619,11 +619,27 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The component that the DesignerActions are associated with. + The to filter the associated designer actions with. + Returns the collection of designer action item lists of the specified type associated with a component. + The collection of designer actions of the specified type for the specified component. + is . + + method filters on the `type` parameter, which can have one of the following values. + +|Value|Description| +|-----------|-----------------| +||All associated designer actions.| +||Pull-model designer actions only.| +||Push-model designer actions only.| + + If the associated designer for a component does not supply a pull-model designer action list, then the method will instead use the designer's design-time shortcut menu items from the property. + + ]]> + diff --git a/xml/System.ComponentModel.Design/ObjectSelectorEditor.xml b/xml/System.ComponentModel.Design/ObjectSelectorEditor.xml index 740e1652275..cca477a09b1 100644 --- a/xml/System.ComponentModel.Design/ObjectSelectorEditor.xml +++ b/xml/System.ComponentModel.Design/ObjectSelectorEditor.xml @@ -135,9 +135,8 @@ - To be added. - To be added. - To be added. + The tree view control to modify. + Modify a Windows Forms control to use the new Explorer style theme. diff --git a/xml/System.Windows.Forms.Design/ComponentActionsType.xml b/xml/System.Windows.Forms.Design/ComponentActionsType.xml index 3a4806c516e..e000e09b258 100644 --- a/xml/System.Windows.Forms.Design/ComponentActionsType.xml +++ b/xml/System.Windows.Forms.Design/ComponentActionsType.xml @@ -14,7 +14,7 @@ System.Enum - To be added. + Designer action items that can be associated with a component. To be added. @@ -36,7 +36,7 @@ 0 - To be added. + Represents component and service type designer actions. @@ -57,7 +57,7 @@ 1 - To be added. + Represents pull-model designer actions. @@ -78,7 +78,7 @@ 2 - To be added. + Represents push-model designer actions. diff --git a/xml/System.Windows.Forms/ComboBox.xml b/xml/System.Windows.Forms/ComboBox.xml index 6a8df7263fc..5200eb3f722 100644 --- a/xml/System.Windows.Forms/ComboBox.xml +++ b/xml/System.Windows.Forms/ComboBox.xml @@ -3106,11 +3106,21 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + The window message to process, passed by reference. + One of the enumeration values that represent the key to process. + Processes a command key. + + if the character was processed by the control; otherwise, . + + method first determines whether the control has a , and if so, enables the to process the command key. If the command key is not a menu shortcut and the control has a parent, the key is passed to the parent's method. The net effect is that command keys are "bubbled" up the control hierarchy. In addition to the key the user pressed, the key data also indicates which, if any, modifier keys were pressed at the same time as the key. Modifier keys include the SHIFT, CTRL, and ALT keys. + + ]]> + diff --git a/xml/System.Windows.Forms/DataGridView.xml b/xml/System.Windows.Forms/DataGridView.xml index 63c8cd5a55f..b3155d19d01 100644 --- a/xml/System.Windows.Forms/DataGridView.xml +++ b/xml/System.Windows.Forms/DataGridView.xml @@ -15233,10 +15233,10 @@ - To be added. - To be added. - To be added. - To be added. + A bitwise combination of the enumeration values that represent the key or keys to process. + Activates the keyboard tooltip. + + if the key was processed; otherwise, . diff --git a/xml/System.Windows.Forms/Form.xml b/xml/System.Windows.Forms/Form.xml index 4681af6fd9f..d0b25a4b16d 100644 --- a/xml/System.Windows.Forms/Form.xml +++ b/xml/System.Windows.Forms/Form.xml @@ -1377,9 +1377,8 @@ - To be added. - To be added. - To be added. + Creates a new accessibility object for the control. + A new accessible object for the control. diff --git a/xml/System.Windows.Forms/ListBox.xml b/xml/System.Windows.Forms/ListBox.xml index 1723e4e06d4..e20d61f9cd5 100644 --- a/xml/System.Windows.Forms/ListBox.xml +++ b/xml/System.Windows.Forms/ListBox.xml @@ -2020,9 +2020,8 @@ - To be added. - To be added. - To be added. + An event data instance. + Raises the event. diff --git a/xml/System.Windows.Forms/MonthCalendar.xml b/xml/System.Windows.Forms/MonthCalendar.xml index 510a151e2f8..f8b2f084871 100644 --- a/xml/System.Windows.Forms/MonthCalendar.xml +++ b/xml/System.Windows.Forms/MonthCalendar.xml @@ -1757,9 +1757,8 @@ The is only available in applicatio - To be added. - To be added. - To be added. + An event data instance. + Raises the event. diff --git a/xml/System.Windows.Forms/ToolStripControlHost+ToolStripHostedControlAccessibleObject.xml b/xml/System.Windows.Forms/ToolStripControlHost+ToolStripHostedControlAccessibleObject.xml index 27d12ae1527..4db7442bc09 100644 --- a/xml/System.Windows.Forms/ToolStripControlHost+ToolStripHostedControlAccessibleObject.xml +++ b/xml/System.Windows.Forms/ToolStripControlHost+ToolStripHostedControlAccessibleObject.xml @@ -15,7 +15,7 @@ - To be added. + Represents the accessible object control host responsible for accessible navigation within the standard items and hosted controls like TextBox, ComboBox, ProgressBar, etc. To be added. @@ -37,10 +37,9 @@ - To be added. - To be added. - To be added. - To be added. + The control hosted in the container. + The container which hosts a control on the . + Initializes a new instance with the specified tool strip hosted control and tool strip control host. From 73381c24bfe8048c69c2b82eda4386dd155227e1 Mon Sep 17 00:00:00 2001 From: Asugakoisi <51259305+Asugakoisi@users.noreply.github.com> Date: Tue, 31 Mar 2020 06:37:34 +0900 Subject: [PATCH 6/6] Update assemblyinstaller.cs (#4044) * Update assemblyinstaller.cs * Update assemblyinstaller.vb * Update assemblyinstaller.cpp --- .../AssemblyInstaller/CPP/assemblyinstaller.cpp | 3 --- .../AssemblyInstaller/CS/assemblyinstaller.cs | 5 +---- .../AssemblyInstaller/VB/assemblyinstaller.vb | 3 +-- 3 files changed, 2 insertions(+), 9 deletions(-) diff --git a/samples/snippets/cpp/VS_Snippets_CLR/AssemblyInstaller/CPP/assemblyinstaller.cpp b/samples/snippets/cpp/VS_Snippets_CLR/AssemblyInstaller/CPP/assemblyinstaller.cpp index cb4c8b91c6c..cc5af7108ce 100644 --- a/samples/snippets/cpp/VS_Snippets_CLR/AssemblyInstaller/CPP/assemblyinstaller.cpp +++ b/samples/snippets/cpp/VS_Snippets_CLR/AssemblyInstaller/CPP/assemblyinstaller.cpp @@ -33,9 +33,6 @@ int main() // Commit the 'MyAssembly' assembly. myAssemblyInstaller->Commit( mySavedState ); } - catch ( ArgumentException^ ) - { - } catch ( Exception^ e ) { Console::WriteLine( e->Message ); diff --git a/samples/snippets/csharp/VS_Snippets_CLR/AssemblyInstaller/CS/assemblyinstaller.cs b/samples/snippets/csharp/VS_Snippets_CLR/AssemblyInstaller/CS/assemblyinstaller.cs index c6e6cffab75..bf3e2b4d6a2 100644 --- a/samples/snippets/csharp/VS_Snippets_CLR/AssemblyInstaller/CS/assemblyinstaller.cs +++ b/samples/snippets/csharp/VS_Snippets_CLR/AssemblyInstaller/CS/assemblyinstaller.cs @@ -37,13 +37,10 @@ static void Main() // Commit the 'MyAssembly' assembly. myAssemblyInstaller.Commit( mySavedState ); } - catch (ArgumentException) - { - } catch (Exception e) { Console.WriteLine( e.Message ); } } } -// \ No newline at end of file +// diff --git a/samples/snippets/visualbasic/VS_Snippets_CLR/AssemblyInstaller/VB/assemblyinstaller.vb b/samples/snippets/visualbasic/VS_Snippets_CLR/AssemblyInstaller/VB/assemblyinstaller.vb index 38c41997e35..be17bf73a95 100644 --- a/samples/snippets/visualbasic/VS_Snippets_CLR/AssemblyInstaller/VB/assemblyinstaller.vb +++ b/samples/snippets/visualbasic/VS_Snippets_CLR/AssemblyInstaller/VB/assemblyinstaller.vb @@ -33,10 +33,9 @@ Class AssemblyInstaller_Example ' Commit the 'MyAssembly' assembly. myAssemblyInstaller.Commit(mySavedState) - Catch e As ArgumentException Catch e As Exception Console.WriteLine(e.Message) End Try End Sub End Class -' \ No newline at end of file +'