Skip to content

Added documentation for System.Net.Security APIs targeted for 3.0 #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2019
Merged

Added documentation for System.Net.Security APIs targeted for 3.0 #2788

merged 2 commits into from
Jul 24, 2019

Conversation

@jozkee
Copy link
Member

@jozkee jozkee commented Jul 21, 2019

List of APIs documented:

  • AuthenticatedStream
    • DisposeAsync
  • NegotiateStream
    • DisposeAsync
  • SslStream
    • DisposeAsync
    • ReadAsync(System.Memory{System.Byte},System.Threading.CancellationToken)
    • ReadAsync(System.Byte[],System.Int32,System.Int32,System.Threading.CancellationToken)
    • ReadByte
    • WriteAsync(System.ReadOnlyMemory{System.Byte},System.Threading.CancellationToken)
    • WriteAsync(System.Byte[],System.Int32,System.Int32,System.Threading.CancellationToken)

These changes contribute to System.Net.Security namespace, I am excluding changes related to
CipherSuitesPolicy, SslStream.NegotiatedCipherSuite and TlsCipherSuite so I can tackle them in a separate PR.

@jozkee jozkee requested a review from karelz as a code owner July 21, 2019 21:06
@jozkee jozkee changed the title Added documentation for System.Net.Sockets APIs targeted for 3.0 Added documentation for System.Net.Security APIs targeted for 3.0 Jul 21, 2019
@jozkee
Copy link
Member Author

jozkee commented Jul 21, 2019

@rpetrusha @mairaw @carlossanlop
@dotnet/ncl

scalablecory
scalablecory reviewed Jul 21, 2019
View reviewed changes
rpetrusha
rpetrusha suggested changes Jul 23, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, @jozkee. I've left a few minor suggestions.

rpetrusha
rpetrusha reviewed Jul 23, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also suggested a correction to one broken API reference.

@rpetrusha rpetrusha added this to the July 2019 milestone Jul 23, 2019
@jozkee @carlossanlop
Apply suggestions from code review
941cba7 
Addressing PR suggestions.

Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
@mairaw mairaw added new-content Indicates PRs that contain new articles 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review labels Jul 24, 2019
rpetrusha
rpetrusha approved these changes Jul 24, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional changes, @jozkee. I'll merge your PR now.

@rpetrusha rpetrusha removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Jul 24, 2019
@rpetrusha rpetrusha merged commit da537ea into dotnet:master Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karelz karelz Awaiting requested review from karelz

3 more reviewers

@carlossanlop carlossanlop carlossanlop left review comments

@scalablecory scalablecory scalablecory left review comments

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jozkee jozkee

Labels

🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles

Projects

None yet

Milestone

July 2019

Development

Successfully merging this pull request may close these issues.

5 participants

@jozkee @carlossanlop @scalablecory @rpetrusha @mairaw