Updated CliSymbolResult and moved Locations there

Author: KathleenDollard

src/System.CommandLine/Parsing/CliCommandResult.cs

@@ -17,8 +17,13 @@ public class CliCommandResult : CliSymbolResult
     /// Creates a CommandValueResult instance
     /// </summary>
     /// <param name="command">The CliCommand that the result is for.</param>
+    /// <param name="locations"></param>
     /// <param name="parent">The parent command in the case of a CLI hierarchy, or null if there is no parent.</param>
-    internal CliCommandResult(CliCommand command, CliCommandResult? parent = null)
+    internal CliCommandResult(
+        CliCommand command,
+        IEnumerable<Location> locations,
+        CliCommandResult? parent = null)
+        : base(locations)
     {
         Command = command;
         Parent = parent;

src/System.CommandLine/Parsing/CliSymbolResult.cs

@@ -1,9 +1,25 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-namespace System.CommandLine.Parsing
+using System.Collections.Generic;
+
+namespace System.CommandLine.Parsing;
+
+/// <summary>
+/// Base class for CliValueResult and CliCommandResult.
+/// </summary>
+/// <remarks>
+/// Common values such as `TextForDisplay` are expected
+/// </remarks>
+public abstract class CliSymbolResult(IEnumerable<Location> locations)
 {
-    public class CliSymbolResult
-    {
-    }
-}
+    /// <summary>
+    /// Gets the locations at which the tokens that made up the value appeared.
+    /// </summary>
+    /// <remarks>
+    /// This needs to be a collection for CliValueType because collection types have 
+    /// multiple tokens and they will not be simple offsets when response files are used.
+    /// </remarks>
+    public IEnumerable<Location> Locations { get; } = locations;
+
+}

src/System.CommandLine/Parsing/CliValueResult.cs

@@ -17,10 +17,10 @@ private CliValueResult(
         ValueResultOutcome outcome,
         // TODO: Error should be an Enumerable<Error> and perhaps should not be here at all, only on ParseResult
         string? error = null)
+        : base(locations)
     {
         ValueSymbol = valueSymbol;
         Value = value;
-        Locations = locations;
         Outcome = outcome;
         // TODO: Probably a collection of errors here
         Error = error;
@@ -79,14 +79,6 @@ internal CliValueResult(
             ? default
             : (T?)Value;
 
-    /// <summary>
-    /// Gets the locations at which the tokens that made up the value appeared.
-    /// </summary>
-    /// <remarks>
-    /// This needs to be a collection because collection types have multiple tokens and they will not be simple offsets when response files are used.
-    /// </remarks>
-    public IEnumerable<Location> Locations { get; }
-
     /// <summary>
     /// True when parsing and converting the value was successful
     /// </summary>