IsDeprecated should be false when version-neutral

commonsensesoftware · commonsensesoftware · commit f6a01d46edec · 2022-08-23T15:58:51.000-07:00
diff --git a/src/Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer/ApiDescriptionExtensions.cs b/src/Microsoft.AspNetCore.Mvc.Versioning.ApiExplorer/ApiDescriptionExtensions.cs
@@ -39,7 +39,7 @@ public static bool IsDeprecated( this ApiDescription apiDescription )
             var apiVersion = apiDescription.GetApiVersion();
             var model = apiDescription.ActionDescriptor.GetApiVersionModel( Explicit | Implicit );
 
-            return model.DeprecatedApiVersions.Contains( apiVersion );
+            return !model.IsApiVersionNeutral && model.DeprecatedApiVersions.Contains( apiVersion );
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public static bool IsDeprecated( this ApiDescription apiDescription )`
`39`	`39`	`var apiVersion = apiDescription.GetApiVersion();`
`40`	`40`	`var model = apiDescription.ActionDescriptor.GetApiVersionModel( Explicit \| Implicit );`
`41`	`41`
`42`		`- return model.DeprecatedApiVersions.Contains( apiVersion );`
	`42`	`+ return !model.IsApiVersionNeutral && model.DeprecatedApiVersions.Contains( apiVersion );`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`/// <summary>`