February 2017 Bug Fixes (#92)

* Use all candidates instead of just filtered matches. Fixes #83.

* Reduce dependencies to Microsoft.AspNetMvc.Mvc.Core and update to version 1.1.1 per MSA4010983. Resolves #66. Fixes #78.

* Strongly-typed resources should be scope internal

* Support reading API version from URL segment. Fixes #91

* Refactored API version readers to use composition over inheritance

* Added new support for providing custom 400 and 405 responses related to API versioning

* Refactored error respones to return 405 over 400 when appropriate. Fixes #65

* Corrected license text to be compliant with Microsoft CELA guidelines

Author: commonsensesoftware

ApiVersioningWithSamples.sln

@@ -49,14 +49,16 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Versioning", "Versioning",
 		src\Common\Versioning\ConstantApiVersionSelector.cs = src\Common\Versioning\ConstantApiVersionSelector.cs
 		src\Common\Versioning\CurrentImplementationApiVersionSelector.cs = src\Common\Versioning\CurrentImplementationApiVersionSelector.cs
 		src\Common\Versioning\DefaultApiVersionSelector.cs = src\Common\Versioning\DefaultApiVersionSelector.cs
+		src\Common\Versioning\ErrorResponseContext.cs = src\Common\Versioning\ErrorResponseContext.cs
 		src\Common\Versioning\HeaderApiVersionReader.cs = src\Common\Versioning\HeaderApiVersionReader.cs
 		src\Common\Versioning\IApiVersionNeutral.cs = src\Common\Versioning\IApiVersionNeutral.cs
 		src\Common\Versioning\IApiVersionProvider.cs = src\Common\Versioning\IApiVersionProvider.cs
 		src\Common\Versioning\IApiVersionReader.cs = src\Common\Versioning\IApiVersionReader.cs
 		src\Common\Versioning\IApiVersionSelector.cs = src\Common\Versioning\IApiVersionSelector.cs
+		src\Common\Versioning\IErrorResponseProvider.cs = src\Common\Versioning\IErrorResponseProvider.cs
 		src\Common\Versioning\LowestImplementedApiVersionSelector.cs = src\Common\Versioning\LowestImplementedApiVersionSelector.cs
 		src\Common\Versioning\QueryStringApiVersionReader.cs = src\Common\Versioning\QueryStringApiVersionReader.cs
-		src\Common\Versioning\QueryStringOrHeaderApiVersionReader.cs = src\Common\Versioning\QueryStringOrHeaderApiVersionReader.cs
+		src\Common\Versioning\UrlSegmentApiVersionReader.cs = src\Common\Versioning\UrlSegmentApiVersionReader.cs
 	EndProjectSection
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "samples", "samples", "{915BB224-B1D0-4E27-A348-67FCC77AAA44}"

LICENSE

@@ -1,6 +1,6 @@
-The MIT License (MIT)
+MIT License
 
-Copyright (c) 2015 Commonsense Software
+Copyright (c) Microsoft Corporation. All rights reserved.
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -18,5 +18,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
-
+SOFTWARE

samples/aspnetcore/BasicSample/project.json

@@ -4,7 +4,7 @@
             "version": "1.0.0",
             "type": "platform"
         },
-        "Microsoft.AspNetCore.Mvc": "1.0.0",
+        "Microsoft.AspNetCore.Mvc": "1.1.1",
         "Microsoft.AspNetCore.Server.IISIntegration": "1.0.0",
         "Microsoft.AspNetCore.Server.Kestrel": "1.0.0",
         "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.0.0",

samples/aspnetcore/ConventionsSample/project.json

@@ -4,7 +4,7 @@
       "version": "1.0.0",
       "type": "platform"
     },
-    "Microsoft.AspNetCore.Mvc": "1.0.0",
+    "Microsoft.AspNetCore.Mvc": "1.1.1",
     "Microsoft.AspNetCore.Server.IISIntegration": "1.0.0",
     "Microsoft.AspNetCore.Server.Kestrel": "1.0.0",
     "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.0.0",

samples/webapi/AdvancedODataWebApiSample/Startup.cs

@@ -24,14 +24,9 @@ public void Configuration( IAppBuilder appBuilder )
                 {
                     o.ReportApiVersions = true;
                     o.AssumeDefaultVersionWhenUnspecified = true;
-                    o.ApiVersionReader = new QueryStringOrHeaderApiVersionReader()
-                    {
-                        HeaderNames =
-                        {
-                            "api-version",
-                            "x-ms-version"
-                        }
-                    };
+                    o.ApiVersionReader = ApiVersionReader.Combine(
+                        new QueryStringApiVersionReader(),
+                        new HeaderApiVersionReader( "api-version", "x-ms-version" ) );
                 } );
             configuration.EnableCaseInsensitive( true );
             configuration.EnableUnqualifiedNameCall( true );

src/Common/Versioning/ApiVersionReader.cs

@@ -4,19 +4,98 @@ namespace Microsoft.Web.Http.Versioning
 namespace Microsoft.AspNetCore.Mvc.Versioning
 #endif
 {
+#if !WEBAPI
+    using Http;
+#endif
     using System;
     using System.Linq;
+    using System.Collections.Generic;
+    using System.Diagnostics.Contracts;
+#if WEBAPI
+    using HttpRequest = System.Net.Http.HttpRequestMessage;
+#endif
+    using static System.String;
 
     /// <summary>
-    /// Represents the base implementation of a service API version reader.
+    /// Provides utility functions for service API version readers.
     /// </summary>
-    public abstract partial class ApiVersionReader : IApiVersionReader
+    public static class ApiVersionReader
     {
         /// <summary>
-        /// Initializes a new instance of the <see cref="ApiVersionReader"/> class.
+        /// Returns a new API version reader that is a combination of the specified set.
         /// </summary>
-        protected ApiVersionReader()
+        /// <param name="apiVersionReaders">The <see cref="Array">array</see> of
+        /// <see cref="IApiVersionReader">API version readers</see> to combine.</param>
+        /// <returns>A new, unioned <see cref="IApiVersionReader">API version reader</see>.</returns>
+#if !WEBAPI
+        [CLSCompliant( false )]
+#endif
+        public static IApiVersionReader Combine( params IApiVersionReader[] apiVersionReaders )
+        {
+            Arg.NotNull( apiVersionReaders, nameof( apiVersionReaders ) );
+            Contract.Ensures( Contract.Result<IApiVersionReader>() != null );
+            Contract.EndContractBlock();
+
+            if ( apiVersionReaders.Length == 0 )
+            {
+                throw new ArgumentException( SR.ZeroApiVersionReaders, nameof( apiVersionReaders ) );
+            }
+
+            return new CombinedApiVersionReader( apiVersionReaders );
+        }
+
+        /// <summary>
+        /// Returns a new API version reader that is a combination of the specified set.
+        /// </summary>
+        /// <param name="apiVersionReaders">The <see cref="IEnumerable{T}">sequence</see> of
+        /// <see cref="IApiVersionReader">API version readers</see> to combine.</param>
+        /// <returns>A new, unioned <see cref="IApiVersionReader">API version reader</see>.</returns>
+#if !WEBAPI
+        [CLSCompliant( false )]
+#endif
+        public static IApiVersionReader Combine( IEnumerable<IApiVersionReader> apiVersionReaders )
         {
+            Arg.NotNull( apiVersionReaders, nameof( apiVersionReaders ) );
+            Contract.Ensures( Contract.Result<IApiVersionReader>() != null );
+            Contract.EndContractBlock();
+
+            var items = apiVersionReaders.ToArray();
+
+            if ( items.Length == 0 )
+            {
+                throw new ArgumentException( SR.ZeroApiVersionReaders, nameof( apiVersionReaders ) );
+            }
+
+            return new CombinedApiVersionReader( items );
+        }
+
+        sealed class CombinedApiVersionReader : IApiVersionReader
+        {
+            readonly IApiVersionReader[] apiVersionReaders;
+
+            internal CombinedApiVersionReader( IApiVersionReader[] apiVersionReaders )
+            {
+                Contract.Requires( apiVersionReaders != null );
+                Contract.Requires( apiVersionReaders.Length > 0 );
+                this.apiVersionReaders = apiVersionReaders;
+            }
+
+            public string Read( HttpRequest request )
+            {
+                var versions = new HashSet<string>( StringComparer.OrdinalIgnoreCase );
+
+                foreach ( var apiVersionReader in apiVersionReaders )
+                {
+                    var version = apiVersionReader.Read( request );
+
+                    if ( !IsNullOrEmpty( version ) )
+                    {
+                        versions.Add( version );
+                    }
+                }
+
+                return versions.EnsureZeroOrOneApiVersions();
+            }
         }
     }
-}
+}

src/Common/Versioning/ApiVersioningOptions.cs

@@ -7,15 +7,21 @@ namespace Microsoft.AspNetCore.Mvc.Versioning
     using Conventions;
     using System;
     using System.Diagnostics.Contracts;
+#if WEBAPI
+    using static Microsoft.Web.Http.Versioning.ApiVersionReader;
+#else
+    using static Microsoft.AspNetCore.Mvc.Versioning.ApiVersionReader;
+#endif
 
     /// <summary>
     /// Represents the possible API versioning options for services.
     /// </summary>
     public partial class ApiVersioningOptions
     {
         private ApiVersion defaultApiVersion = ApiVersion.Default;
-        private IApiVersionReader apiVersionReader = new QueryStringApiVersionReader();
+        private IApiVersionReader apiVersionReader = Combine( new QueryStringApiVersionReader(), new UrlSegmentApiVersionReader() );
         private IApiVersionSelector apiVersionSelector;
+        private IErrorResponseProvider errorResponseProvider = new DefaultErrorResponseProvider();
         private ApiVersionConventionBuilder conventions = new ApiVersionConventionBuilder();
 
         /// <summary>
@@ -80,7 +86,7 @@ public ApiVersion DefaultApiVersion
         /// service API version specified by a client. The default value is the
         /// <see cref="QueryStringApiVersionReader"/>, which only reads the service API version from
         /// the "api-version" query string parameter. Replace the default value with an alternate
-        /// implementation, such as the <see cref="QueryStringOrHeaderApiVersionReader"/>, which
+        /// implementation, such as the <see cref="HeaderApiVersionReader"/>, which
         /// can read the service API version from additional information like HTTP headers.</remarks>
 #if !WEBAPI
         [CLSCompliant( false )]
@@ -140,9 +146,31 @@ public ApiVersionConventionBuilder Conventions
             }
             set
             {
-                Arg.NotNull( conventions, nameof( conventions ) );
+                Arg.NotNull( value, nameof( value ) );
                 conventions = value;
             }
         }
+
+        /// <summary>
+        /// Gets or sets the object used to generate HTTP error responses related to API versioning.
+        /// </summary>
+        /// <value>An <see cref="IErrorResponseProvider">error response provider</see> object.
+        /// The default value is an instance of the <see cref="DefaultErrorResponseProvider"/>.</value>
+#if !WEBAPI
+        [CLSCompliant( false )]
+#endif
+        public IErrorResponseProvider ErrorResponses
+        {
+            get
+            {
+                Contract.Ensures( errorResponseProvider != null );
+                return errorResponseProvider;
+            }
+            set
+            {
+                Arg.NotNull( value, nameof( value ) );
+                errorResponseProvider = value;
+            }
+        }
     }
 }

src/Common/Versioning/ErrorResponseContext.cs

@@ -0,0 +1,30 @@
+#if WEBAPI
+namespace Microsoft.Web.Http.Versioning
+#else
+namespace Microsoft.AspNetCore.Mvc.Versioning
+#endif
+{
+    /// <summary>
+    /// Represents the contextual information used when generating HTTP error responses related to API versioning.
+    /// </summary>
+    public partial class ErrorResponseContext
+    {
+        /// <summary>
+        /// Gets the associated error code.
+        /// </summary>
+        /// <value>The associated error code.</value>
+        public string Code { get; }
+
+        /// <summary>
+        /// Gets the associated error message.
+        /// </summary>
+        /// <value>The error message.</value>
+        public string Message { get; }
+
+        /// <summary>
+        /// Gets the detailed error message.
+        /// </summary>
+        /// <value>The detailed error message, if any.</value>
+        public string MessageDetail { get; }
+    }
+}

src/Common/Versioning/HeaderApiVersionReader.cs

@@ -11,14 +11,12 @@ namespace Microsoft.AspNetCore.Mvc.Versioning
     /// <summary>
     /// Represents a service API version reader that reads the value from a HTTP header.
     /// </summary>
-    public partial class HeaderApiVersionReader : ApiVersionReader
+    public partial class HeaderApiVersionReader : IApiVersionReader
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="HeaderApiVersionReader"/> class.
         /// </summary>
-        public HeaderApiVersionReader()
-        {
-        }
+        public HeaderApiVersionReader() { }
 
         /// <summary>
         /// Initializes a new instance of the <see cref="HeaderApiVersionReader"/> class.

src/Common/Versioning/IErrorResponseProvider.cs

@@ -0,0 +1,36 @@
+#if WEBAPI
+namespace Microsoft.Web.Http.Versioning
+#else
+namespace Microsoft.AspNetCore.Mvc.Versioning
+#endif
+{
+#if WEBAPI
+    using IActionResult = System.Net.Http.HttpResponseMessage;
+#else
+    using Http;
+#endif
+    using System;
+
+    /// <summary>
+    /// Defines the behavior of an object that provides HTTP error responses related to API versioning.
+    /// </summary>
+#if !WEBAPI
+    [CLSCompliant( false )]
+#endif
+    public interface IErrorResponseProvider
+    {
+        /// <summary>
+        /// Creates and returns a new HTTP 400 (Bad Request) given the provided context.
+        /// </summary>
+        /// <param name="context">The <see cref="ErrorResponseContext">error context</see> used to generate response.</param>
+        /// <returns>The generated <see cref="IActionResult">response</see>.</returns>
+        IActionResult BadRequest( ErrorResponseContext context );
+
+        /// <summary>
+        /// Creates and returns a new HTTP 405 (Method Not Allowed) given the provided context.
+        /// </summary>
+        /// <param name="context">The <see cref="ErrorResponseContext">error context</see> used to generate response.</param>
+        /// <returns>The generated <see cref="IActionResult">response</see>.</returns>
+        IActionResult MethodNotAllowed( ErrorResponseContext context );
+    }
+}