Fix all code analysis issues generated by the .NET 7.0.101 SDK

Author: commonsensesoftware

src/Abstractions/src/Asp.Versioning.Abstractions/AdvertiseApiVersionsAttribute.cs

@@ -1,5 +1,10 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 
+#pragma warning disable IDE0079
+#pragma warning disable CA1019
+#pragma warning disable CA1033
+#pragma warning disable CA1813
+
 namespace Asp.Versioning;
 
 using static System.AttributeTargets;

src/Abstractions/src/Asp.Versioning.Abstractions/ApiVersion.cs

@@ -341,7 +341,11 @@ public virtual int CompareTo( ApiVersion? other )
     public virtual string ToString( string? format, IFormatProvider? formatProvider )
     {
         var provider = ApiVersionFormatProvider.GetInstance( formatProvider );
+#pragma warning disable IDE0079
+#pragma warning disable CA1062 // Validate arguments of public methods
         return provider.Format( format, this, formatProvider );
+#pragma warning restore CA1062 // Validate arguments of public methods
+#pragma warning restore IDE0079
     }
 
     private static string? ValidateStatus( string? status, Func<string?, bool> isValid )

src/Abstractions/src/Asp.Versioning.Abstractions/ApiVersionAttribute.cs

@@ -1,5 +1,10 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 
+#pragma warning disable IDE0079
+#pragma warning disable CA1019
+#pragma warning disable CA1033
+#pragma warning disable CA1813
+
 namespace Asp.Versioning;
 
 using static System.AttributeTargets;

src/Abstractions/src/Asp.Versioning.Abstractions/IApiVersionNeutral.cs

@@ -1,5 +1,8 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 
+#pragma warning disable IDE0079
+#pragma warning disable CA1040
+
 namespace Asp.Versioning;
 
 /// <summary>

src/Abstractions/src/Asp.Versioning.Abstractions/LinkHeaderValue.cs

@@ -572,11 +572,13 @@ public IEnumerator<KeyValuePair<StringSegment, StringSegment>> GetEnumerator()
                 }
 
                 // REF: https://datatracker.ietf.org/doc/html/rfc8288#appendix-B.3 #9
+#pragma warning disable CA1308 // Normalize strings to uppercase (all ascii and should normalize to lowercase)
 #if NETSTANDARD1_0
                 var key = remaining.Substring( start, end - start ).ToLowerInvariant();
 #else
                 var key = new StringSegment( remaining.Substring( start, end - start ).ToLowerInvariant() );
 #endif
+#pragma warning restore CA1308 // Normalize strings to uppercase
 
                 start = end;
                 ConsumeWhitespace();

src/Abstractions/src/Asp.Versioning.Abstractions/MapToApiVersionAttribute.cs

@@ -1,5 +1,10 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 
+#pragma warning disable IDE0079
+#pragma warning disable CA1019
+#pragma warning disable CA1033
+#pragma warning disable CA1813
+
 namespace Asp.Versioning;
 
 using static System.AttributeTargets;

src/Abstractions/src/Asp.Versioning.Abstractions/net7.0/ApiVersion.cs

@@ -11,6 +11,10 @@ public partial class ApiVersion : ISpanFormattable
     public virtual bool TryFormat( Span<char> destination, out int charsWritten, ReadOnlySpan<char> format, IFormatProvider? provider )
     {
         var instance = ApiVersionFormatProvider.GetInstance( provider );
+#pragma warning disable IDE0079
+#pragma warning disable CA1062 // Validate arguments of public methods
         return instance.TryFormat( destination, out charsWritten, format, this, provider );
+#pragma warning restore CA1062 // Validate arguments of public methods
+#pragma warning restore IDE0079
     }
 }

src/AspNet/OData/test/Asp.Versioning.WebApi.OData.ApiExplorer.Tests/Simulators/V3/SuppliersController.cs

@@ -1,9 +1,11 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 
 #pragma warning disable IDE0060 // Remove unused parameter
+#pragma warning disable IDE0079 // Remove unnecessary suppression
 #pragma warning disable SA1625 // Element documentation should not be copied and pasted
 
 namespace Asp.Versioning.Simulators.V3;
+#pragma warning restore IDE0079 // Remove unnecessary suppression
 
 using Asp.Versioning.OData;
 using Asp.Versioning.Simulators.Models;

src/AspNetCore/Acceptance/Asp.Versioning.Mvc.Acceptance.Tests/HttpServerFixture.cs

@@ -18,7 +18,7 @@ public abstract partial class HttpServerFixture
 {
     private string visualizationUrl;
 
-    public string DirectedGraphVisualizationUrl =>
+    internal string DirectedGraphVisualizationUrl =>
         visualizationUrl ??= GenerateEndpointDirectedGraph( Server.Services );
 
     protected virtual void OnConfigurePartManager( ApplicationPartManager partManager ) =>

src/AspNetCore/Acceptance/Asp.Versioning.Mvc.Acceptance.Tests/OData/Basic/Controllers/WeatherForecastsController.cs

@@ -1,6 +1,7 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 
 #pragma warning disable IDE0060 // Remove unused parameter
+#pragma warning disable IDE0079
 #pragma warning disable CA1822 // Mark members as static
 
 namespace Asp.Versioning.OData.Basic.Controllers;