Fix convention to only support POST API descriptions for EDM actions

Author: Chris Martinez

src/Common.OData.ApiExplorer/AspNet.OData/Builder/ODataValidationSettingsConvention.cs

@@ -139,23 +139,6 @@ protected virtual ApiParameterDescription NewCountParameter( ODataQueryOptionDes
             return NewParameterDescription( GetName( Count ), description, typeof( bool ), defaultValue: false );
         }
 
-        static bool IsSupportHttpMethod( string httpMethod )
-        {
-            Contract.Requires( !string.IsNullOrEmpty( httpMethod ) );
-
-            switch ( httpMethod.ToUpperInvariant() )
-            {
-                // query or function
-                case "GET":
-
-                // action
-                case "POST":
-                    return true;
-            }
-
-            return false;
-        }
-
         string GetName( AllowedQueryOptions option )
         {
             Contract.Requires( option == Filter || ( option > Filter && option < Supported && ( (int) option % 2 == 0 ) ) );

src/Microsoft.AspNet.OData.Versioning.ApiExplorer/AspNet.OData/Builder/ODataValidationSettingsConvention.cs

@@ -1,6 +1,7 @@
 namespace Microsoft.AspNet.OData.Builder
 {
     using Microsoft.AspNet.OData.Extensions;
+    using Microsoft.OData.Edm;
     using System;
     using System.Diagnostics.Contracts;
     using System.Web.Http.Controllers;
@@ -18,7 +19,7 @@ public virtual void ApplyTo( ApiDescription apiDescription )
         {
             Arg.NotNull( apiDescription, nameof( apiDescription ) );
 
-            if ( !IsSupportHttpMethod( apiDescription.HttpMethod.Method ) )
+            if ( !IsSupported( apiDescription ) )
             {
                 return;
             }
@@ -136,5 +137,22 @@ static ApiParameterDescription SetAction( ApiParameterDescription parameter, Htt
 
             return parameter;
         }
+
+        static bool IsSupported( ApiDescription apiDescription )
+        {
+            Contract.Requires( apiDescription != null );
+
+            switch ( apiDescription.HttpMethod.Method.ToUpperInvariant() )
+            {
+                case "GET":
+                    // query or function
+                    return true;
+                case "POST":
+                    // action
+                    return apiDescription.Operation()?.IsAction() == true;
+            }
+
+            return false;
+        }
     }
 }

src/Microsoft.AspNetCore.OData.Versioning.ApiExplorer/AspNet.OData/Builder/ODataValidationSettingsConvention.cs

@@ -1,10 +1,14 @@
 namespace Microsoft.AspNet.OData.Builder
 {
+    using Microsoft.AspNet.OData.Routing;
+    using Microsoft.AspNet.OData.Routing.Template;
     using Microsoft.AspNetCore.Mvc.Abstractions;
     using Microsoft.AspNetCore.Mvc.ApiExplorer;
+    using Microsoft.OData.Edm;
     using System;
     using System.Collections.Generic;
     using System.Diagnostics.Contracts;
+    using System.Linq;
     using static Microsoft.AspNet.OData.Query.AllowedQueryOptions;
     using static Microsoft.AspNetCore.Http.StatusCodes;
     using static Microsoft.AspNetCore.Mvc.ModelBinding.BindingSource;
@@ -20,7 +24,7 @@ public virtual void ApplyTo( ApiDescription apiDescription )
         {
             Arg.NotNull( apiDescription, nameof( apiDescription ) );
 
-            if ( !IsSupportHttpMethod( apiDescription.HttpMethod ) )
+            if ( !IsSupported( apiDescription ) )
             {
                 return;
             }
@@ -156,5 +160,22 @@ static bool IsSingleResult( ApiDescription description, out Type resultType )
             resultType = responseType;
             return true;
         }
+
+        static bool IsSupported( ApiDescription apiDescription )
+        {
+            Contract.Requires( apiDescription != null );
+
+            switch ( apiDescription.HttpMethod.ToUpperInvariant() )
+            {
+                case "GET":
+                    // query or function
+                    return true;
+                case "POST":
+                    // action
+                    return apiDescription.Operation()?.IsAction() == true;
+            }
+
+            return false;
+        }
     }
 }