Update comments

commonsensesoftware · commonsensesoftware · commit 770cf6aae407 · 2023-12-07T11:46:45.000-08:00
diff --git a/src/AspNetCore/WebApi/src/Asp.Versioning.Http/DependencyInjection/IServiceCollectionExtensions.cs b/src/AspNetCore/WebApi/src/Asp.Versioning.Http/DependencyInjection/IServiceCollectionExtensions.cs
@@ -153,8 +153,8 @@ LinkGenerator NewFactory( IServiceProvider serviceProvider )
         }
     }
 
-    // TODO: Remove in .NET 8.0
-    // REF: https://github.com/dotnet/aspnetcore/issues/45051
+    // TODO: Remove in .NET 9.0 or .NET 8.0 patch
+    // BUG: https://github.com/dotnet/aspnetcore/issues/52577
     private static void TryAddProblemDetailsRfc7231Compliance( IServiceCollection services )
     {
         var descriptor = services.FirstOrDefault( IsDefaultProblemDetailsWriter );
diff --git a/src/AspNetCore/WebApi/src/Asp.Versioning.Http/Rfc7231ProblemDetailsWriter.cs b/src/AspNetCore/WebApi/src/Asp.Versioning.Http/Rfc7231ProblemDetailsWriter.cs
@@ -36,6 +36,9 @@ public bool CanWrite( ProblemDetailsContext context )
         {
             var acceptHeaderValue = acceptHeader[i];
 
+            // TODO: the logic is inverted in .NET 8. remove when fixed
+            // BUG: https://github.com/dotnet/aspnetcore/issues/52577
+            // REF: https://github.com/dotnet/aspnetcore/blob/release/8.0/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs#L38
             if ( acceptHeaderValue.IsSubsetOf( jsonMediaType ) ||
                  acceptHeaderValue.IsSubsetOf( problemDetailsJsonMediaType ) )
             {

Original file line number	Diff line number	Diff line change
`@@ -153,8 +153,8 @@ LinkGenerator NewFactory( IServiceProvider serviceProvider )`
`153`	`153`	`}`
`154`	`154`	`}`
`155`	`155`
`156`		`- // TODO: Remove in .NET 8.0`
`157`		`- // REF: https://github.com/dotnet/aspnetcore/issues/45051`
	`156`	`+ // TODO: Remove in .NET 9.0 or .NET 8.0 patch`
	`157`	`+ // BUG: https://github.com/dotnet/aspnetcore/issues/52577`
`158`	`158`	`private static void TryAddProblemDetailsRfc7231Compliance( IServiceCollection services )`
`159`	`159`	`{`
`160`	`160`	`var descriptor = services.FirstOrDefault( IsDefaultProblemDetailsWriter );`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,9 @@ public bool CanWrite( ProblemDetailsContext context )`
`36`	`36`	`{`
`37`	`37`	`var acceptHeaderValue = acceptHeader[i];`
`38`	`38`
	`39`	`+ // TODO: the logic is inverted in .NET 8. remove when fixed`
	`40`	`+ // BUG: https://github.com/dotnet/aspnetcore/issues/52577`
	`41`	`+ // REF: https://github.com/dotnet/aspnetcore/blob/release/8.0/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs#L38`
`39`	`42`	`if ( acceptHeaderValue.IsSubsetOf( jsonMediaType ) \|\|`
`40`	`43`	`acceptHeaderValue.IsSubsetOf( problemDetailsJsonMediaType ) )`
`41`	`44`	`{`