Prefer concrete types for better performance

Author: commonsensesoftware

src/AspNetCore/OData/src/Asp.Versioning.OData.ApiExplorer/ApiExplorer/ODataApiDescriptionProvider.cs

@@ -198,7 +198,7 @@ private static bool IsNavigationPropertyLink( ODataPathTemplate template ) =>
 
     private static bool TryMatchModelVersion(
         ApiDescription description,
-        IReadOnlyList<IODataRoutingMetadata> items,
+        IODataRoutingMetadata[] items,
         [NotNullWhen( true )] out IODataRoutingMetadata? metadata )
     {
         if ( description.GetApiVersion() is not ApiVersion apiVersion )
@@ -215,7 +215,7 @@ private static bool TryMatchModelVersion(
             return false;
         }
 
-        for ( var i = 0; i < items.Count; i++ )
+        for ( var i = 0; i < items.Length; i++ )
         {
             var item = items[i];
             var otherApiVersion = item.Model.GetApiVersion();

src/AspNetCore/OData/src/Asp.Versioning.OData.ApiExplorer/Conventions/ODataQueryOptionsConventionBuilder.cs

@@ -4,20 +4,21 @@ namespace Asp.Versioning.Conventions;
 
 using Microsoft.AspNetCore.Mvc.ApiExplorer;
 using Microsoft.AspNetCore.Mvc.Controllers;
+using System.Reflection;
 
 /// <content>
 /// Provides additional implementation specific to Microsoft ASP.NET Core.
 /// </content>
 [CLSCompliant( false )]
 public partial class ODataQueryOptionsConventionBuilder
 {
-    private static Type GetController( ApiDescription apiDescription )
+    private static TypeInfo GetController( ApiDescription apiDescription )
     {
         if ( apiDescription.ActionDescriptor is ControllerActionDescriptor action )
         {
             return action.ControllerTypeInfo;
         }
 
-        return typeof( object );
+        return typeof( object ).GetTypeInfo();
     }
 }

src/AspNetCore/OData/src/Asp.Versioning.OData/OData/Batch/ODataBatchPathMapping.cs

@@ -99,7 +99,7 @@ private static void MergeRouteData( HttpContext context, RouteValueDictionary ro
     private ODataBatchHandler? SelectBestCandidate(
         HttpContext context,
         ref PathString path,
-        IReadOnlyDictionary<ApiVersion, int> candidates,
+        Dictionary<ApiVersion, int> candidates,
         RouteValueDictionary routeData )
     {
         if ( candidates.Count == 0 )

src/AspNetCore/OData/test/Asp.Versioning.OData.Tests/ApplicationModels/ODataControllerSpecificationTest.cs

@@ -35,20 +35,20 @@ public void is_satisfied_by_should_return_expected_value( Type controllerType, b
     private sealed class NormalODataController : ODataController
     {
         [EnableQuery]
-        public IActionResult Get() => Ok();
+        public OkResult Get() => Ok();
     }
 
     [ODataAttributeRouting]
     private sealed class CustomODataController : ControllerBase
     {
         [EnableQuery]
-        public IActionResult Get() => Ok();
+        public OkResult Get() => Ok();
     }
 
     [Route( "api/test" )]
     private sealed class NonODataController : ControllerBase
     {
         [HttpGet]
-        public IActionResult Get() => Ok();
+        public OkResult Get() => Ok();
     }
 }

src/AspNetCore/WebApi/src/Asp.Versioning.Mvc.ApiExplorer/DefaultApiVersionDescriptionProvider.cs

@@ -69,7 +69,7 @@ protected virtual IReadOnlyList<ApiVersionDescription> Describe( IReadOnlyList<A
         return descriptions.OrderBy( d => d.ApiVersion ).ToArray();
     }
 
-    private void BucketizeApiVersions( IReadOnlyList<ApiVersionMetadata> metadata, ISet<ApiVersion> supported, ISet<ApiVersion> deprecated )
+    private void BucketizeApiVersions( IReadOnlyList<ApiVersionMetadata> metadata, HashSet<ApiVersion> supported, HashSet<ApiVersion> deprecated )
     {
         var declared = new HashSet<ApiVersion>();
         var advertisedSupported = new HashSet<ApiVersion>();
@@ -115,7 +115,7 @@ private void BucketizeApiVersions( IReadOnlyList<ApiVersionMetadata> metadata, I
         }
     }
 
-    private void AppendDescriptions( ICollection<ApiVersionDescription> descriptions, IEnumerable<ApiVersion> versions, bool deprecated )
+    private void AppendDescriptions( List<ApiVersionDescription> descriptions, IEnumerable<ApiVersion> versions, bool deprecated )
     {
         foreach ( var version in versions )
         {

src/AspNetCore/WebApi/test/Asp.Versioning.Http.Tests/Routing/ApiVersionRouteConstraintTest.cs

@@ -163,11 +163,11 @@ private static HttpContext NewHttpContext()
         return httpContext.Object;
     }
 
-    private static IRouteBuilder CreateRouteBuilder( IServiceProvider services )
+    private static RouteBuilder CreateRouteBuilder( IServiceProvider services )
     {
         var app = new Mock<IApplicationBuilder>();
         app.SetupGet( a => a.ApplicationServices ).Returns( services );
-        return new RouteBuilder( app.Object ) { DefaultHandler = new PassThroughRouter() };
+        return new( app.Object ) { DefaultHandler = new PassThroughRouter() };
     }
 
     private static IUrlHelper NewUrlHelper( string controller, string action, string version )

src/AspNetCore/WebApi/test/Asp.Versioning.Mvc.ApiExplorer.Tests/TestActionDescriptorCollectionProvider.cs

@@ -41,7 +41,7 @@ private static ActionDescriptorCollection CreateActionDescriptors()
         return new( actions.ToArray(), 0 );
     }
 
-    private static void AddOrderActionDescriptors( ICollection<ActionDescriptor> actions )
+    private static void AddOrderActionDescriptors( List<ActionDescriptor> actions )
     {
         // api version 0.9 and 1.0
         actions.Add(
@@ -106,7 +106,7 @@ private static void AddOrderActionDescriptors( ICollection<ActionDescriptor> act
                 advertised: new ApiVersion[] { new( 4, 0 ) } ) );
     }
 
-    private static void AddPeopleActionDescriptors( ICollection<ActionDescriptor> actions )
+    private static void AddPeopleActionDescriptors( List<ActionDescriptor> actions )
     {
         // api version 0.9 and 1.0
         actions.Add(

src/AspNetCore/WebApi/test/Asp.Versioning.Mvc.Tests/ApplicationModels/ApiBehaviorSpecificationTest.cs

@@ -33,13 +33,13 @@ public void is_satisfied_by_should_return_expected_result( Type controllerType,
     private sealed class ApiBehaviorController : ControllerBase
     {
         [HttpGet]
-        public IActionResult Get() => Ok();
+        public OkResult Get() => Ok();
     }
 
     [Route( "/" )]
     private sealed class NonApiBehaviorController : Controller
     {
         [HttpGet]
-        public IActionResult Index() => View();
+        public ViewResult Index() => View();
     }
 }

src/AspNetCore/WebApi/test/Asp.Versioning.Mvc.Tests/ReportApiVersionsAttributeTest.cs

@@ -66,7 +66,7 @@ public async Task on_action_executing_should_not_add_headers_for_versionX2Dneutr
 
     private static ActionExecutingContext CreateContext(
         ApiVersionMetadata metadata,
-        ICollection<(Func<object, Task> Callback, object State)> onStartResponse )
+        List<(Func<object, Task> Callback, object State)> onStartResponse )
     {
         var headers = new HeaderDictionary();
         var response = new Mock<HttpResponse>();

src/Client/src/Asp.Versioning.Http.Client/net#.0/DependencyInjection/IHttpClientBuilderExtensions.cs

@@ -128,7 +128,7 @@ private static ApiVersionHandler NewApiVersionHandler(
         return new( writer, apiVersion, notification, parser );
     }
 
-    private static IApiNotification? BuildFallbackNotification(
+    private static ApiVersionHandlerLogger<ApiVersionHandler>? BuildFallbackNotification(
         IServiceProvider serviceProvider,
         IApiVersionParser? parser )
     {
@@ -142,9 +142,6 @@ private static ApiVersionHandler NewApiVersionHandler(
 
         var enumerable = serviceProvider.GetService<ApiVersionHeaderEnumerable>();
 
-        return new ApiVersionHandlerLogger<ApiVersionHandler>(
-            logger,
-            parser ?? ApiVersionParser.Default,
-            enumerable ?? new() );
+        return new( logger, parser ?? ApiVersionParser.Default, enumerable ?? new() );
     }
 }