Fix some build warnings. (#2021)

alexrp · web-flow · commit 81cfc1008b1d · 2024-04-07T14:33:11.000-05:00
diff --git a/.editorconfig b/.editorconfig
@@ -40,7 +40,7 @@ dotnet_diagnostic.RS0016.severity = error
 dotnet_diagnostic.RS0017.severity = error
 
 # we should care more about this one day
-dotnet_diagnostic.RS0041.severity = warn
+dotnet_diagnostic.RS0041.severity = warning
 
 # public api warnings silk.net doesn't care about
 dotnet_diagnostic.RS0026.severity = none  # Don't add multiple public overloads with optional parameters
diff --git a/build/nuke/Build.CodeSigning.cs b/build/nuke/Build.CodeSigning.cs
@@ -35,7 +35,7 @@ partial class Build
                 {
                     if (!CanCodeSign)
                     {
-                        ControlFlow.Fail("SignClient username and/or password not specified.");
+                        Assert.Fail("SignClient username and/or password not specified.");
                     }
 
                     var outputs = Enumerable.Empty<Output>();
diff --git a/build/nuke/Build.Core.cs b/build/nuke/Build.Core.cs
@@ -7,6 +7,7 @@
 using Nuke.Common;
 using Nuke.Common.Tooling;
 using Nuke.Common.Tools.DotNet;
+using Serilog;
 using static Nuke.Common.IO.FileSystemTasks;
 using static Nuke.Common.Tools.DotNet.DotNetTasks;
 using static Nuke.Common.Tooling.ProcessTasks;
@@ -57,7 +58,7 @@ partial class Build
                     }
                     else
                     {
-                        Logger.Warn("Skipping gradlew clean as the \"native\" feature-set has not been specified.");
+                        Log.Warning("Skipping gradlew clean as the \"native\" feature-set has not been specified.");
                     }
 
                     return outputs;
diff --git a/build/nuke/Build.Generation.cs b/build/nuke/Build.Generation.cs
@@ -11,6 +11,7 @@
 using Nuke.Common.Tools.DotNet;
 using Octokit;
 using Octokit.Internal;
+using Serilog;
 using static Nuke.Common.Tools.DotNet.DotNetTasks;
 using static Nuke.Common.Tools.Git.GitTasks;
 using static Nuke.Common.Tooling.ProcessTasks;
@@ -31,7 +32,7 @@ partial class Build
                     var project = OriginalSolution.GetProject("Silk.NET.BuildTools");
                     if (project == default)
                     {
-                        Logger.Error("Couldn't find BuildTools in the solution file.");
+                        Log.Error("Couldn't find BuildTools in the solution file.");
                         return;
                     }
 
@@ -52,14 +53,14 @@ partial class Build
                         {
                             DotNet($"sln \"{Path.GetFileName(OriginalSolution.FileName)}\" add \"{missedOut}\"");
                         }
-                        
+
                         PrUpdatedBindings();
                     }
                 }
             )
     );
-    
-    
+
+
     void PrUpdatedBindings()
     {
         var pushableToken = EnvironmentInfo.GetVariable<string>("PUSHABLE_GITHUB_TOKEN");
@@ -89,13 +90,13 @@ void PrUpdatedBindings()
             Git("reset --hard", RootDirectory);
             if (GitCurrentCommit(RootDirectory) != curCommit) // might get "nothing to commit", you never know...
             {
-                Logger.Info("Checking for existing branch...");
+                Log.Information("Checking for existing branch...");
                 var exists = StartProcess("git", $"checkout \"{newBranch}\"", RootDirectory)
                     .AssertWaitForExit()
                     .ExitCode == 0;
                 if (!exists)
                 {
-                    Logger.Info("None found, creating a new one...");
+                    Log.Information("None found, creating a new one...");
                     Git($"checkout -b \"{newBranch}\"");
                 }
 
@@ -108,7 +109,7 @@ void PrUpdatedBindings()
                         new ProductHeaderValue("Silk.NET-CI"),
                         new InMemoryCredentialStore(new Credentials(pushableToken))
                     );
-                    
+
                     var pr = github.PullRequest.Create
                             ("dotnet", "Silk.NET", new($"Regenerate bindings as of {DateTime.UtcNow:dd/MM/yyyy}", newBranch, curBranch))
                         .GetAwaiter()
diff --git a/build/nuke/Build.NuGet.cs b/build/nuke/Build.NuGet.cs
@@ -9,6 +9,7 @@
 using Nuke.Common;
 using Nuke.Common.Tooling;
 using Nuke.Common.Tools.DotNet;
+using Serilog;
 using static Nuke.Common.Tools.DotNet.DotNetTasks;
 
 partial class Build
@@ -44,7 +45,7 @@ async Task<IEnumerable<Output>> PushPackages()
             .Select(x => x.Select(v => v.Value).ToList())
             .ToList();
         var first = true;
-        Logger.Info($"Searching for packages in \"{RootDirectory / "build" / "output_packages"}\"...");
+        Log.Information($"Searching for packages in \"{RootDirectory / "build" / "output_packages"}\"...");
         foreach (var files in allFiles)
         {
             if (first)
@@ -64,7 +65,7 @@ async Task<IEnumerable<Output>> PushPackages()
                 {
                     if (NugetUsername is null || NugetPassword is null)
                     {
-                        ControlFlow.Fail
+                        Assert.Fail
                         (
                             "Both \"NugetUsername\" and \"NugetPassword\" must be specified if either are used."
                         );
diff --git a/build/nuke/Build.PublicApi.cs b/build/nuke/Build.PublicApi.cs
@@ -10,6 +10,7 @@
 using Nuke.Common.Tooling;
 using Octokit;
 using Octokit.Internal;
+using Serilog;
 using static Nuke.Common.Tools.Git.GitTasks;
 using static Nuke.Common.Tooling.ProcessTasks;
 using static Nuke.Common.Tools.DotNet.DotNetTasks;
@@ -133,10 +134,10 @@ string FormatCmd
                     // about adding dodgy MSBuild targets that could swipe it
                     var githubToken = EnvironmentInfo.GetVariable<string>("GITHUB_TOKEN");
                     EnvironmentInfo.SetVariable("GITHUB_TOKEN", string.Empty);
-                    
+
                     // run the format command
                     InheritedShell($"{cmd} --verify-no-changes").AssertZeroExitCode();
-                    
+
                     // add our github token back
                     EnvironmentInfo.SetVariable("GITHUB_TOKEN", githubToken);
                     await AddOrUpdatePrComment("public_api", "public_api_declared", true);
@@ -184,13 +185,13 @@ void MakePr()
             Git("reset --hard", RootDirectory);
             if (GitCurrentCommit(RootDirectory) != curCommit) // might get "nothing to commit", you never know...
             {
-                Logger.Info("Checking for existing branch...");
+                Log.Information("Checking for existing branch...");
                 var exists = StartProcess("git", $"checkout \"{newBranch}\"", RootDirectory)
                     .AssertWaitForExit()
                     .ExitCode == 0;
                 if (!exists)
                 {
-                    Logger.Info("None found, creating a new one...");
+                    Log.Information("None found, creating a new one...");
                     Git($"checkout -b \"{newBranch}\"");
                 }
 
diff --git a/build/nuke/Build.ReviewHelpers.cs b/build/nuke/Build.ReviewHelpers.cs
@@ -6,6 +6,7 @@
 using System.Linq;
 using Nuke.Common;
 using Nuke.Common.IO;
+using Serilog;
 
 partial class Build
 {
@@ -27,13 +28,13 @@ partial class Build
                 var missedOut = GetNewProjects();
                 if (missedOut.Any())
                 {
-                    Logger.Warn("Commands to add these for your convenience:");
+                    Log.Warning("Commands to add these for your convenience:");
                     foreach (var file in missedOut)
                     {
-                        Logger.Warn($"dotnet sln \"{Path.GetFileName(OriginalSolution.FileName)}\" add \"{file}\"");
+                        Log.Warning($"dotnet sln \"{Path.GetFileName(OriginalSolution.FileName)}\" add \"{file}\"");
                     }
 
-                    ControlFlow.Fail("Action required.");
+                    Assert.Fail("Action required.");
                 }
             }
         )
@@ -46,7 +47,7 @@ List<string> GetNewProjects()
             .Concat(RootDirectory.GlobFiles("**/*.csproj"))
             .Where(x => !x.ToString().Contains("submodules"))
             .ToArray();
-        Logger.Info($"Found {files.Length} csproj files in \"{RootDirectory}\"");
+        Log.Information($"Found {files.Length} csproj files in \"{RootDirectory}\"");
         foreach (var file in files)
         {
             var found = false;
@@ -61,7 +62,7 @@ List<string> GetNewProjects()
 
             if (!found && !AllowedExclusions.Contains(Path.GetFileNameWithoutExtension(file)))
             {
-                Logger.Error
+                Log.Error
                 (
                     "A project has not been included in the solution and will not be shipped! " +
                     $"\"{file}\" if this is acceptable please add the project name (excluding the path and " +
diff --git a/build/nuke/Build.SolutionGenerator.cs b/build/nuke/Build.SolutionGenerator.cs
@@ -12,6 +12,7 @@
 using Nuke.Common.IO;
 using Nuke.Common.ProjectModel;
 using Nuke.Common.Utilities;
+using Serilog;
 using static Nuke.Common.IO.FileSystemTasks;
 using static Nuke.Common.ProjectModel.ProjectModelTasks;
 
@@ -28,7 +29,7 @@ partial class Build
         "specified, but if you don't want to run a build just use \"nuke sln --projects ...\" to run a dummy target."
     )]
     readonly string[] Projects;
-    
+
     [Parameter("If specified, ignores any generated solution present and builds the entire project.", Name = "All")]
     readonly bool BuildAll;
 
@@ -42,7 +43,7 @@ void GenerateSolution()
     {
         if (Projects is not { Length: > 0 })
         {
-            Logger.Trace("Nothing to do for GenerateSolution.");
+            Log.Verbose("Nothing to do for GenerateSolution.");
             return;
         }
 
@@ -101,7 +102,7 @@ AbsolutePath Concat(AbsolutePath path, string next)
 
         // make a new Solution object to prevent us mutating the OriginalSolution
         var genSln = ParseSolution(OriginalSolution.Path);
-        
+
         // remove irrelevant projects
         foreach (var project in genSln.GetProjects("*"))
         {
@@ -112,8 +113,8 @@ AbsolutePath Concat(AbsolutePath path, string next)
         }
 
         genSln.SaveAs(RootDirectory / "Silk.NET.gen.sln");
-        Logger.Info($"Generated solution containing {genSln.AllProjects.Count} projects");
+        Log.Information($"Generated solution containing {genSln.AllProjects.Count} projects");
     }
-    
+
     Target Sln => CommonTarget();
 }
diff --git a/build/nuke/Build.Support.cs b/build/nuke/Build.Support.cs
@@ -19,6 +19,7 @@
 using Nuke.Common.Tools.DotNet;
 using Nuke.Common.Utilities;
 using Octokit;
+using Serilog;
 using static Nuke.Common.IO.FileSystemTasks;
 using static Nuke.Common.Tooling.ProcessTasks;
 using static Nuke.Common.Tools.DotNet.DotNetTasks;
@@ -147,27 +148,27 @@ async Task AddOrUpdatePrComment(string type, string file, bool editOnly = false,
         var githubToken = EnvironmentInfo.GetVariable<string>("GITHUB_TOKEN");
         if (string.IsNullOrWhiteSpace(githubToken))
         {
-            Logger.Info("GitHub token not found, skipping writing a comment.");
+            Log.Information("GitHub token not found, skipping writing a comment.");
             return;
         }
 
         var @ref = GitHubActions.Instance?.Ref;
         if (string.IsNullOrWhiteSpace(@ref))
         {
-            Logger.Info("Not running in GitHub Actions, skipping writing a comment.");
+            Log.Information("Not running in GitHub Actions, skipping writing a comment.");
             return;
         }
 
         var prMatch = PrRegex.Match(@ref);
         if (!prMatch.Success || prMatch.Groups.Count < 2)
         {
-            Logger.Info($"Couldn't match {@ref} to a PR, skipping writing a comment.");
+            Log.Information($"Couldn't match {@ref} to a PR, skipping writing a comment.");
             return;
         }
 
         if (!int.TryParse(prMatch.Groups[1].Value, out var pr))
         {
-            Logger.Info($"Couldn't parse {@prMatch.Groups[1].Value} as an int, skipping writing a comment.");
+            Log.Information($"Couldn't parse {@prMatch.Groups[1].Value} as an int, skipping writing a comment.");
             return;
         }
 
@@ -181,7 +182,7 @@ async Task AddOrUpdatePrComment(string type, string file, bool editOnly = false,
             .FirstOrDefault(x => x.Body.Contains($"`{type}`") && x.User.Name == "github-actions[bot]");
         if (existingComment is null && editOnly)
         {
-            Logger.Info("Edit only mode is on and no existing comment found, skipping writing a comment.");
+            Log.Information("Edit only mode is on and no existing comment found, skipping writing a comment.");
             return;
         }
 
@@ -198,12 +199,12 @@ async Task AddOrUpdatePrComment(string type, string file, bool editOnly = false,
 
         if (existingComment is not null)
         {
-            Logger.Info("Updated the comment on the PR.");
+            Log.Information("Updated the comment on the PR.");
             await github.Issue.Comment.Update("dotnet", "Silk.NET", existingComment.Id, commentText);
         }
         else
         {
-            Logger.Info("Added a comment to the PR.");
+            Log.Information("Added a comment to the PR.");
             await github.Issue.Comment.Create("dotnet", "Silk.NET", pr, commentText);
         }
     }
diff --git a/build/nuke/Native/Core.cs b/build/nuke/Native/Core.cs
@@ -17,6 +17,7 @@
 using Nuke.Common.Tools.Git;
 using Octokit;
 using Octokit.Internal;
+using Serilog;
 using static Nuke.Common.IO.CompressionTasks;
 using static Nuke.Common.IO.FileSystemTasks;
 using static Nuke.Common.IO.HttpTasks;
@@ -33,7 +34,7 @@ partial class Build {
     static string JobsArg => string.IsNullOrWhiteSpace(GitHubActions.Instance?.Job)
         ? $" -j{Jobs}"
         : string.Empty;
-    
+
     static int Jobs => string.IsNullOrWhiteSpace(GitHubActions.Instance?.Job)
         ? Environment.ProcessorCount - 1
         : 1;
@@ -90,13 +91,13 @@ public void PrUpdatedNativeBinary(string name, [CanBeNull] string glob = null)
             Git("reset --hard", RootDirectory);
             if (GitCurrentCommit(RootDirectory) != curCommit) // might get "nothing to commit", you never know...
             {
-                Logger.Info("Checking for existing branch...");
+                Log.Information("Checking for existing branch...");
                 var exists = StartProcess("git", $"checkout \"{newBranch}\"", RootDirectory)
                     .AssertWaitForExit()
                     .ExitCode == 0;
                 if (!exists)
                 {
-                    Logger.Info("None found, creating a new one...");
+                    Log.Information("None found, creating a new one...");
                     Git($"checkout -b \"{newBranch}\"");
                 }
 
@@ -118,4 +119,4 @@ public void PrUpdatedNativeBinary(string name, [CanBeNull] string glob = null)
             }
         }
     }
-}
+}
diff --git a/build/nuke/Native/SilkDroid.cs b/build/nuke/Native/SilkDroid.cs
@@ -17,6 +17,7 @@
 using Nuke.Common.Tools.Git;
 using Octokit;
 using Octokit.Internal;
+using Serilog;
 using static Nuke.Common.IO.CompressionTasks;
 using static Nuke.Common.IO.FileSystemTasks;
 using static Nuke.Common.IO.HttpTasks;
@@ -38,7 +39,7 @@ string AndroidHome
             var utils = RootDirectory / "build" / "utilities";
             DotNet($"build \"{utils / "android_probe.proj"}\" /t:GetAndroidJar");
             AndroidHomeValue = (AbsolutePath) File.ReadAllText(utils / "android.jar.gen.txt") / ".." / ".." / "..";
-            Logger.Info($"Android Home: {AndroidHomeValue}");
+            Log.Information($"Android Home: {AndroidHomeValue}");
             return AndroidHomeValue;
         }
     }
@@ -53,7 +54,7 @@ string AndroidHome
                 {
                     if (!Native)
                     {
-                        Logger.Warn("Skipping gradlew build as the --native parameter has not been specified.");
+                        Log.Warning("Skipping gradlew build as the --native parameter has not been specified.");
                         return Enumerable.Empty<Output>();
                     }
 
@@ -70,7 +71,7 @@ string AndroidHome
                     {
                         if (!Directory.Exists(from))
                         {
-                            ControlFlow.Fail
+                            Assert.Fail
                                 ($"\"{from}\" does not exist (did you forget to recursively clone the repo?)");
                         }
 
@@ -99,4 +100,4 @@ string AndroidHome
                 }
             )
     );
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ partial class Build`
`35`	`35`	`{`
`36`	`36`	`if (!CanCodeSign)`
`37`	`37`	`{`
`38`		`- ControlFlow.Fail("SignClient username and/or password not specified.");`
	`38`	`+ Assert.Fail("SignClient username and/or password not specified.");`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`var outputs = Enumerable.Empty<Output>();`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`using Nuke.Common;`
`8`	`8`	`using Nuke.Common.Tooling;`
`9`	`9`	`using Nuke.Common.Tools.DotNet;`
	`10`	`+using Serilog;`
`10`	`11`	`using static Nuke.Common.IO.FileSystemTasks;`
`11`	`12`	`using static Nuke.Common.Tools.DotNet.DotNetTasks;`
`12`	`13`	`using static Nuke.Common.Tooling.ProcessTasks;`
`@@ -57,7 +58,7 @@ partial class Build`
`57`	`58`	`}`
`58`	`59`	`else`
`59`	`60`	`{`
`60`		`- Logger.Warn("Skipping gradlew clean as the \"native\" feature-set has not been specified.");`
	`61`	`+ Log.Warning("Skipping gradlew clean as the \"native\" feature-set has not been specified.");`
`61`	`62`	`}`
`62`	`63`
`63`	`64`	`return outputs;`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`	`using Nuke.Common.Tools.DotNet;`
`12`	`12`	`using Octokit;`
`13`	`13`	`using Octokit.Internal;`
	`14`	`+using Serilog;`
`14`	`15`	`using static Nuke.Common.Tools.DotNet.DotNetTasks;`
`15`	`16`	`using static Nuke.Common.Tools.Git.GitTasks;`
`16`	`17`	`using static Nuke.Common.Tooling.ProcessTasks;`
`@@ -31,7 +32,7 @@ partial class Build`
`31`	`32`	`var project = OriginalSolution.GetProject("Silk.NET.BuildTools");`
`32`	`33`	`if (project == default)`
`33`	`34`	`{`
`34`		`- Logger.Error("Couldn't find BuildTools in the solution file.");`
	`35`	`+ Log.Error("Couldn't find BuildTools in the solution file.");`
`35`	`36`	`return;`
`36`	`37`	`}`
`37`	`38`
`@@ -52,14 +53,14 @@ partial class Build`
`52`	`53`	`{`
`53`	`54`	`DotNet($"sln \"{Path.GetFileName(OriginalSolution.FileName)}\" add \"{missedOut}\"");`
`54`	`55`	`}`
`55`		`-`
	`56`	`+`
`56`	`57`	`PrUpdatedBindings();`
`57`	`58`	`}`
`58`	`59`	`}`
`59`	`60`	`)`
`60`	`61`	`);`
`61`		`-`
`62`		`-`
	`62`	`+`
	`63`	`+`
`63`	`64`	`void PrUpdatedBindings()`
`64`	`65`	`{`
`65`	`66`	`var pushableToken = EnvironmentInfo.GetVariable<string>("PUSHABLE_GITHUB_TOKEN");`
`@@ -89,13 +90,13 @@ void PrUpdatedBindings()`
`89`	`90`	`Git("reset --hard", RootDirectory);`
`90`	`91`	`if (GitCurrentCommit(RootDirectory) != curCommit) // might get "nothing to commit", you never know...`
`91`	`92`	`{`
`92`		`- Logger.Info("Checking for existing branch...");`
	`93`	`+ Log.Information("Checking for existing branch...");`
`93`	`94`	`var exists = StartProcess("git", $"checkout \"{newBranch}\"", RootDirectory)`
`94`	`95`	`.AssertWaitForExit()`
`95`	`96`	`.ExitCode == 0;`
`96`	`97`	`if (!exists)`
`97`	`98`	`{`
`98`		`- Logger.Info("None found, creating a new one...");`
	`99`	`+ Log.Information("None found, creating a new one...");`
`99`	`100`	`Git($"checkout -b \"{newBranch}\"");`
`100`	`101`	`}`
`101`	`102`
`@@ -108,7 +109,7 @@ void PrUpdatedBindings()`
`108`	`109`	`new ProductHeaderValue("Silk.NET-CI"),`
`109`	`110`	`new InMemoryCredentialStore(new Credentials(pushableToken))`
`110`	`111`	`);`
`111`		`-`
	`112`	`+`
`112`	`113`	`var pr = github.PullRequest.Create`
`113`	`114`	`("dotnet", "Silk.NET", new($"Regenerate bindings as of {DateTime.UtcNow:dd/MM/yyyy}", newBranch, curBranch))`
`114`	`115`	`.GetAwaiter()`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`using Nuke.Common;`
`10`	`10`	`using Nuke.Common.Tooling;`
`11`	`11`	`using Nuke.Common.Tools.DotNet;`
	`12`	`+using Serilog;`
`12`	`13`	`using static Nuke.Common.Tools.DotNet.DotNetTasks;`
`13`	`14`
`14`	`15`	`partial class Build`
`@@ -44,7 +45,7 @@ async Task<IEnumerable<Output>> PushPackages()`
`44`	`45`	`.Select(x => x.Select(v => v.Value).ToList())`
`45`	`46`	`.ToList();`
`46`	`47`	`var first = true;`
`47`		`- Logger.Info($"Searching for packages in \"{RootDirectory / "build" / "output_packages"}\"...");`
	`48`	`+ Log.Information($"Searching for packages in \"{RootDirectory / "build" / "output_packages"}\"...");`
`48`	`49`	`foreach (var files in allFiles)`
`49`	`50`	`{`
`50`	`51`	`if (first)`
`@@ -64,7 +65,7 @@ async Task<IEnumerable<Output>> PushPackages()`
`64`	`65`	`{`
`65`	`66`	`if (NugetUsername is null \|\| NugetPassword is null)`
`66`	`67`	`{`
`67`		`- ControlFlow.Fail`
	`68`	`+ Assert.Fail`
`68`	`69`	`(`
`69`	`70`	`"Both \"NugetUsername\" and \"NugetPassword\" must be specified if either are used."`
`70`	`71`	`);`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,7 @@`
`6`	`6`	`using System.Linq;`
`7`	`7`	`using Nuke.Common;`
`8`	`8`	`using Nuke.Common.IO;`
	`9`	`+using Serilog;`
`9`	`10`
`10`	`11`	`partial class Build`
`11`	`12`	`{`
`@@ -27,13 +28,13 @@ partial class Build`
`27`	`28`	`var missedOut = GetNewProjects();`
`28`	`29`	`if (missedOut.Any())`
`29`	`30`	`{`
`30`		`- Logger.Warn("Commands to add these for your convenience:");`
	`31`	`+ Log.Warning("Commands to add these for your convenience:");`
`31`	`32`	`foreach (var file in missedOut)`
`32`	`33`	`{`
`33`		`- Logger.Warn($"dotnet sln \"{Path.GetFileName(OriginalSolution.FileName)}\" add \"{file}\"");`
	`34`	`+ Log.Warning($"dotnet sln \"{Path.GetFileName(OriginalSolution.FileName)}\" add \"{file}\"");`
`34`	`35`	`}`
`35`	`36`
`36`		`- ControlFlow.Fail("Action required.");`
	`37`	`+ Assert.Fail("Action required.");`
`37`	`38`	`}`
`38`	`39`	`}`
`39`	`40`	`)`
`@@ -46,7 +47,7 @@ List<string> GetNewProjects()`
`46`	`47`	`.Concat(RootDirectory.GlobFiles("*/.csproj"))`
`47`	`48`	`.Where(x => !x.ToString().Contains("submodules"))`
`48`	`49`	`.ToArray();`
`49`		`- Logger.Info($"Found {files.Length} csproj files in \"{RootDirectory}\"");`
	`50`	`+ Log.Information($"Found {files.Length} csproj files in \"{RootDirectory}\"");`
`50`	`51`	`foreach (var file in files)`
`51`	`52`	`{`
`52`	`53`	`var found = false;`
`@@ -61,7 +62,7 @@ List<string> GetNewProjects()`
`61`	`62`
`62`	`63`	`if (!found && !AllowedExclusions.Contains(Path.GetFileNameWithoutExtension(file)))`
`63`	`64`	`{`
`64`		`- Logger.Error`
	`65`	`+ Log.Error`
`65`	`66`	`(`
`66`	`67`	`"A project has not been included in the solution and will not be shipped! " +`
`67`	`68`	`$"\"{file}\" if this is acceptable please add the project name (excluding the path and " +`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`using Nuke.Common.IO;`
`13`	`13`	`using Nuke.Common.ProjectModel;`
`14`	`14`	`using Nuke.Common.Utilities;`
	`15`	`+using Serilog;`
`15`	`16`	`using static Nuke.Common.IO.FileSystemTasks;`
`16`	`17`	`using static Nuke.Common.ProjectModel.ProjectModelTasks;`
`17`	`18`
`@@ -28,7 +29,7 @@ partial class Build`
`28`	`29`	`"specified, but if you don't want to run a build just use \"nuke sln --projects ...\" to run a dummy target."`
`29`	`30`	`)]`
`30`	`31`	`readonly string[] Projects;`
`31`		`-`
	`32`	`+`
`32`	`33`	`[Parameter("If specified, ignores any generated solution present and builds the entire project.", Name = "All")]`
`33`	`34`	`readonly bool BuildAll;`
`34`	`35`
`@@ -42,7 +43,7 @@ void GenerateSolution()`
`42`	`43`	`{`
`43`	`44`	`if (Projects is not { Length: > 0 })`
`44`	`45`	`{`
`45`		`- Logger.Trace("Nothing to do for GenerateSolution.");`
	`46`	`+ Log.Verbose("Nothing to do for GenerateSolution.");`
`46`	`47`	`return;`
`47`	`48`	`}`
`48`	`49`
`@@ -101,7 +102,7 @@ AbsolutePath Concat(AbsolutePath path, string next)`
`101`	`102`
`102`	`103`	`// make a new Solution object to prevent us mutating the OriginalSolution`
`103`	`104`	`var genSln = ParseSolution(OriginalSolution.Path);`
`104`		`-`
	`105`	`+`
`105`	`106`	`// remove irrelevant projects`
`106`	`107`	`foreach (var project in genSln.GetProjects("*"))`
`107`	`108`	`{`
`@@ -112,8 +113,8 @@ AbsolutePath Concat(AbsolutePath path, string next)`
`112`	`113`	`}`
`113`	`114`
`114`	`115`	`genSln.SaveAs(RootDirectory / "Silk.NET.gen.sln");`
`115`		`- Logger.Info($"Generated solution containing {genSln.AllProjects.Count} projects");`
	`116`	`+ Log.Information($"Generated solution containing {genSln.AllProjects.Count} projects");`
`116`	`117`	`}`
`117`		`-`
	`118`	`+`
`118`	`119`	`Target Sln => CommonTarget();`
`119`	`120`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`	`using Nuke.Common.Tools.DotNet;`
`20`	`20`	`using Nuke.Common.Utilities;`
`21`	`21`	`using Octokit;`
	`22`	`+using Serilog;`
`22`	`23`	`using static Nuke.Common.IO.FileSystemTasks;`
`23`	`24`	`using static Nuke.Common.Tooling.ProcessTasks;`
`24`	`25`	`using static Nuke.Common.Tools.DotNet.DotNetTasks;`
`@@ -147,27 +148,27 @@ async Task AddOrUpdatePrComment(string type, string file, bool editOnly = false,`
`147`	`148`	`var githubToken = EnvironmentInfo.GetVariable<string>("GITHUB_TOKEN");`
`148`	`149`	`if (string.IsNullOrWhiteSpace(githubToken))`
`149`	`150`	`{`
`150`		`- Logger.Info("GitHub token not found, skipping writing a comment.");`
	`151`	`+ Log.Information("GitHub token not found, skipping writing a comment.");`
`151`	`152`	`return;`
`152`	`153`	`}`
`153`	`154`
`154`	`155`	`var @ref = GitHubActions.Instance?.Ref;`
`155`	`156`	`if (string.IsNullOrWhiteSpace(@ref))`
`156`	`157`	`{`
`157`		`- Logger.Info("Not running in GitHub Actions, skipping writing a comment.");`
	`158`	`+ Log.Information("Not running in GitHub Actions, skipping writing a comment.");`
`158`	`159`	`return;`
`159`	`160`	`}`
`160`	`161`
`161`	`162`	`var prMatch = PrRegex.Match(@ref);`
`162`	`163`	`if (!prMatch.Success \|\| prMatch.Groups.Count < 2)`
`163`	`164`	`{`
`164`		`- Logger.Info($"Couldn't match {@ref} to a PR, skipping writing a comment.");`
	`165`	`+ Log.Information($"Couldn't match {@ref} to a PR, skipping writing a comment.");`
`165`	`166`	`return;`
`166`	`167`	`}`
`167`	`168`
`168`	`169`	`if (!int.TryParse(prMatch.Groups[1].Value, out var pr))`
`169`	`170`	`{`
`170`		`- Logger.Info($"Couldn't parse {@prMatch.Groups[1].Value} as an int, skipping writing a comment.");`
	`171`	`+ Log.Information($"Couldn't parse {@prMatch.Groups[1].Value} as an int, skipping writing a comment.");`
`171`	`172`	`return;`
`172`	`173`	`}`
`173`	`174`
`@@ -181,7 +182,7 @@ async Task AddOrUpdatePrComment(string type, string file, bool editOnly = false,`
`181`	`182`	.FirstOrDefault(x => x.Body.Contains($"`{type}`") && x.User.Name == "github-actions[bot]");
`182`	`183`	`if (existingComment is null && editOnly)`
`183`	`184`	`{`
`184`		`- Logger.Info("Edit only mode is on and no existing comment found, skipping writing a comment.");`
	`185`	`+ Log.Information("Edit only mode is on and no existing comment found, skipping writing a comment.");`
`185`	`186`	`return;`
`186`	`187`	`}`
`187`	`188`
`@@ -198,12 +199,12 @@ async Task AddOrUpdatePrComment(string type, string file, bool editOnly = false,`
`198`	`199`
`199`	`200`	`if (existingComment is not null)`
`200`	`201`	`{`
`201`		`- Logger.Info("Updated the comment on the PR.");`
	`202`	`+ Log.Information("Updated the comment on the PR.");`
`202`	`203`	`await github.Issue.Comment.Update("dotnet", "Silk.NET", existingComment.Id, commentText);`
`203`	`204`	`}`
`204`	`205`	`else`
`205`	`206`	`{`
`206`		`- Logger.Info("Added a comment to the PR.");`
	`207`	`+ Log.Information("Added a comment to the PR.");`
`207`	`208`	`await github.Issue.Comment.Create("dotnet", "Silk.NET", pr, commentText);`
`208`	`209`	`}`
`209`	`210`	`}`