use the new, strong-name signed Capstone.NET (#2212)

* use the new, strong-name signed Capstone.NET

* handle edge case in the processes communication

* disable long running tests on AppVeyor to hopefuly avoid timeouts

Author: adamsitnik

src/BenchmarkDotNet.Disassembler.x64/DataContracts.cs

@@ -36,7 +36,7 @@ public class IntelAsm : Asm
 
     public class Arm64Asm : Asm
     {
-#if !CLRMDV1
+#if !CLRMDV1 // don't include it in ClrMD V1 disassembler that supports only x86 and x64
         public Gee.External.Capstone.Arm64.Arm64Instruction Instruction { get; set; }
 #endif
     }
@@ -52,9 +52,6 @@ public class Map
         [XmlArrayItem(nameof(SourceCode), typeof(SourceCode))]
         [XmlArrayItem(nameof(Sharp), typeof(Sharp))]
         [XmlArrayItem(nameof(IntelAsm), typeof(IntelAsm))]
-#if NET6_0_OR_GREATER // we can replace it with !CLRMDV1 when https://github.com/9ee1/Capstone.NET/issues/36 is solved
-        [XmlArrayItem(nameof(Arm64Asm), typeof(Arm64Asm))]
-#endif
         public SourceCode[] SourceCodes { get; set; }
     }
 

src/BenchmarkDotNet/BenchmarkDotNet.csproj

@@ -4,7 +4,7 @@
     <AssemblyTitle>BenchmarkDotNet</AssemblyTitle>
     <TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-    <NoWarn>$(NoWarn);1701;1702;1705;1591;3005;NU1702;CS3001;CS3003;CS8002</NoWarn>
+    <NoWarn>$(NoWarn);1701;1702;1705;1591;3005;NU1702;CS3001;CS3003</NoWarn>
     <AssemblyName>BenchmarkDotNet</AssemblyName>
     <PackageId>BenchmarkDotNet</PackageId>
     <RootNamespace>BenchmarkDotNet</RootNamespace>
@@ -17,7 +17,7 @@
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="CommandLineParser" Version="2.4.3" />
-    <PackageReference Include="Gee.External.Capstone" Version="2.2.0" />
+    <PackageReference Include="Gee.External.Capstone" Version="2.3.0" />
     <PackageReference Include="Iced" Version="1.17.0" />
     <PackageReference Include="Microsoft.Diagnostics.Runtime" Version="2.2.332302" />
     <PackageReference Include="Perfolizer" Version="0.2.1" />

src/BenchmarkDotNet/Engines/AnonymousPipesHost.cs

@@ -51,8 +51,11 @@ public void SendSignal(HostSignal hostSignal)
 
             // read the response from Parent process, make the communication blocking
             string acknowledgment = inReader.ReadLine();
-            if (acknowledgment != Engine.Signals.Acknowledgment)
+            if (acknowledgment != Engine.Signals.Acknowledgment
+                && !(acknowledgment is null && hostSignal == HostSignal.AfterAll)) // an early EOF, but still valid
+            {
                 throw new NotSupportedException($"Unknown Acknowledgment: {acknowledgment}");
+            }
         }
 
         public void SendError(string message) => outWriter.WriteLine($"{ValidationErrorReporter.ConsoleErrorPrefix} {message}");

tests/BenchmarkDotNet.IntegrationTests/CustomBuildConfigurationTests.cs

@@ -18,6 +18,9 @@ public CustomBuildConfigurationTests(ITestOutputHelper output) : base(output)
         [Fact]
         public void UserCanSpecifyCustomBuildConfiguration()
         {
+            if (ContinuousIntegration.IsAppVeyorOnWindows())
+                return; // timeouts
+
             var jobWithCustomConfiguration = Job.Dry.WithCustomBuildConfiguration("CUSTOM");
 
             var config = CreateSimpleConfig(job: jobWithCustomConfiguration);

tests/BenchmarkDotNet.IntegrationTests/MonoTests.cs

@@ -12,6 +12,9 @@ public class MonoTests : BenchmarkTestExecutor
         [FactDotNetCoreOnly("UseMonoRuntime option is available in .NET Core only starting from .NET 6")]
         public void Mono70IsSupported()
         {
+            if (ContinuousIntegration.IsAppVeyorOnWindows())
+                return; // timeouts
+
             var config = ManualConfig.CreateEmpty().AddJob(Job.Dry.WithRuntime(MonoRuntime.Mono70));
             CanExecute<MonoBenchmark>(config);
         }

tests/BenchmarkDotNet.IntegrationTests/ThreadingDiagnoserTests.cs

@@ -32,7 +32,8 @@ public static IEnumerable<object[]> GetToolchains()
             yield return new object[] { Job.Default.GetToolchain() };
 
             if (!ContinuousIntegration.IsGitHubActionsOnWindows() // no native dependencies
-                && !RuntimeInformation.IsMacOSX()) // currently not supported
+                && !RuntimeInformation.IsMacOSX() // currently not supported
+                && !ContinuousIntegration.IsAppVeyorOnWindows()) // timeouts
             {
                 yield return new object[]{ NativeAotToolchain.CreateBuilder()
                     .UseNuGet("7.0.0", "https://api.nuget.org/v3/index.json")