Fix optimization of action methods for coreclr (#1935)

AndyAyersMS · web-flow · commit b78ec96631c5 · 2022-03-11T17:30:14.000+01:00
diff --git a/src/BenchmarkDotNet/Templates/BenchmarkType.txt b/src/BenchmarkDotNet/Templates/BenchmarkType.txt
@@ -113,6 +113,9 @@
 
         private BenchmarkDotNet.Engines.Consumer consumer = new BenchmarkDotNet.Engines.Consumer();
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -122,6 +125,9 @@
             }
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -131,6 +137,9 @@
             }
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -140,6 +149,9 @@
             }
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -163,6 +175,9 @@
 
 #elif RETURNS_NON_CONSUMABLE_STRUCT_$ID$
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -174,6 +189,9 @@
             BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(result);
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -185,6 +203,9 @@
             BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(result);
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -196,6 +217,9 @@
             NonGenericKeepAliveWithoutBoxing(result);
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -226,6 +250,9 @@
 
 #elif RETURNS_BYREF_$ID$
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -237,6 +264,9 @@
             BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(value);
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -250,6 +280,9 @@
 
         private $WorkloadMethodReturnType$ workloadDefaultValueHolder = default($WorkloadMethodReturnType$);
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -260,7 +293,10 @@
             }
             BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(ref alias);
         }
-        
+
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -285,6 +321,9 @@
         }
 #elif RETURNS_BYREF_READONLY_$ID$
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -296,6 +335,9 @@
             BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(value);
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -309,6 +351,9 @@
 
         private $WorkloadMethodReturnType$ workloadDefaultValueHolder = default($WorkloadMethodReturnType$);
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -319,7 +364,10 @@
             }
             BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxingReadonly(alias);
         }
-        
+
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -344,6 +392,9 @@
         }
 #elif RETURNS_VOID_$ID$
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -353,6 +404,9 @@
             }
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void OverheadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -362,6 +416,9 @@
             }
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$
@@ -371,6 +428,9 @@
             }
         }
 
+#if NETCOREAPP3_0_OR_GREATER
+        [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]
+#endif
         private void WorkloadActionNoUnroll(System.Int64 invokeCount)
         {
             $LoadArguments$

Original file line number	Diff line number	Diff line change
`@@ -113,6 +113,9 @@`
`113`	`113`
`114`	`114`	`private BenchmarkDotNet.Engines.Consumer consumer = new BenchmarkDotNet.Engines.Consumer();`
`115`	`115`
	`116`	`+#if NETCOREAPP3_0_OR_GREATER`
	`117`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`118`	`+#endif`
`116`	`119`	`private void OverheadActionUnroll(System.Int64 invokeCount)`
`117`	`120`	`{`
`118`	`121`	$LoadArguments$
`@@ -122,6 +125,9 @@`
`122`	`125`	`}`
`123`	`126`	`}`
`124`	`127`
	`128`	`+#if NETCOREAPP3_0_OR_GREATER`
	`129`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`130`	`+#endif`
`125`	`131`	`private void OverheadActionNoUnroll(System.Int64 invokeCount)`
`126`	`132`	`{`
`127`	`133`	$LoadArguments$
`@@ -131,6 +137,9 @@`
`131`	`137`	`}`
`132`	`138`	`}`
`133`	`139`
	`140`	`+#if NETCOREAPP3_0_OR_GREATER`
	`141`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`142`	`+#endif`
`134`	`143`	`private void WorkloadActionUnroll(System.Int64 invokeCount)`
`135`	`144`	`{`
`136`	`145`	$LoadArguments$
`@@ -140,6 +149,9 @@`
`140`	`149`	`}`
`141`	`150`	`}`
`142`	`151`
	`152`	`+#if NETCOREAPP3_0_OR_GREATER`
	`153`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`154`	`+#endif`
`143`	`155`	`private void WorkloadActionNoUnroll(System.Int64 invokeCount)`
`144`	`156`	`{`
`145`	`157`	$LoadArguments$
`@@ -163,6 +175,9 @@`
`163`	`175`
`164`	`176`	`#elif RETURNS_NON_CONSUMABLE_STRUCT_$ID$`
`165`	`177`
	`178`	`+#if NETCOREAPP3_0_OR_GREATER`
	`179`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`180`	`+#endif`
`166`	`181`	`private void OverheadActionUnroll(System.Int64 invokeCount)`
`167`	`182`	`{`
`168`	`183`	$LoadArguments$
`@@ -174,6 +189,9 @@`
`174`	`189`	`BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(result);`
`175`	`190`	`}`
`176`	`191`
	`192`	`+#if NETCOREAPP3_0_OR_GREATER`
	`193`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`194`	`+#endif`
`177`	`195`	`private void OverheadActionNoUnroll(System.Int64 invokeCount)`
`178`	`196`	`{`
`179`	`197`	$LoadArguments$
`@@ -185,6 +203,9 @@`
`185`	`203`	`BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(result);`
`186`	`204`	`}`
`187`	`205`
	`206`	`+#if NETCOREAPP3_0_OR_GREATER`
	`207`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`208`	`+#endif`
`188`	`209`	`private void WorkloadActionUnroll(System.Int64 invokeCount)`
`189`	`210`	`{`
`190`	`211`	$LoadArguments$
`@@ -196,6 +217,9 @@`
`196`	`217`	`NonGenericKeepAliveWithoutBoxing(result);`
`197`	`218`	`}`
`198`	`219`
	`220`	`+#if NETCOREAPP3_0_OR_GREATER`
	`221`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`222`	`+#endif`
`199`	`223`	`private void WorkloadActionNoUnroll(System.Int64 invokeCount)`
`200`	`224`	`{`
`201`	`225`	$LoadArguments$
`@@ -226,6 +250,9 @@`
`226`	`250`
`227`	`251`	`#elif RETURNS_BYREF_$ID$`
`228`	`252`
	`253`	`+#if NETCOREAPP3_0_OR_GREATER`
	`254`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`255`	`+#endif`
`229`	`256`	`private void OverheadActionUnroll(System.Int64 invokeCount)`
`230`	`257`	`{`
`231`	`258`	$LoadArguments$
`@@ -237,6 +264,9 @@`
`237`	`264`	`BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(value);`
`238`	`265`	`}`
`239`	`266`
	`267`	`+#if NETCOREAPP3_0_OR_GREATER`
	`268`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`269`	`+#endif`
`240`	`270`	`private void OverheadActionNoUnroll(System.Int64 invokeCount)`
`241`	`271`	`{`
`242`	`272`	$LoadArguments$
`@@ -250,6 +280,9 @@`
`250`	`280`
`251`	`281`	`private $WorkloadMethodReturnType$ workloadDefaultValueHolder = default($WorkloadMethodReturnType$);`
`252`	`282`
	`283`	`+#if NETCOREAPP3_0_OR_GREATER`
	`284`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`285`	`+#endif`
`253`	`286`	`private void WorkloadActionUnroll(System.Int64 invokeCount)`
`254`	`287`	`{`
`255`	`288`	$LoadArguments$
`@@ -260,7 +293,10 @@`
`260`	`293`	`}`
`261`	`294`	`BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(ref alias);`
`262`	`295`	`}`
`263`		`-`
	`296`	`+`
	`297`	`+#if NETCOREAPP3_0_OR_GREATER`
	`298`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`299`	`+#endif`
`264`	`300`	`private void WorkloadActionNoUnroll(System.Int64 invokeCount)`
`265`	`301`	`{`
`266`	`302`	$LoadArguments$
`@@ -285,6 +321,9 @@`
`285`	`321`	`}`
`286`	`322`	`#elif RETURNS_BYREF_READONLY_$ID$`
`287`	`323`
	`324`	`+#if NETCOREAPP3_0_OR_GREATER`
	`325`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`326`	`+#endif`
`288`	`327`	`private void OverheadActionUnroll(System.Int64 invokeCount)`
`289`	`328`	`{`
`290`	`329`	$LoadArguments$
`@@ -296,6 +335,9 @@`
`296`	`335`	`BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxing(value);`
`297`	`336`	`}`
`298`	`337`
	`338`	`+#if NETCOREAPP3_0_OR_GREATER`
	`339`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`340`	`+#endif`
`299`	`341`	`private void OverheadActionNoUnroll(System.Int64 invokeCount)`
`300`	`342`	`{`
`301`	`343`	$LoadArguments$
`@@ -309,6 +351,9 @@`
`309`	`351`
`310`	`352`	`private $WorkloadMethodReturnType$ workloadDefaultValueHolder = default($WorkloadMethodReturnType$);`
`311`	`353`
	`354`	`+#if NETCOREAPP3_0_OR_GREATER`
	`355`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`356`	`+#endif`
`312`	`357`	`private void WorkloadActionUnroll(System.Int64 invokeCount)`
`313`	`358`	`{`
`314`	`359`	$LoadArguments$
`@@ -319,7 +364,10 @@`
`319`	`364`	`}`
`320`	`365`	`BenchmarkDotNet.Engines.DeadCodeEliminationHelper.KeepAliveWithoutBoxingReadonly(alias);`
`321`	`366`	`}`
`322`		`-`
	`367`	`+`
	`368`	`+#if NETCOREAPP3_0_OR_GREATER`
	`369`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`370`	`+#endif`
`323`	`371`	`private void WorkloadActionNoUnroll(System.Int64 invokeCount)`
`324`	`372`	`{`
`325`	`373`	$LoadArguments$
`@@ -344,6 +392,9 @@`
`344`	`392`	`}`
`345`	`393`	`#elif RETURNS_VOID_$ID$`
`346`	`394`
	`395`	`+#if NETCOREAPP3_0_OR_GREATER`
	`396`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`397`	`+#endif`
`347`	`398`	`private void OverheadActionUnroll(System.Int64 invokeCount)`
`348`	`399`	`{`
`349`	`400`	$LoadArguments$
`@@ -353,6 +404,9 @@`
`353`	`404`	`}`
`354`	`405`	`}`
`355`	`406`
	`407`	`+#if NETCOREAPP3_0_OR_GREATER`
	`408`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`409`	`+#endif`
`356`	`410`	`private void OverheadActionNoUnroll(System.Int64 invokeCount)`
`357`	`411`	`{`
`358`	`412`	$LoadArguments$
`@@ -362,6 +416,9 @@`
`362`	`416`	`}`
`363`	`417`	`}`
`364`	`418`
	`419`	`+#if NETCOREAPP3_0_OR_GREATER`
	`420`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`421`	`+#endif`
`365`	`422`	`private void WorkloadActionUnroll(System.Int64 invokeCount)`
`366`	`423`	`{`
`367`	`424`	$LoadArguments$
`@@ -371,6 +428,9 @@`
`371`	`428`	`}`
`372`	`429`	`}`
`373`	`430`
	`431`	`+#if NETCOREAPP3_0_OR_GREATER`
	`432`	`+ [System.Runtime.CompilerServices.MethodImpl(System.Runtime.CompilerServices.MethodImplOptions.AggressiveOptimization)]`
	`433`	`+#endif`
`374`	`434`	`private void WorkloadActionNoUnroll(System.Int64 invokeCount)`
`375`	`435`	`{`
`376`	`436`	$LoadArguments$