Adjust wording of "ClassWithGenericTypeArgumentsAttributeMustBeNonAbstract" diagnostic and move trigger location to the attribute level

Author: silkfire

src/BenchmarkDotNet.Analyzers/BenchmarkDotNetAnalyzerResources.Designer.cs

@@ -142,7 +142,7 @@
     <value>Benchmark class '{0}' cannot be static</value>
   </data>
   <data name="General_BenchmarkClass_ClassWithGenericTypeArgumentsAttributeMustBeNonAbstract_MessageFormat" xml:space="preserve">
-    <value>Benchmark class '{0}' cannot be abstract</value>
+    <value>Attribute [GenericTypeArguments] can only be applied to a non-abstract class</value>
   </data>
   <data name="BenchmarkRunner_Run_GenericTypeArgumentClassMustBeAnnotatedWithAGenericTypeArgumentsAttribute_MessageFormat" xml:space="preserve">
     <value>Referenced generic benchmark class '{0}' has no [GenericTypeArguments] attribute(s)</value>

src/BenchmarkDotNet.Analyzers/BenchmarkDotNetAnalyzerResources.resx

@@ -140,13 +140,13 @@ private static void AnalyzeClassDeclaration(SyntaxNodeAnalysisContext context)
             var genericTypeArgumentsAttributes = AnalyzerHelper.GetAttributes("BenchmarkDotNet.Attributes.GenericTypeArgumentsAttribute", context.Compilation, classDeclarationSyntax.AttributeLists, context.SemanticModel);
             if (genericTypeArgumentsAttributes.Length > 0 )
             {
-                if (classAbstractModifier.HasValue)
-                {
-                    context.ReportDiagnostic(Diagnostic.Create(ClassWithGenericTypeArgumentsAttributeMustBeNonAbstractRule, classAbstractModifier.Value.GetLocation(), classDeclarationSyntax.Identifier.ToString()));
-                }
-
                 foreach (var genericTypeArgumentsAttribute in genericTypeArgumentsAttributes)
                 {
+                    if (classAbstractModifier.HasValue)
+                    {
+                        context.ReportDiagnostic(Diagnostic.Create(ClassWithGenericTypeArgumentsAttributeMustBeNonAbstractRule, genericTypeArgumentsAttribute.GetLocation()));
+                    }
+
                     if (classDeclarationSyntax.TypeParameterList == null || classDeclarationSyntax.TypeParameterList.Parameters.Count == 0)
                     {
                         context.ReportDiagnostic(Diagnostic.Create(ClassWithGenericTypeArgumentsAttributeMustBeGenericRule, genericTypeArgumentsAttribute.GetLocation()));

src/BenchmarkDotNet.Analyzers/General/BenchmarkClassAnalyzer.cs

@@ -48,13 +48,13 @@ public async Task Abstract_class_annotated_with_at_least_one_generictypeargument
             {
                 const string benchmarkClassName = "BenchmarkClass";
 
-                var genericTypeArgumentsAttributeUsages = Enumerable.Repeat("[GenericTypeArguments(typeof(int))]", genericTypeArgumentsAttributeUsageCount);
+                var genericTypeArgumentsAttributeUsages = Enumerable.Repeat("[{{|#{0}:GenericTypeArguments(typeof(int))|}}]", genericTypeArgumentsAttributeUsageCount).Select((a, i) => string.Format(a, i));
 
                 var testCode = /* lang=c#-test */ $$"""
                                                     using BenchmarkDotNet.Attributes;
 
                                                     {{string.Join("\n", genericTypeArgumentsAttributeUsages)}}
-                                                    public {|#0:abstract|} class {{benchmarkClassName}}<TParameter>
+                                                    public abstract class {{benchmarkClassName}}<TParameter>
                                                     {
                                                         {{benchmarkAttributeUsage}}
                                                         public void BenchmarkMethod()
@@ -65,7 +65,11 @@ public void BenchmarkMethod()
                                                     """;
 
                 TestCode = testCode;
-                AddDefaultExpectedDiagnostic(benchmarkClassName);
+
+                for (var i = 0; i < genericTypeArgumentsAttributeUsageCount; i++)
+                {
+                    AddExpectedDiagnostic(i);
+                }
 
                 await RunAsync();
             }