Removed a skip (it should no longer be flaky).

timcassell · timcassell · commit 9476e9b477a3 · 2024-04-23T22:37:58.000-04:00
diff --git a/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs b/tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs
@@ -186,11 +186,6 @@ public class NonAllocatingAsynchronousBenchmarks
         [Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
         public void AwaitingTasksShouldNotInterfereAllocationResults(IToolchain toolchain)
         {
-            if (toolchain.IsInProcess)
-            {
-                return; // it's flaky: https://github.com/dotnet/BenchmarkDotNet/issues/1925
-            }
-
             AssertAllocations(toolchain, typeof(NonAllocatingAsynchronousBenchmarks), new Dictionary<string, long>
             {
                 { nameof(NonAllocatingAsynchronousBenchmarks.CompletedTask), 0 },

Original file line number	Diff line number	Diff line change
`@@ -186,11 +186,6 @@ public class NonAllocatingAsynchronousBenchmarks`
`186`	`186`	`[Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]`
`187`	`187`	`public void AwaitingTasksShouldNotInterfereAllocationResults(IToolchain toolchain)`
`188`	`188`	`{`
`189`		`- if (toolchain.IsInProcess)`
`190`		`- {`
`191`		`- return; // it's flaky: https://github.com/dotnet/BenchmarkDotNet/issues/1925`
`192`		`- }`
`193`		`-`
`194`	`189`	`AssertAllocations(toolchain, typeof(NonAllocatingAsynchronousBenchmarks), new Dictionary<string, long>`
`195`	`190`	`{`
`196`	`191`	`{ nameof(NonAllocatingAsynchronousBenchmarks.CompletedTask), 0 },`