Rework environment-specific custom xUnit attributes

Author: AndreyAkinshin

tests/BenchmarkDotNet.IntegrationTests/AllSetupAndCleanupTest.cs

@@ -234,7 +234,7 @@ public class AllSetupAndCleanupAttributeBenchmarksAsyncValueTaskSetup
             public void Benchmark() => Console.WriteLine(BenchmarkCalled);
         }
 
-        [FactNotGitHubActionsWindows]
+        [FactEnvSpecific(EnvRequirement.NonWindows)]
         public void AllSetupAndCleanupMethodRunsAsyncGenericValueTaskSetupTest()
         {
             var miniJob = Job.Default.WithStrategy(RunStrategy.Monitoring).WithWarmupCount(2).WithIterationCount(3).WithInvocationCount(1).WithUnrollFactor(1).WithId("MiniJob");

tests/BenchmarkDotNet.IntegrationTests/ArgumentsTests.cs

@@ -318,8 +318,9 @@ public void AcceptsSpan(Span<int> span)
             }
         }
 
-        [TheoryNetCoreOnly("the implicit cast operator is available only in .NET Core 2.1+ (See https://github.com/dotnet/corefx/issues/30121 for more)"),
-         MemberData(nameof(GetToolchains))]
+        [TheoryEnvSpecific("The implicit cast operator is available only in .NET Core 2.1+ (See https://github.com/dotnet/corefx/issues/30121 for more)",
+            EnvRequirement.DotNetCoreOnly)]
+        [MemberData(nameof(GetToolchains))]
         public void StringCanBePassedToBenchmarkAsReadOnlySpan(IToolchain toolchain) => CanExecute<WithStringToReadOnlySpan>(toolchain);
 
         public class WithStringToReadOnlySpan

tests/BenchmarkDotNet.IntegrationTests/BenchmarkSwitcherTest.cs

@@ -25,7 +25,9 @@ public class BenchmarkSwitcherTest
 
         public BenchmarkSwitcherTest(ITestOutputHelper output) => Output = output;
 
-        [FactDotNetCoreOnly("When CommandLineParser wants to display help, it tries to get the Title of the Entry Assembly which is an xunit runner, which has no Title and fails..")]
+        [FactEnvSpecific(
+            "When CommandLineParser wants to display help, it tries to get the Title of the Entry Assembly which is an xunit runner, which has no Title and fails..",
+            EnvRequirement.DotNetCoreOnly)]
         public void WhenInvalidCommandLineArgumentIsPassedAnErrorMessageIsDisplayedAndNoBenchmarksAreExecuted()
         {
             var logger = new OutputLogger(Output);
@@ -332,7 +334,7 @@ public void WhenUserCreatesStaticBenchmarkMethodWeDisplayAnError_FromAssembly()
             Assert.Contains("static", logger.GetLog());
         }
 
-        [FactDotNetCoreOnly("For some reason this test is flaky on Full Framework")]
+        [FactEnvSpecific("For some reason this test is flaky on Full Framework", EnvRequirement.DotNetCoreOnly)]
         public void WhenUserAddTheResumeAttributeAndRunTheBenchmarks()
         {
             var logger = new OutputLogger(Output);

tests/BenchmarkDotNet.IntegrationTests/ExporterIOTests.cs

@@ -42,7 +42,7 @@ public void ExporterWritesToFile()
             }
         }
 
-        [FactWindowsOnly("On Unix, it's possible to write to an opened file")]
+        [FactEnvSpecific("On Unix, it's possible to write to an opened file", EnvRequirement.WindowsOnly)]
         public void ExporterWorksWhenFileIsLocked()
         {
             string resultsDirectoryPath = Path.GetTempPath();

tests/BenchmarkDotNet.IntegrationTests/ExtraAttributesForEntryMethodTests.cs

@@ -11,7 +11,7 @@ public ExtraAttributesForEntryMethodTests(ITestOutputHelper output) : base(outpu
         {
         }
 
-        [FactClassicDotNetOnly("STAThread attribute is not respected in netcoreapp https://github.com/dotnet/coreclr/issues/13688")]
+        [FactEnvSpecific("STAThread attribute is not respected in netcoreapp https://github.com/dotnet/coreclr/issues/13688", EnvRequirement.FullFrameworkOnly)]
         public void UserCanMarkBenchmarkAsRequiringSTA() => CanExecute<RequiresSTA>();
 
         public class RequiresSTA

tests/BenchmarkDotNet.IntegrationTests/InProcessEmitTest.cs

@@ -104,7 +104,7 @@ public void InProcessBenchmarkSimpleCasesReflectionEmitSupported()
             }
         }
 
-        [TheoryFullFrameworkOnly("We can't use Roslyn toolchain for .NET Core because we don't know which assemblies to reference and .NET Core does not support dynamic assembly saving")]
+        [TheoryEnvSpecific("We can't use Roslyn toolchain for .NET Core because we don't know which assemblies to reference and .NET Core does not support dynamic assembly saving", EnvRequirement.FullFrameworkOnly)]
         [InlineData(typeof(SampleBenchmark))]
         [InlineData(typeof(RunnableVoidCaseBenchmark))]
         [InlineData(typeof(RunnableRefStructCaseBenchmark))]

tests/BenchmarkDotNet.IntegrationTests/JitRuntimeValidationTest.cs

@@ -20,7 +20,7 @@ public JitRuntimeValidationTest(ITestOutputHelper output) : base(output) { }
         private const string RyuJitNotAvailable = "// ERROR:  RyuJIT is requested but it is not available in current environment";
         private const string ToolchainSupportsOnlyRyuJit = "Currently dotnet cli toolchain supports only RyuJit";
 
-        [TheoryWindowsOnly("CLR is a valid job only on Windows")]
+        [TheoryEnvSpecific("CLR is a valid job only on Windows", EnvRequirement.WindowsOnly)]
         [InlineData(Jit.LegacyJit, Platform.X86, null)]
         [InlineData(Jit.LegacyJit, Platform.X64, null)]
         [InlineData(Jit.RyuJit, Platform.X86, RyuJitNotAvailable)]

tests/BenchmarkDotNet.IntegrationTests/LargeAddressAwareTest.cs

@@ -19,7 +19,7 @@ public class LargeAddressAwareTest
 
         public LargeAddressAwareTest(ITestOutputHelper outputHelper) => output = outputHelper;
 
-        [FactWindowsOnly("CLR is a valid job only on Windows")]
+        [FactEnvSpecific("CLR is a valid job only on Windows", EnvRequirement.WindowsOnly)]
         public void BenchmarkCanAllocateMoreThan2Gb()
         {
             var summary = BenchmarkRunner

tests/BenchmarkDotNet.IntegrationTests/MemoryDiagnoserTests.cs

@@ -70,7 +70,7 @@ public void MemoryDiagnoserIsAccurate(IToolchain toolchain)
             });
         }
 
-        [FactDotNetCoreOnly("We don't want to test NativeAOT twice (for .NET Framework 4.6.2 and .NET 7.0)")]
+        [FactEnvSpecific("We don't want to test NativeAOT twice (for .NET Framework 4.6.2 and .NET 7.0)", EnvRequirement.DotNetCoreOnly)]
         public void MemoryDiagnoserSupportsNativeAOT()
         {
             if (RuntimeInformation.IsMacOS())
@@ -82,7 +82,7 @@ public void MemoryDiagnoserSupportsNativeAOT()
                     .ToToolchain());
         }
 
-        [FactDotNetCoreOnly("We don't want to test MonoVM twice (for .NET Framework 4.6.2 and .NET 7.0)")]
+        [FactEnvSpecific("We don't want to test MonoVM twice (for .NET Framework 4.6.2 and .NET 7.0)", EnvRequirement.DotNetCoreOnly)]
         public void MemoryDiagnoserSupportsModernMono()
         {
             MemoryDiagnoserIsAccurate(MonoToolchain.Mono70);
@@ -263,7 +263,9 @@ public void Allocate()
             }
         }
 
-        [TheoryNetCore30(".NET Core 3.0 preview6+ exposes a GC.GetTotalAllocatedBytes method which makes it possible to work"), MemberData(nameof(GetToolchains))]
+        [TheoryEnvSpecific(".NET Core 3.0 preview6+ exposes a GC.GetTotalAllocatedBytes method which makes it possible to work",
+            EnvRequirement.DotNetCore30Only)]
+        [MemberData(nameof(GetToolchains))]
         [Trait(Constants.Category, Constants.BackwardCompatibilityCategory)]
         public void MemoryDiagnoserIsAccurateForMultiThreadedBenchmarks(IToolchain toolchain)
         {

tests/BenchmarkDotNet.IntegrationTests/MonoTests.cs

@@ -10,7 +10,7 @@ namespace BenchmarkDotNet.IntegrationTests
 {
     public class MonoTests : BenchmarkTestExecutor
     {
-        [FactDotNetCoreOnly("UseMonoRuntime option is available in .NET Core only starting from .NET 6")]
+        [FactEnvSpecific("UseMonoRuntime option is available in .NET Core only starting from .NET 6", EnvRequirement.DotNetCoreOnly)]
         public void Mono70IsSupported()
         {
             var config = ManualConfig.CreateEmpty().AddJob(Job.Dry.WithRuntime(MonoRuntime.Mono70));