Skip to content

Commit 176b210

Browse files
committed
Revert suppressing of BDN1401 in FullNameProviderTests.cs, PriorityTests.cs and TypeFilterTests.cs
1 parent e20d4f9 commit 176b210

File tree

3 files changed

+0
-16
lines changed

3 files changed

+0
-16
lines changed

tests/BenchmarkDotNet.IntegrationTests/PriorityTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,9 @@ public class PriorityBenchmark
6262
[Benchmark]
6363
public int OneArgument(int b) => E ? A + b : F;
6464

65-
#pragma warning disable BDN1401
6665
[Benchmark]
6766
[ArgumentsSource(nameof(NumberArguments))]
6867
public int ManyArguments(int c, int d) => E ? A + c + d : F;
69-
#pragma warning restore BDN1401
7068

7169
public IEnumerable<object[]> NumberArguments()
7270
{

tests/BenchmarkDotNet.Tests/FullNameProviderTests.cs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ public class FewStringArguments
159159
public void Method(string arg1, string arg2, string arg3, string arg4) { }
160160
}
161161

162-
#pragma warning disable BDN1401
163162
public class SingleDateTimeArgument
164163
{
165164
[Benchmark]
@@ -171,9 +170,7 @@ public IEnumerable<object[]> Date()
171170
yield return new object[] { DateTime.MaxValue };
172171
}
173172
}
174-
#pragma warning restore BDN1401
175173

176-
#pragma warning disable BDN1401
177174
public class SingleGuidArgument
178175
{
179176
[Benchmark]
@@ -185,9 +182,7 @@ public IEnumerable<object[]> Guid()
185182
yield return new object[] { System.Guid.Empty };
186183
}
187184
}
188-
#pragma warning restore BDN1401
189185

190-
#pragma warning disable BDN1401
191186
public class WithArray
192187
{
193188
[Benchmark]
@@ -199,15 +194,13 @@ public IEnumerable<object[]> Data()
199194
yield return new object[] { new int[] { 1, 2, 3 }, 4 };
200195
}
201196
}
202-
#pragma warning restore BDN1401
203197

204198
public class SimpleGeneric<T>
205199
{
206200
[Benchmark]
207201
public T Method() => default(T);
208202
}
209203

210-
#pragma warning disable BDN1401
211204
public class WithCrazyUnicodeCharacters
212205
{
213206
[Benchmark]
@@ -219,7 +212,6 @@ public IEnumerable<object[]> Data()
219212
yield return new object[] { "FOO", "\u03C3", "x\u0305" }; // https://github.com/Microsoft/xunit-performance/blob/f1d1d62a934694d8cd19063e60e04c590711d904/tests/simpleharness/Program.cs#L29
220213
}
221214
}
222-
#pragma warning restore BDN1401
223215

224216
public class WithTabAndEnter
225217
{
@@ -228,7 +220,6 @@ public class WithTabAndEnter
228220
public void Method(string tab, string enter) { }
229221
}
230222

231-
#pragma warning disable BDN1401
232223
public class WithBigArray
233224
{
234225
[Benchmark]
@@ -240,9 +231,7 @@ public IEnumerable<object[]> Data()
240231
yield return new object[] { Enumerable.Range(0, 100).ToArray() };
241232
}
242233
}
243-
#pragma warning restore BDN1401
244234

245-
#pragma warning disable BDN1401
246235
public class WithArrayOfNullStrings
247236
{
248237
public IEnumerable<object> GetArrayOfStrings()
@@ -254,7 +243,6 @@ public IEnumerable<object> GetArrayOfStrings()
254243
[ArgumentsSource(nameof(GetArrayOfStrings))]
255244
public int Method(string[] array) => array.Length;
256245
}
257-
#pragma warning restore BDN1401
258246

259247
public class WithParameters
260248
{

tests/BenchmarkDotNet.Tests/TypeFilterTests.cs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,6 @@ public class SomeGeneric<T>
278278
public T Create() => Activator.CreateInstance<T>();
279279
}
280280

281-
#pragma warning disable BDN1401
282281
[Run]
283282
public class ClassE
284283
{
@@ -293,7 +292,6 @@ public class ClassE
293292
[ArgumentsSource(nameof(Values))]
294293
public string Method1(uint value) => value.ToString();
295294
}
296-
#pragma warning restore BDN1401
297295
}
298296

299297
namespace BenchmarkDotNet.NOTTests

0 commit comments

Comments
 (0)