print error when users try DisassemblyDiagnoser with NativeAOT (#2068)

* there should be only one method that tells whether given Job is NativeAOT or not

* print error when users try DisassemblyDiagnoser with NativeAOT

Author: adamsitnik

src/BenchmarkDotNet/Disassemblers/DisassemblyDiagnoser.cs

@@ -15,6 +15,7 @@
 using BenchmarkDotNet.Reports;
 using BenchmarkDotNet.Running;
 using BenchmarkDotNet.Toolchains.InProcess.NoEmit;
+using BenchmarkDotNet.Toolchains.NativeAot;
 using BenchmarkDotNet.Validators;
 
 namespace BenchmarkDotNet.Diagnosers
@@ -102,10 +103,14 @@ public IEnumerable<ValidationError> Validate(ValidationParameters validationPara
 
             foreach (var benchmark in validationParameters.Benchmarks)
             {
-                if (benchmark.Job.Infrastructure.HasValue(InfrastructureMode.ToolchainCharacteristic) && benchmark.Job.Infrastructure.Toolchain is InProcessNoEmitToolchain)
+                if (benchmark.Job.Infrastructure.TryGetToolchain(out var toolchain) && toolchain is InProcessNoEmitToolchain)
                 {
                     yield return new ValidationError(true, "InProcessToolchain has no DisassemblyDiagnoser support", benchmark);
                 }
+                else if (benchmark.Job.IsNativeAOT())
+                {
+                    yield return new ValidationError(true, "Currently NativeAOT has no DisassemblyDiagnoser support", benchmark);
+                }
 
                 if (ShouldUseLinuxDisassembler(benchmark))
                 {

src/BenchmarkDotNet/Jobs/EnvironmentMode.cs

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using BenchmarkDotNet.Characteristics;
 using BenchmarkDotNet.Environments;
+using BenchmarkDotNet.Portability;
 using JetBrains.Annotations;
 
 namespace BenchmarkDotNet.Jobs
@@ -110,5 +111,7 @@ public void SetEnvironmentVariable(EnvironmentVariable variable)
             newVariables.Add(variable);
             EnvironmentVariables = newVariables;
         }
+
+        internal Runtime GetRuntime() => HasValue(RuntimeCharacteristic) ? Runtime : RuntimeInformation.GetCurrentRuntime();
     }
 }

src/BenchmarkDotNet/Jobs/JobExtensions.cs

@@ -7,6 +7,7 @@
 using BenchmarkDotNet.Environments;
 using BenchmarkDotNet.Running;
 using BenchmarkDotNet.Toolchains;
+using BenchmarkDotNet.Toolchains.NativeAot;
 using JetBrains.Annotations;
 using Perfolizer.Horology;
 using Perfolizer.Mathematics.OutlierDetection;
@@ -417,6 +418,11 @@ internal static Job MakeSettingsUserFriendly(this Job job, Descriptor descriptor
             return job;
         }
 
+        internal static bool IsNativeAOT(this Job job)
+            => job.Environment.GetRuntime() is NativeAotRuntime
+            // given job can have NativeAOT toolchain set, but Runtime == default
+            || (job.Infrastructure.TryGetToolchain(out var toolchain) && toolchain is NativeAotToolchain);
+
         private static Job WithCore(this Job job, Action<Job> updateCallback)
         {
             bool hasId = job.HasValue(Job.IdCharacteristic);

src/BenchmarkDotNet/Running/BuildPartition.cs

@@ -48,19 +48,15 @@ public BuildPartition(BenchmarkBuildInfo[] benchmarks, IResolver resolver)
         [PublicAPI]
         public Jit Jit => RepresentativeBenchmarkCase.Job.ResolveValue(EnvironmentMode.JitCharacteristic, Resolver);
 
-        public bool IsNativeAot => Runtime is NativeAotRuntime
-            // given job can have NativeAOT toolchain set, but Runtime == default
-            || (RepresentativeBenchmarkCase.Job.Infrastructure.TryGetToolchain(out var toolchain) && toolchain is NativeAotToolchain);
+        public bool IsNativeAot => RepresentativeBenchmarkCase.Job.IsNativeAOT();
 
         public bool IsWasm => Runtime is WasmRuntime // given job can have Wasm toolchain set, but Runtime == default ;)
             || (RepresentativeBenchmarkCase.Job.Infrastructure.TryGetToolchain(out var toolchain) && toolchain is WasmToolChain);
 
         public bool IsNetFramework => Runtime is ClrRuntime
             || (RepresentativeBenchmarkCase.Job.Infrastructure.TryGetToolchain(out var toolchain) && (toolchain is RoslynToolchain || toolchain is CsProjClassicNetToolchain));
 
-        public Runtime Runtime => RepresentativeBenchmarkCase.Job.Environment.HasValue(EnvironmentMode.RuntimeCharacteristic)
-            ? RepresentativeBenchmarkCase.Job.Environment.Runtime
-            : RuntimeInformation.GetCurrentRuntime();
+        public Runtime Runtime => RepresentativeBenchmarkCase.Job.Environment.GetRuntime();
 
         public bool IsCustomBuildConfiguration => BuildConfiguration != InfrastructureMode.ReleaseConfigurationName;