Linting.

Author: domdfcoding

domdf_python_tools/compat.py

@@ -66,7 +66,7 @@
 
 	_T = TypeVar("_T")
 
-	class nullcontext(ContextManager):
+	class nullcontext(ContextManager[Optional[_T]]):
 		"""
 		Context manager that does no additional processing.
 

domdf_python_tools/pagesizes/classes.py

@@ -215,7 +215,12 @@ class PageSize(BaseSize):
 
 	__slots__: List[str] = []
 
-	def __new__(cls, width: AnyNumber, height: AnyNumber, unit: AnyNumber = pt):
+	def __new__(
+			cls,
+			width: AnyNumber,
+			height: AnyNumber,
+			unit: AnyNumber = pt,  # pylint: disable=used-before-assignment
+			):
 		"""
 		Create a new :class:`~domdf_python_tools.pagesizes.classes.PageSize` object.
 

domdf_python_tools/pretty_print.py

@@ -105,26 +105,34 @@ def _make_open(self, char: str, indent: int, obj):
 		else:
 			the_indent = ' ' * (indent + self._indent_per_level)
 
-		if len(obj) and not self._compact:  # type: ignore
+		if obj and not self._compact:  # type: ignore
 			return f"{char}\n{the_indent}"
 		else:
 			return char
 
 	def _make_close(self, char: str, indent: int, obj):
-		if len(obj) and not self._compact:  # type: ignore
+		if obj and not self._compact:  # type: ignore
 			return f",\n{' ' * (indent + self._indent_per_level)}{char}"
 		else:
 			return char
 
-	def _pprint_dict(self, object, stream, indent, allowance, context, level):  # noqa: A002
+	def _pprint_dict(
+			self,
+			object,  # noqa: A002  # pylint: disable=redefined-builtin
+			stream,
+			indent,
+			allowance,
+			context,
+			level,
+			):
 		obj = object
 		write = stream.write
 		write(self._make_open('{', indent, obj))
 
 		if self._indent_per_level > 1:
 			write((self._indent_per_level - 1) * ' ')
 
-		if len(obj):
+		if obj:
 			self._format_dict_items(  # type: ignore
 					obj.items(),
 					stream,
@@ -154,9 +162,10 @@ def _pprint_tuple(self, obj, stream, indent, allowance, context, level):
 	_dispatch[tuple.__repr__] = _pprint_tuple
 
 	def _pprint_set(self, obj, stream, indent, allowance, context, level):
-		if not len(obj):
+		if not obj:
 			stream.write(repr(obj))
 			return
+
 		typ = obj.__class__
 		if typ is set:
 			stream.write(self._make_open('{', indent, obj))
@@ -165,6 +174,7 @@ def _pprint_set(self, obj, stream, indent, allowance, context, level):
 			stream.write(typ.__name__ + f"({{\n{' ' * (indent + self._indent_per_level + len(typ.__name__) + 1)}")
 			endchar = f",\n{' ' * (indent + self._indent_per_level + len(typ.__name__) + 1)}}})"
 			indent += len(typ.__name__) + 1
+
 		obj = sorted(obj, key=_safe_key)
 		self._format_items(obj, stream, indent, allowance + len(endchar), context, level)
 		stream.write(endchar)
@@ -205,7 +215,7 @@ def format_attributes(self, obj: Attributes):
 		if self._indent_per_level > 1:
 			stream.write((self._indent_per_level - 1) * ' ')
 
-		if len(obj):
+		if obj:
 			self._format_attribute_items(list(obj), stream, 0, 0 + 1, context, 1)
 		stream.write(f"\n{self._indent_per_level * ' '})")
 

domdf_python_tools/stringlist.py

@@ -238,11 +238,11 @@ def __setitem__(self, index: Union[int, slice], line: Union[String, Iterable[Str
 			self.insert(index, line)
 
 		elif isinstance(index, slice):
-			for line, index in zip(
+			for line, idx in zip(  # pylint: disable=redefined-argument-from-local
 				reversed(line),  # type: ignore
 				reversed(range(index.start or 0, index.stop + 1, index.step or 1)),
 				):
-				self[index] = line
+				self[idx] = line
 
 	@overload
 	def __getitem__(self, index: int) -> str:
@@ -461,4 +461,4 @@ class DelimitedList(List[_S]):
 	"""
 
 	def __format__(self, format_spec: str) -> str:
-		return format_spec.join([str(x) for x in self])
+		return format_spec.join([str(x) for x in self])  # pylint: disable=not-an-iterable

tests/test_dates.py

@@ -145,7 +145,7 @@ def test_utc_offset_no_pytz():
 				ImportError,
 				match=r"'get_utc_offset' requires pytz \(.*\), but it could not be imported",
 				):
-			dates.get_utc_offset
+			dates.get_utc_offset  # pylint: disable=pointless-statement
 
 		with pytest.raises(
 				ImportError,

tests/test_paths_stdlib.py

@@ -595,9 +595,9 @@ def test_pickling_common(BASE):
 def test_concrete_class():
 	p = PathPlus('a')
 	if os.name == "nt":
-		assert type(p) is WindowsPathPlus
+		assert type(p) is WindowsPathPlus  # pylint: disable=unidiomatic-typecheck
 	else:
-		assert type(p) is PosixPathPlus
+		assert type(p) is PosixPathPlus  # pylint: disable=unidiomatic-typecheck
 
 
 def test_unsupported_flavour():

tests/test_pretty_print.py

@@ -115,7 +115,7 @@ def __repr__(self):
 # Class Orderable is orderable with any type
 class Orderable:
 
-	def __init__(self, hash):  # noqa A002
+	def __init__(self, hash):  # noqa A002  # pylint: disable=redefined-builtin
 		self._hash = hash
 
 	def __lt__(self, other):
@@ -961,7 +961,7 @@ def test_user_string(self, value, width, expects):
 
 class DottedPrettyPrinter(FancyPrinter):
 
-	def format(self, object, context, maxlevels, level):  # noqa: A002,A003
+	def format(self, object, context, maxlevels, level):  # noqa: A002,A003  # pylint: disable=redefined-builtin
 		if isinstance(object, str):
 			if ' ' in object:
 				return repr(object), 1, 0