matchglob: Fix edge case with leading ** and multiple trailing **

Author: domdfcoding

domdf_python_tools/paths.py

@@ -863,7 +863,7 @@ def traverse_to_file(base_directory: _P, *filename: PathLike, height: int = -1)
 	raise FileNotFoundError(f"'{filename[0]!s}' not found in {base_directory}")
 
 
-def matchglob(filename: PathLike, pattern):
+def matchglob(filename: PathLike, pattern: str):
 	"""
 	Given a filename and a glob pattern, return whether the filename matches the glob.
 
@@ -899,12 +899,19 @@ def matchglob(filename: PathLike, pattern):
 			filename_part = filename_parts.popleft()
 
 		if pattern_part == "**":
-			if not pattern_parts or not filename_parts:
+			if not pattern_parts:
 				return True
 
 			while pattern_part == "**":
+				if not pattern_parts:
+					return True
+
 				pattern_part = pattern_parts.popleft()
 
+			if pattern_parts and not filename_parts:
+				# Filename must match everything after **
+				return False
+
 			if fnmatch.fnmatchcase(filename_part, pattern_part):
 				continue
 			else:

tests/test_paths.py

@@ -801,6 +801,17 @@ def test_iterchildren_no_exclusions(tmp_pathplus: PathPlus):
 						True
 						),
 				("domdf_python_tools/**/*.py", "domdf_python_tools/domdf_python_tools/pagesizes/units.py", True),
+				("**/*.py", ".pre-commit-config.yaml", False),
+				("**/*.yaml", ".pre-commit-config.yaml", True),
+				("./**/*.py", ".pre-commit-config.yaml", False),
+				("./**/*.yaml", ".pre-commit-config.yaml", True),
+				("foo/**/**/bar.py", "foo/bar.py", True),
+				("foo/**/**/bar.py", "foo/baz/bar.py", True),
+				("foo/**/**/bar.py", "foo/baz/baz/bar.py", True),
+				("foo/**/**", "foo/", True),
+				("foo/**/**", "foo/bar.py", True),
+				("foo/**/**", "foo/baz/bar.py", True),
+				("foo/**/**", "foo/baz/baz/bar.py", True),
 				]
 		)
 def test_globpath(pattern: str, filename: str, match: bool):