clean up

angelamayxie · angelamayxie · commit d628a3143087 · 2025-10-28T16:30:14.000-07:00
diff --git a/sql/analyzer/replace_sort.go b/sql/analyzer/replace_sort.go
@@ -179,10 +179,8 @@ func replaceIdxSortHelper(ctx *sql.Context, scope *plan.Scope, node sql.Node, so
 				}
 			}
 			newSort := sortNode.WithSortFields(sortFields)
+			// The sort node is used to find table aliases and we need to get the table aliases inside the SubqueryAlias
 			newSort.Child = c.Child
-			if err != nil {
-				return nil, transform.SameTree, err
-			}
 			newChildren[i], same, err = replaceIdxSortHelper(ctx, scope, child, newSort)
 		case *plan.JoinNode:
 			// It's (probably) not possible to have Sort as child of Join without Subquery/SubqueryAlias,

Original file line number	Diff line number	Diff line change
`@@ -179,10 +179,8 @@ func replaceIdxSortHelper(ctx sql.Context, scope plan.Scope, node sql.Node, so`
`179`	`179`	`}`
`180`	`180`	`}`
`181`	`181`	`newSort := sortNode.WithSortFields(sortFields)`
	`182`	`+ // The sort node is used to find table aliases and we need to get the table aliases inside the SubqueryAlias`
`182`	`183`	`newSort.Child = c.Child`
`183`		`- if err != nil {`
`184`		`- return nil, transform.SameTree, err`
`185`		`- }`
`186`	`184`	`newChildren[i], same, err = replaceIdxSortHelper(ctx, scope, child, newSort)`
`187`	`185`	`case *plan.JoinNode:`
`188`	`186`	`// It's (probably) not possible to have Sort as child of Join without Subquery/SubqueryAlias,`