comment

James Cor · James Cor · commit d5eb7d90d2d7 · 2025-11-03T11:46:42.000-08:00
diff --git a/sql/types/bit.go b/sql/types/bit.go
@@ -252,9 +252,8 @@ func (t BitType_) SQLValue(ctx *sql.Context, v sql.Value, dest []byte) (sqltypes
 	}
 	v.Val = v.Val[:numBytes]
 
-	// TODO: for whatever reason TestTypesOverWire only works when this is a deep copy?
-	dest = append(dest, v.Val...)
 	// want the results in big endian
+	dest = append(dest, v.Val...)
 	for i, j := 0, len(dest)-1; i < j; i, j = i+1, j-1 {
 		dest[i], dest[j] = dest[j], dest[i]
 	}

Original file line number	Diff line number	Diff line change
`@@ -252,9 +252,8 @@ func (t BitType_) SQLValue(ctx *sql.Context, v sql.Value, dest []byte) (sqltypes`
`252`	`252`	`}`
`253`	`253`	`v.Val = v.Val[:numBytes]`
`254`	`254`
`255`		`- // TODO: for whatever reason TestTypesOverWire only works when this is a deep copy?`
`256`		`- dest = append(dest, v.Val...)`
`257`	`255`	`// want the results in big endian`
	`256`	`+ dest = append(dest, v.Val...)`
`258`	`257`	`for i, j := 0, len(dest)-1; i < j; i, j = i+1, j-1 {`
`259`	`258`	`dest[i], dest[j] = dest[j], dest[i]`
`260`	`259`	`}`