add TODO comments

Author: angelamayxie

enginetest/queries/script_queries.go

@@ -11133,8 +11133,8 @@ where
 			},
 			{
 				Query: "select * from " +
-					"(select 'parent' as db, id, words from t union " +
-					"select 'child' as db, id,words from t2) as combined where combined.id=1",
+					"(select 'parent' as tbl, id, words from t union " +
+					"select 'child' as tbl, id,words from t2) as combined where combined.id=1",
 				Expected: []sql.Row{
 					{"parent", 1, "foo"},
 					{"child", 1, "boo"},

sql/analyzer/fix_exec_indexes.go

@@ -712,6 +712,8 @@ func columnIdsForNode(n sql.Node) []sql.ColumnId {
 				break
 			}
 		}
+		// TODO: columns are appended in increasing order by ColumnId instead of how they are actually ordered. likely
+		// needs to be fixed
 		cols.ForEach(func(col sql.ColumnId) {
 			ret = append(ret, col)
 		})

sql/plan/set_op.go

@@ -44,7 +44,8 @@ var _ sql.Node = (*SetOp)(nil)
 var _ sql.Expressioner = (*SetOp)(nil)
 var _ sql.CollationCoercible = (*SetOp)(nil)
 
-// var _ sql.NameableNode = (*SetOp)(nil)
+// TODO: This might not be necessary now that SetOp exec indexes are assigned based on its left child node, instead of
+// the cols in ColSet
 var _ TableIdNode = (*SetOp)(nil)
 
 // NewSetOp creates a new SetOp node with the given children.