share update auto_inc func

Author: elianddb

memory/table.go

@@ -1284,10 +1284,7 @@ func addColumnToSchema(ctx *sql.Context, data *TableData, newCol *sql.Column, or
 			data.autoIncVal = 0
 		}
 
-		nextVal := data.autoIncVal + 1
-		if _, inRange, err := newCol.Type.Convert(ctx, nextVal); err == nil && inRange == sql.InRange {
-			data.autoIncVal = nextVal
-		}
+		updateAutoIncrementSafe(ctx, newCol, &data.autoIncVal)
 	}
 
 	newPkOrds := data.schema.PkOrdinals
@@ -2581,3 +2578,21 @@ func (t *TableRevision) AddColumn(ctx *sql.Context, column *sql.Column, order *s
 func (t *TableRevision) IgnoreSessionData() bool {
 	return true
 }
+
+// updateAutoIncrementSafe safely increments an auto_increment value, handling overflow
+// by ensuring it doesn't exceed the column type's maximum value or wrap around.
+func updateAutoIncrementSafe(ctx *sql.Context, autoCol *sql.Column, autoIncVal *uint64) {
+	currentVal := *autoIncVal
+
+	// Check for arithmetic overflow before adding 1
+	if currentVal == math.MaxUint64 {
+		// At maximum uint64 value, can't increment further
+		return
+	}
+
+	nextVal := currentVal + 1
+	if _, inRange, err := autoCol.Type.Convert(ctx, nextVal); err == nil && inRange == sql.InRange {
+		*autoIncVal = nextVal
+	}
+	// If next value would be out of range for the column type, stay at current value
+}

memory/table_editor.go

@@ -16,7 +16,6 @@ package memory
 
 import (
 	"fmt"
-	"math"
 	"reflect"
 	"strings"
 
@@ -193,9 +192,10 @@ func (t *tableEditor) Insert(ctx *sql.Context, row sql.Row) error {
 			if err != nil {
 				return err
 			}
-			t.updateAutoIncrementValue(ctx, autoCol, insertedVal.(uint64))
+			t.ea.TableData().autoIncVal = insertedVal.(uint64)
+			updateAutoIncrementSafe(ctx, autoCol, &t.ea.TableData().autoIncVal)
 		} else if cmp == 0 {
-			t.updateAutoIncrementValue(ctx, autoCol, t.ea.TableData().autoIncVal)
+			updateAutoIncrementSafe(ctx, autoCol, &t.ea.TableData().autoIncVal)
 		}
 	}
 
@@ -888,22 +888,3 @@ func verifyRowTypes(row sql.Row, schema sql.Schema) error {
 	}
 	return nil
 }
-
-// updateAutoIncrementValue safely increments the auto_increment value, handling overflow
-// by ensuring it doesn't exceed the column type's maximum value or wrap around.
-func (t *tableEditor) updateAutoIncrementValue(ctx *sql.Context, autoCol *sql.Column, currentVal uint64) {
-	// Check for arithmetic overflow before adding 1
-	if currentVal == math.MaxUint64 {
-		// At maximum uint64 value, can't increment further
-		t.ea.TableData().autoIncVal = currentVal
-		return
-	}
-	
-	nextVal := currentVal + 1
-	if _, inRange, err := autoCol.Type.Convert(ctx, nextVal); err == nil && inRange == sql.InRange {
-		t.ea.TableData().autoIncVal = nextVal
-	} else {
-		// If next value would be out of range for the column type, stay at current value
-		t.ea.TableData().autoIncVal = currentVal
-	}
-}