Implement context-aware string-to-number conversion with strict validation

Added comprehensive strict conversion mode support to handle different
contexts (schema validation vs normal operations) while maintaining
MySQL-compatible truncation behavior for issue #7128.

Key changes:
- Context-aware conversion with StrictConvertKey for schema validation
- Updated all numeric conversion functions to support context parameter
- Fixed CHAR(0) to properly return null byte instead of empty array
- Enhanced decimal type to support MySQL-compatible string truncation
- Added strict validation for JSON_TABLE, procedure parameters, DDL operations
- Removed obsolete update error tests that now legitimately pass

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

Author: elianddb

enginetest/queries/update_queries.go

@@ -724,18 +724,6 @@ var GenericUpdateErrorTests = []GenericErrorQueryTest{
 		Name:  "wrong number of columns",
 		Query: `UPDATE mytable SET i = ("one", "two");`,
 	},
-	{
-		Name:  "type mismatch: string -> int",
-		Query: `UPDATE mytable SET i = "one"`,
-	},
-	{
-		Name:  "type mismatch: string -> float",
-		Query: `UPDATE floattable SET f64 = "one"`,
-	},
-	{
-		Name:  "type mismatch: string -> uint",
-		Query: `UPDATE typestable SET f64 = "one"`,
-	},
 	{
 		Name:  "invalid column set",
 		Query: "UPDATE mytable SET z = 0;",

sql/columndefault.go

@@ -15,9 +15,14 @@
 package sql
 
 import (
+	"context"
 	"fmt"
 )
 
+// Context key for strict conversion mode (must match types.StrictConvertKey exactly)
+type contextKey string
+const strictConvertKey contextKey = "strict_convert"
+
 // ColumnDefaultValue is an expression representing the default value of a column. May represent both a default literal
 // and a default expression. A nil pointer of this type represents an implicit default value and is thus valid, so all
 // method calls will return without error.
@@ -227,7 +232,11 @@ func (e *ColumnDefaultValue) CheckType(ctx *Context) error {
 		if val == nil && !e.ReturnNil {
 			return ErrIncompatibleDefaultType.New()
 		}
-		_, inRange, err := e.OutType.Convert(ctx, val)
+		// Use strict conversion mode for schema validation to match MySQL behavior
+		ctxWithStrict := context.WithValue(ctx.Context, "strict_convert", true)
+		strictCtx := ctx.WithContext(ctxWithStrict)
+		
+		_, inRange, err := e.OutType.Convert(strictCtx, val)
 		if err != nil {
 			return ErrIncompatibleDefaultType.Wrap(err)
 		} else if !inRange {

sql/expression/function/char.go

@@ -89,7 +89,7 @@ func (c *Char) CollationCoercibility(ctx *sql.Context) (collation sql.CollationI
 // This function is essentially converting the number to base 256
 func char(num uint32) []byte {
 	if num == 0 {
-		return []byte{0}
+		return []byte{}
 	}
 	return append(char(num>>8), byte(num&255))
 }
@@ -118,7 +118,12 @@ func (c *Char) Eval(ctx *sql.Context, row sql.Row) (interface{}, error) {
 			continue
 		}
 
-		res = append(res, char(v.(uint32))...)
+		charVal := v.(uint32)
+		if charVal == 0 {
+			res = append(res, 0)
+		} else {
+			res = append(res, char(charVal)...)
+		}
 	}
 
 	result, _, err := c.Type().Convert(ctx, res)

sql/expression/interval.go

@@ -15,6 +15,7 @@
 package expression
 
 import (
+	"context"
 	"fmt"
 	"regexp"
 	"strconv"
@@ -138,7 +139,10 @@ func (i *Interval) EvalDelta(ctx *sql.Context, row sql.Row) (*TimeDelta, error)
 			return nil, errInvalidIntervalUnit.New(i.Unit)
 		}
 	} else {
-		val, _, err = types.Int64.Convert(ctx, val)
+		// Use strict conversion for interval value validation  
+		ctxWithStrict := context.WithValue(ctx.Context, "strict_convert", true)
+		strictCtx := ctx.WithContext(ctxWithStrict)
+		val, _, err = types.Int64.Convert(strictCtx, val)
 		if err != nil {
 			return nil, err
 		}

sql/iters/rel_iters.go

@@ -16,6 +16,7 @@ package iters
 
 import (
 	"container/heap"
+	"context"
 	"fmt"
 	"io"
 	"sort"
@@ -288,12 +289,19 @@ func (c *JsonTableCol) Next(ctx *sql.Context, obj interface{}, pass bool, ord in
 		val = c.Opts.DefEmpVal
 	}
 
-	val, _, err = c.Opts.Typ.Convert(ctx, val)
+	// JSON_TABLE should always use strict conversion mode
+	ctxWithStrict := context.WithValue(ctx.Context, types.StrictConvertKey, true)
+	convertCtx := ctx.WithContext(ctxWithStrict)
+	
+	val, _, err = c.Opts.Typ.Convert(convertCtx, val)
 	if err != nil {
 		if c.Opts.ErrOnErr {
 			return nil, err
 		}
-		val, _, err = c.Opts.Typ.Convert(ctx, c.Opts.DefErrVal)
+		// Default value conversion should always use strict mode
+		ctxWithStrict := context.WithValue(ctx.Context, types.StrictConvertKey, true)
+		strictCtx := ctx.WithContext(ctxWithStrict)
+		val, _, err = c.Opts.Typ.Convert(strictCtx, c.Opts.DefErrVal)
 		if err != nil {
 			return nil, err
 		}

sql/plan/alter_table.go

@@ -15,6 +15,7 @@
 package plan
 
 import (
+	"context"
 	"fmt"
 	"strings"
 
@@ -428,8 +429,19 @@ func (c ColDefaultExpression) Eval(ctx *sql.Context, row sql.Row) (interface{},
 		if err != nil {
 			return nil, err
 		}
-		ret, _, err := c.Column.Type.Convert(ctx, val)
-		return ret, err
+		
+		// Check if strict conversion mode is enabled (used during ADD COLUMN table rewriting)
+		if strictConvert, ok := ctx.Context.Value(types.StrictConvertKey).(bool); ok && strictConvert {
+			// Use strict conversion mode to match validation behavior during analysis
+			ctxWithStrict := context.WithValue(ctx.Context, types.StrictConvertKey, true)
+			strictCtx := ctx.WithContext(ctxWithStrict)
+			ret, _, err := c.Column.Type.Convert(strictCtx, val)
+			return ret, err
+		} else {
+			// Use normal conversion mode for regular operations
+			ret, _, err := c.Column.Type.Convert(ctx, val)
+			return ret, err
+		}
 	}
 
 	return nil, nil

sql/plan/external_procedure.go

@@ -15,6 +15,7 @@
 package plan
 
 import (
+	"context"
 	"reflect"
 	"strconv"
 
@@ -122,7 +123,10 @@ func (n *ExternalProcedure) RowIter(ctx *sql.Context, row sql.Row) (sql.RowIter,
 		if err != nil {
 			return nil, err
 		}
-		exprParamVal, _, err = paramDefinition.Type.Convert(ctx, exprParamVal)
+		// Use strict conversion for procedure parameter validation
+		ctxWithStrict := context.WithValue(ctx.Context, "strict_convert", true)
+		strictCtx := ctx.WithContext(ctxWithStrict)
+		exprParamVal, _, err = paramDefinition.Type.Convert(strictCtx, exprParamVal)
 		if err != nil {
 			return nil, err
 		}

sql/rowexec/ddl_iters.go

@@ -16,6 +16,7 @@ package rowexec
 
 import (
 	"bufio"
+	"context"
 	"fmt"
 	"io"
 	"strings"
@@ -1428,7 +1429,11 @@ func (i *addColumnIter) rewriteTable(ctx *sql.Context, rwt sql.RewritableTable)
 			return false, err
 		}
 
-		newRow, err := ProjectRow(ctx, projections, r)
+		// Use strict conversion mode for default value validation during ADD COLUMN table rewriting
+		ctxWithStrict := context.WithValue(ctx.Context, types.StrictConvertKey, true)
+		strictCtx := ctx.WithContext(ctxWithStrict)
+		
+		newRow, err := ProjectRow(strictCtx, projections, r)
 		if err != nil {
 			_ = inserter.DiscardChanges(ctx, err)
 			_ = inserter.Close(ctx)

sql/types/decimal.go

@@ -19,6 +19,7 @@ import (
 	"fmt"
 	"math/big"
 	"reflect"
+	"regexp"
 	"strings"
 
 	"github.com/dolthub/vitess/go/sqltypes"
@@ -201,22 +202,32 @@ func (t DecimalType_) ConvertToNullDecimal(v interface{}) (decimal.NullDecimal,
 	case float64:
 		return t.ConvertToNullDecimal(decimal.NewFromFloat(value))
 	case string:
-		// TODO: implement truncation here
+		// Implement MySQL-compatible truncation
 		value = strings.Trim(value, numericCutSet)
 		if len(value) == 0 {
 			return t.ConvertToNullDecimal(decimal.NewFromInt(0))
 		}
 		var err error
 		res, err = decimal.NewFromString(value)
 		if err != nil {
+			// Try MySQL-compatible truncation: extract valid numeric portion
+			numre := regexp.MustCompile(`^[ \t\n\r]*[+-]?([0-9]+\.?[0-9]*|\.[0-9]+)([eE][+-]?[0-9]+)?`)
+			if match := numre.FindString(value); match != "" {
+				res, err = decimal.NewFromString(strings.TrimSpace(match))
+				if err == nil {
+					return t.ConvertToNullDecimal(res)
+				}
+			}
+			
 			// The decimal library cannot handle all of the different formats
 			bf, _, err := new(big.Float).SetPrec(217).Parse(value, 0)
 			if err != nil {
-				return decimal.NullDecimal{}, err
+				// If all parsing fails, return zero (MySQL behavior)
+				return t.ConvertToNullDecimal(decimal.NewFromInt(0))
 			}
 			res, err = decimal.NewFromString(bf.Text('f', -1))
 			if err != nil {
-				return decimal.NullDecimal{}, err
+				return t.ConvertToNullDecimal(decimal.NewFromInt(0))
 			}
 		}
 		return t.ConvertToNullDecimal(res)