right column should not be skipped for nil comparisons in anti-joins

Author: angelamayxie

sql/rowexec/join_iters.go

@@ -256,7 +256,6 @@ const (
 	esIncRight
 	esRightIterEOF
 	esCompare
-	esRejectNull
 	esRet
 )
 
@@ -273,7 +272,6 @@ func (i *existsIter) Next(ctx *sql.Context) (sql.Row, error) {
 	//    when the secondaryProvider is empty
 	//  - antiJoin succeeds to RET when LOAD_RIGHT EOF's
 	//  - semiJoin fails when LOAD_RIGHT EOF's, falling back to LOAD_LEFT
-	//  - antiJoin fails when COMPARE returns true, falling back to LOAD_LEFT
 	nextState := esIncLeft
 	for {
 		switch nextState {
@@ -325,11 +323,6 @@ func (i *existsIter) Next(ctx *sql.Context) (sql.Row, error) {
 				return nil, err
 			}
 
-			if res == nil && i.typ.IsExcludeNulls() {
-				nextState = esRejectNull
-				continue
-			}
-
 			if !sql.IsTrue(res) {
 				nextState = esIncRight
 			} else {
@@ -344,12 +337,6 @@ func (i *existsIter) Next(ctx *sql.Context) (sql.Row, error) {
 					nextState = esRet
 				}
 			}
-		case esRejectNull:
-			if i.typ.IsAnti() {
-				nextState = esIncLeft
-			} else {
-				nextState = esIncRight
-			}
 		case esRet:
 			return i.removeParentRow(left), nil
 		default: