Raise error if both version_file and version_callback are set

Author: dolfinus

CHANGELOG.rst

@@ -12,6 +12,11 @@ Changelog
 
         ``version_callback`` option is used even if there are some tags in the current branch
 
+    .. change::
+        :tags: core, feature
+
+        Raise exception if both ``version_file`` and ``version_callback`` options are set
+
 1.9
 ----
 

docs/options/version_callback.rst

@@ -7,6 +7,10 @@ Callback to be used for getting a version number.
 
 Used by :ref:`version-callback` versioning schema.
 
+.. note::
+
+    This option conflicts with :ref:`version-file-option`, only one of them can be set.
+
 Type
 ^^^^^^^^^^^^^^
 

docs/options/version_file.rst

@@ -7,7 +7,11 @@ Version file path template for :ref:`version-file` versioning schema.
 
 .. note::
 
-    This option is completely ignored if :ref:`version-callback` or :ref:`tag-release` schemas are used.
+    This option is completely ignored if :ref:`tag-release` schema is used.
+
+.. note::
+
+    This option conflicts with :ref:`version-callback-option`, only one of them can be set.
 
 Type
 ^^^^^

setuptools_git_versioning.py

@@ -385,7 +385,10 @@ def version_from_git(
     tag = get_tag(sort_by=sort_by)
 
     if version_callback is not None:
-        # TODO: raise exception if both version_callback and version_file are set
+        if version_file is not None:
+            raise ValueError(
+                "Either `version_file` or `version_callback` can be passed, but not both at the same time",
+            )
         return get_version_from_callback(version_callback, package_name)
 
     if tag is None:

tests/test_integration/test_version_callback.py

@@ -160,11 +160,7 @@ def test_version_callback_has_more_priority_than_tag(repo, create_config):
     assert get_version(repo) == version
 
 
-def test_version_callback_has_more_priority_than_version_file(repo, create_config):
-    create_file(repo, "VERSION.txt", "1.2.3")
-    version = "1.0.0"
-
-    create_file(repo, "version.py", VERSION_PY.format(version=version), commit=False)
+def test_version_callback_conflicts_with_version_file(repo, create_config):
     create_config(
         repo,
         {
@@ -173,7 +169,8 @@ def test_version_callback_has_more_priority_than_version_file(repo, create_confi
         },
     )
 
-    assert get_version(repo) == version
+    with pytest.raises(subprocess.CalledProcessError):
+        get_version(repo)
 
 
 @pytest.mark.parametrize(