Fix linting and typing

Author: jorg-vr

tested/dsl/translate_parser.py

@@ -187,12 +187,18 @@ def is_expression(_checker: TypeChecker, instance: Any) -> bool:
     return isinstance(instance, ExpressionString)
 
 
-def load_schema_validator(dsl_object: YamlObject = None, file: str = "schema-strict.json") -> Validator:
+def load_schema_validator(
+    dsl_object: YamlObject = None, file: str = "schema-strict.json"
+) -> Validator:
     """
     Load the JSON Schema validator used to check DSL test suites.
     """
     # if the programming language is set in the root, tested_dsl_expressions don't need to be parseable
-    language_present =  dsl_object is not None and "language" in dsl_object
+    language_present = (
+        dsl_object is not None
+        and isinstance(dsl_object, dict)
+        and "language" in dsl_object
+    )
 
     def validate_tested_dsl_expression(value: object) -> bool:
         if not isinstance(value, str):
@@ -213,7 +219,9 @@ def validate_tested_dsl_expression(value: object) -> bool:
         "oracle", is_oracle
     ).redefine("expression", is_expression)
     format_checker = original_validator.FORMAT_CHECKER
-    format_checker.checks("tested-dsl-expression", SyntaxError)(validate_tested_dsl_expression)
+    format_checker.checks("tested-dsl-expression", SyntaxError)(
+        validate_tested_dsl_expression
+    )
     tested_validator = extend_validator(original_validator, type_checker=type_checker)
     return tested_validator(schema_object, format_checker=format_checker)
 

tests/test_dsl_yaml.py

@@ -1303,6 +1303,7 @@ def test_empty_text_data_newlines():
     actual_stderr = suite.tabs[0].contexts[0].testcases[0].output.stderr.data
     assert actual_stderr == ""
 
+
 def test_programming_language_can_be_globally_configured():
     yaml_str = """
 namespace: "Numbers"
@@ -1325,6 +1326,7 @@ def test_programming_language_can_be_globally_configured():
     assert testcase.input.type == "expression"
     assert testcase.input.literals.keys() == {"java"}
 
+
 def test_strict_json_schema_is_valid():
     path_to_schema = Path(__file__).parent / "tested-draft7.json"
     with open(path_to_schema, "r") as schema_file:
@@ -1337,6 +1339,6 @@ def test_strict_json_schema_is_valid():
 
 
 def test_editor_json_schema_is_valid():
-    validator = load_schema_validator(file= "schema.json")
+    validator = load_schema_validator(file="schema.json")
     assert isinstance(validator.schema, dict)
     validator.check_schema(validator.schema)