updated get_2nd_largest with minor change

Author: jasonzhuyx

ml/misc/grid.py

@@ -37,7 +37,7 @@ def __init__(self, grid):
         self.size_row = len(grid)
         # print('grid [%d, %d]: %s' % (self.size_col, self.size_row, self.grid))
 
-    def _get_cells_sum(self, x, y):
+    def _get_colum_sum(self, x, y):
         sum = 0
         if y >= 0 and y < self.size_col:
             for i in [-1, 0, 1]:
@@ -62,10 +62,10 @@ def get_next_grid(self):
         """
         next = copy.deepcopy(self.grid)
         for x in range(self.size_row):
-            lv, mv, rv = 0, 0, self._get_cells_sum(x, 0)
+            lv, mv, rv = 0, 0, self._get_colum_sum(x, 0)
             for y in range(self.size_col):
                 cv = self.grid[x][y]
-                lv, mv, rv = mv, rv, self._get_cells_sum(x, y+1)
+                lv, mv, rv = mv, rv, self._get_colum_sum(x, y+1)
                 count = lv + mv + rv - cv
                 next[x][y] = self._get_next_state(cv, count)
         return next

ml/misc/interview.py

@@ -8,16 +8,17 @@
 LOGGER = get_logger(__name__)
 
 
-def get_2nd_largest(num_list):
+def get_2nd_largest(num_list: list):
     """
     Get the second largest number in a list of numbers
     @param num_list: list of numbers, list
     @return:
     """
     if not isinstance(num_list, list):
         return None
+    if len(num_list) < 2:
+        return None
     m1st, m2nd = None, None
-    counter = 0
     for item in num_list:
         if not isinstance(item, (int, float)):
             continue
@@ -26,9 +27,6 @@ def get_2nd_largest(num_list):
         if m1st is None or item > m1st:
             m2nd = m1st
             m1st = item
-        counter += 1
-    if counter < 2:
-        return None
     return m2nd