Merge pull request #553 from docker/486-get-tags

Fixed get_tags whe using storage_path

Author: dmp42

docker_registry/tags.py

@@ -70,7 +70,9 @@ def get_tags(namespace, repository):
         if not full_tag_name.startswith('tag_'):
             continue
         tag_name = full_tag_name[4:]
-        tag_content = store.get_content(fname)
+        tag_content = store.get_content(
+            store.tag_path(namespace, repository, tag_name)
+        )
         yield (tag_name, tag_content)
 
 

tests/test_s3.py

@@ -112,3 +112,28 @@ def test_debug_key(self):
 
         # We don't call self._storage.remove(filename) here to ensure tearDown
         # cleanup properly and that other tests keep running as expected.
+
+    # Validation test for docker-index#486
+    def test_get_tags(self):
+        store = self._storage
+        store._root_path = 'my/custom/path'
+        store._init_path()
+        assert store._root_path == 'my/custom/path'
+        tag_path = store.tag_path('test', 'test', '0.0.2')
+        store.put_content(tag_path, 'randomdata')
+        tags_path = store.tag_path('test', 'test')
+        for fname in store.list_directory(tags_path):
+            full_tag_name = fname.split('/').pop()
+            if not full_tag_name == 'tag_0.0.2':
+                continue
+            try:
+                store.get_content(fname)
+            except exceptions.FileNotFoundError:
+                pass
+            except Exception as e:
+                raise e
+            else:
+                assert False
+
+        tag_content = store.get_content(tag_path)
+        assert tag_content == 'randomdata'