check if subnet is public

PacoVK · PacoVK · commit 1f37287464da · 2021-02-14T22:20:52.000+01:00
Signed-off-by: Pascal Euhus &lt;pascal.euhus@reservix.de&gt;
diff --git a/ecs/awsResources.go b/ecs/awsResources.go
@@ -421,7 +421,7 @@ func (b *ecsAPIService) ensureVolumes(r *awsResources, project *types.Project, t
 	return nil
 }
 
-func (b *ecsAPIService) ensureLoadBalancer(r *awsResources, project *types.Project, template *cloudformation.Template) {
+func (b *ecsAPIService) ensureLoadBalancer(r *awsResources, project *types.Project, template *cloudformation.Template) error {
 	if r.loadBalancer != nil {
 		return
 	}
@@ -452,7 +452,7 @@ func (b *ecsAPIService) ensureLoadBalancer(r *awsResources, project *types.Proje
 
 	var publicSubNetIDs []string
 	for _, subNetID := range r.subnetsIDs() {
-        isPublic, err := b.aws.IsPublicSubnet(b.ctx, subNetID)
+        isPublic, err := b.aws.IsPublicSubnet(context.Background(), subNetID)
         if err != nil {
             return err
         }
@@ -474,6 +474,7 @@ func (b *ecsAPIService) ensureLoadBalancer(r *awsResources, project *types.Proje
 		nameProperty: "LoadBalancerName",
 	}
 	r.loadBalancerType = balancerType
+	return nil
 }
 
 func (r *awsResources) getLoadBalancerSecurityGroups(project *types.Project) []string {

Original file line number	Diff line number	Diff line change
`@@ -421,7 +421,7 @@ func (b ecsAPIService) ensureVolumes(r awsResources, project *types.Project, t`
`421`	`421`	`return nil`
`422`	`422`	`}`
`423`	`423`
`424`		`-func (b ecsAPIService) ensureLoadBalancer(r awsResources, project types.Project, template cloudformation.Template) {`
	`424`	`+func (b ecsAPIService) ensureLoadBalancer(r awsResources, project types.Project, template cloudformation.Template) error {`
`425`	`425`	`if r.loadBalancer != nil {`
`426`	`426`	`return`
`427`	`427`	`}`
`@@ -452,7 +452,7 @@ func (b ecsAPIService) ensureLoadBalancer(r awsResources, project *types.Proje`
`452`	`452`
`453`	`453`	`var publicSubNetIDs []string`
`454`	`454`	`for _, subNetID := range r.subnetsIDs() {`
`455`		`- isPublic, err := b.aws.IsPublicSubnet(b.ctx, subNetID)`
	`455`	`+ isPublic, err := b.aws.IsPublicSubnet(context.Background(), subNetID)`
`456`	`456`	`if err != nil {`
`457`	`457`	`return err`
`458`	`458`	`}`
`@@ -474,6 +474,7 @@ func (b ecsAPIService) ensureLoadBalancer(r awsResources, project *types.Proje`
`474`	`474`	`nameProperty: "LoadBalancerName",`
`475`	`475`	`}`
`476`	`476`	`r.loadBalancerType = balancerType`
	`477`	`+ return nil`
`477`	`478`	`}`
`478`	`479`
`479`	`480`	`func (r awsResources) getLoadBalancerSecurityGroups(project types.Project) []string {`