Merge pull request #397 from joshwget/group-add

Add group_add

Author: joshwget

config/types.go

@@ -36,6 +36,7 @@ type ServiceConfigV1 struct {
 	Entrypoint    yaml.Command         `yaml:"entrypoint,flow,omitempty"`
 	EnvFile       yaml.Stringorslice   `yaml:"env_file,omitempty"`
 	Environment   yaml.MaporEqualSlice `yaml:"environment,omitempty"`
+	GroupAdd      []string             `yaml:"group_add,omitempty"`
 	Hostname      string               `yaml:"hostname,omitempty"`
 	Image         string               `yaml:"image,omitempty"`
 	Labels        yaml.SliceorMap      `yaml:"labels,omitempty"`
@@ -101,6 +102,7 @@ type ServiceConfig struct {
 	Extends       yaml.MaporEqualSlice `yaml:"extends,omitempty"`
 	ExternalLinks []string             `yaml:"external_links,omitempty"`
 	ExtraHosts    []string             `yaml:"extra_hosts,omitempty"`
+	GroupAdd      []string             `yaml:"group_add,omitempty"`
 	Image         string               `yaml:"image,omitempty"`
 	Hostname      string               `yaml:"hostname,omitempty"`
 	Ipc           string               `yaml:"ipc,omitempty"`

docker/service/convert.go

@@ -243,6 +243,7 @@ func Convert(c *config.ServiceConfig, ctx project.Context, clientFactory compose
 		VolumesFrom: volumesFrom,
 		CapAdd:      strslice.StrSlice(utils.CopySlice(c.CapAdd)),
 		CapDrop:     strslice.StrSlice(utils.CopySlice(c.CapDrop)),
+		GroupAdd:    c.GroupAdd,
 		ExtraHosts:  utils.CopySlice(c.ExtraHosts),
 		Privileged:  c.Privileged,
 		Binds:       Filter(vols, isBind),

docker/service/convert_test.go

@@ -81,6 +81,23 @@ func TestParseLabels(t *testing.T) {
 	assert.Equal(t, []string{"less"}, []string(cfg.Entrypoint))
 }
 
+func TestGroupAdd(t *testing.T) {
+	ctx := &ctx.Context{}
+	sc := &config.ServiceConfig{
+		GroupAdd: []string{
+			"root",
+			"1",
+		},
+	}
+	_, hostCfg, err := Convert(sc, ctx.Context, nil)
+	assert.Nil(t, err)
+
+	assert.True(t, reflect.DeepEqual([]string{
+		"root",
+		"1",
+	}, hostCfg.GroupAdd))
+}
+
 func TestOomScoreAdj(t *testing.T) {
 	ctx := &ctx.Context{}
 	sc := &config.ServiceConfig{