Merge pull request #659 from eunomie/no-image-to-tag

Add specific error message for image tag cmd

Author: glours

e2e/images_test.go

@@ -141,6 +141,20 @@ a-simple-app:latest simple
 			Err:      `could not parse 'b@simple-app' as a valid reference: invalid reference format`,
 		})
 
+		// with unexisting source image
+		dockerAppImageTag("b-simple-app", "target")
+		icmd.RunCmd(cmd).Assert(t, icmd.Expected{
+			ExitCode: 1,
+			Err:      `could not tag 'b-simple-app': no such application image`,
+		})
+
+		// with unexisting source tag
+		dockerAppImageTag("a-simple-app:not-a-tag", "target")
+		icmd.RunCmd(cmd).Assert(t, icmd.Expected{
+			ExitCode: 1,
+			Err:      `could not tag 'a-simple-app:not-a-tag': no such application image`,
+		})
+
 		// tag image with only names
 		dockerAppImageTag("a-simple-app", "b-simple-app")
 		icmd.RunCmd(cmd).Assert(t, icmd.Success)

internal/commands/image/tag.go

@@ -49,7 +49,11 @@ func readBundle(name string, bundleStore store.BundleStore) (*bundle.Bundle, err
 		return nil, err
 	}
 
-	return bundleStore.Read(cnabRef)
+	bundle, err := bundleStore.Read(cnabRef)
+	if err != nil {
+		return nil, fmt.Errorf("could not tag '%s': no such application image", name)
+	}
+	return bundle, nil
 }
 
 func storeBundle(bundle *bundle.Bundle, name string, bundleStore store.BundleStore) error {