Fix invalid volume definition

It can have more than one `:` in its definition.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>

Author: rumpl

internal/packager/extract.go

@@ -76,8 +76,7 @@ func Extract(name string, ops ...func(*types.App) error) (*types.App, error) {
 			types.WithPath(appname),
 			types.WithSource(types.AppSourceSplit),
 		)
-		app, err := loader.LoadFromDirectory(appname, appOpts...)
-		return app, err
+		return loader.LoadFromDirectory(appname, appOpts...)
 	}
 	// not a dir: a tarball package, extract that in a temp dir
 	app, err := loader.LoadFromTar(appname, ops...)

internal/validator/rules/externalsecrets.go

@@ -12,7 +12,6 @@ func NewExternalSecretsRule() Rule {
 }
 
 func (s *externalSecretsValidator) Collect(parent string, key string, value interface{}) {
-
 }
 
 func (s *externalSecretsValidator) Accept(parent string, key string) bool {

internal/validator/rules/relativepath.go

@@ -53,7 +53,7 @@ func (s *relativePathRule) Validate(value interface{}) []error {
 			}
 
 			parts := strings.Split(str, ":")
-			if len(parts) != 2 {
+			if len(parts) <= 1 {
 				errs = append(errs, fmt.Errorf("invalid volume definition (%q) in service %q", str, s.service))
 				continue
 			}