ITT: Collections asserts refactored.

Author: dmitry-ivanov

src/Asserts/CollectionAsserts.php

@@ -8,19 +8,25 @@ trait CollectionAsserts
 {
     protected function assertCollectionsEqual(Collection $collection1, Collection $collection2, $key)
     {
-        $collection1 = $collection1->pluck($key);
-        $collection2 = $collection2->pluck($key);
-        $diff = $collection1->diff($collection2);
+        $keys1 = $collection1->pluck($key)->toArray();
+        $keys2 = $collection2->pluck($key)->toArray();
 
-        $this->assertEmpty($diff, 'Failed asserting that collections are equal.');
+        $diff1 = array_diff($keys1, $keys2);
+        $diff2 = array_diff($keys2, $keys1);
+
+        $bothDiffsAreEmpty = (empty($diff1) && empty($diff2));
+        $this->assertTrue($bothDiffsAreEmpty, 'Failed asserting that collections are equal.');
     }
 
     protected function assertCollectionsNotEqual(Collection $collection1, Collection $collection2, $key)
     {
-        $collection1 = $collection1->pluck($key);
-        $collection2 = $collection2->pluck($key);
-        $diff = $collection1->diff($collection2);
+        $keys1 = $collection1->pluck($key)->toArray();
+        $keys2 = $collection2->pluck($key)->toArray();
+
+        $diff1 = array_diff($keys1, $keys2);
+        $diff2 = array_diff($keys2, $keys1);
 
-        $this->assertNotEmpty($diff, 'Failed asserting that collections are not equal.');
+        $atLeastOneDiffIsNotEmpty = (!empty($diff1) || !empty($diff2));
+        $this->assertTrue($atLeastOneDiffIsNotEmpty, 'Failed asserting that collections are not equal.');
     }
 }