Skip to content

Commit 1b92379

Browse files
committed
Improve tests
1 parent 0dbcb1a commit 1b92379

File tree

8 files changed

+12
-44
lines changed

8 files changed

+12
-44
lines changed

tests/debug/BacktraceAsStringTest.php

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,10 @@ class BacktraceAsStringTest extends TestCase
99
/** @test */
1010
public function it_returns_backtrace_as_string_without_args()
1111
{
12-
$start = file_get_contents($this->getExpectedBacktracePath());
12+
$pattern = file_get_contents(__DIR__ . '/BacktraceAsStringTest/pattern.txt');
1313
$backtrace = $this->getBacktrace();
1414

15-
$this->assertStringStartsWith($start, $backtrace);
16-
}
17-
18-
/**
19-
* Get the expected backtrace path.
20-
*
21-
* @return string
22-
*/
23-
private function getExpectedBacktracePath()
24-
{
25-
$travis = $this->isTravis() ? '.travis' : '';
26-
27-
return __DIR__ . "/BacktraceAsStringTest/backtrace{$travis}.txt";
15+
$this->assertRegExp("/{$pattern}/m", $backtrace);
2816
}
2917

3018
/**

tests/debug/BacktraceAsStringTest/backtrace.travis.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

tests/debug/BacktraceAsStringTest/backtrace.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#0 backtrace_as_string\(\) called at \[\/.*?\/tests\/debug\/BacktraceAsStringTest\.php:35\]
2+
#1 Illuminated\\Helpers\\Tests\\Debug\\BacktraceAsStringTest->anotherExtraMethod\(\) called at \[\/.*?\/tests\/debug\/BacktraceAsStringTest\.php:25\]
3+
#2 Illuminated\\Helpers\\Tests\\Debug\\BacktraceAsStringTest->getBacktrace\(\) called at \[\/.*?\/tests\/debug\/BacktraceAsStringTest\.php:13\]
4+
#3 Illuminated\\Helpers\\Tests\\Debug\\BacktraceAsStringTest->it_returns_backtrace_as_string_without_args\(\)

tests/debug/MinimizedBacktraceAsStringTest.php

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,10 @@ class MinimizedBacktraceAsStringTest extends TestCase
99
/** @test */
1010
public function it_returns_minimized_backtrace_as_string()
1111
{
12-
$start = file_get_contents($this->getExpectedBacktracePath());
12+
$pattern = file_get_contents(__DIR__ . '/MinimizedBacktraceAsStringTest/pattern.txt');
1313
$backtrace = $this->getBacktrace();
1414

15-
$this->assertStringStartsWith($start, $backtrace);
16-
}
17-
18-
/**
19-
* Get the expected backtrace path.
20-
*
21-
* @return string
22-
*/
23-
private function getExpectedBacktracePath()
24-
{
25-
$travis = $this->isTravis() ? '.travis' : '';
26-
27-
return __DIR__ . "/MinimizedBacktraceAsStringTest/backtrace{$travis}.txt";
15+
$this->assertRegExp("/{$pattern}/m", $backtrace);
2816
}
2917

3018
/**

tests/debug/MinimizedBacktraceAsStringTest/backtrace.travis.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

tests/debug/MinimizedBacktraceAsStringTest/backtrace.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
#0 \/.*?\/src\/debug\.php:27
2+
#1 \/.*?\/tests\/debug\/MinimizedBacktraceAsStringTest\.php:35
3+
#2 \/.*?\/tests\/debug\/MinimizedBacktraceAsStringTest\.php:25
4+
#3 \/.*?\/tests\/debug\/MinimizedBacktraceAsStringTest\.php:13

0 commit comments

Comments
 (0)