From bcf9b7ee3e98ec8f82950a8f7c8edfaabc1e1eea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=9Clgen=20Sar=C4=B1kavak?= Date: Mon, 3 Nov 2025 02:20:27 +0300 Subject: [PATCH 1/2] Remove ALLOWED_HOSTS from docker settings docker setup doesn't need or use different values, inheriting settings.dev.ALLOWED_HOSTS is enough. --- djangoproject/settings/docker.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/djangoproject/settings/docker.py b/djangoproject/settings/docker.py index 1484a008e2..2a248db8db 100644 --- a/djangoproject/settings/docker.py +++ b/djangoproject/settings/docker.py @@ -22,5 +22,3 @@ } SECRET_KEY = os.environ.get("SECRET_KEY") - -ALLOWED_HOSTS = [".localhost", "127.0.0.1", "www.127.0.0.1"] From beffe7902fc032f88b52531bc4fda8455cdfaa8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=9Clgen=20Sar=C4=B1kavak?= Date: Wed, 5 Nov 2025 18:48:51 +0300 Subject: [PATCH 2/2] Don't allow to customize ALLOWED_HOSTS for local dev We have several instances of hardcoded hosts which doesn't allow dynamic configuration --- djangoproject/settings/dev.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/djangoproject/settings/dev.py b/djangoproject/settings/dev.py index b398c7af30..6cd8110f75 100644 --- a/djangoproject/settings/dev.py +++ b/djangoproject/settings/dev.py @@ -5,7 +5,7 @@ "djangoproject.localhost", "docs.djangoproject.localhost", "dashboard.djangoproject.localhost", -] + SECRETS.get("allowed_hosts", []) +] LOCALE_MIDDLEWARE_EXCLUDED_HOSTS = ["docs.djangoproject.localhost"]