Skip to content

Commit 729fbd8

Browse files
committed
Increases specificity of webpack bundle test dir
1 parent 38a8e29 commit 729fbd8

File tree

9 files changed

+27
-26
lines changed

9 files changed

+27
-26
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ tests/venv/
7979
tests/venv3/
8080
tests/node_modules/
8181
tests/assets/bundles/
82+
tests/assets/django_webpack_loader_bundles/
8283
tests/webpack-stats.json
8384
tests/webpack-stats-app2.json
8485

tests/app/settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,12 @@
111111
WEBPACK_LOADER = {
112112
'DEFAULT': {
113113
'CACHE': False,
114-
'BUNDLE_DIR_NAME': 'bundles/',
114+
'BUNDLE_DIR_NAME': 'django_webpack_loader_bundles/',
115115
'STATS_FILE': os.path.join(BASE_DIR, 'webpack-stats.json'),
116116
},
117117
'APP2': {
118118
'CACHE': False,
119-
'BUNDLE_DIR_NAME': 'bundles/',
119+
'BUNDLE_DIR_NAME': 'django_webpack_loader_bundles/',
120120
'STATS_FILE': os.path.join(BASE_DIR, 'webpack-stats-app2.json'),
121121
},
122122
'NO_IGNORE_APP': {

tests/app/tests/test_custom_loaders.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def test_bad_custom_loader(self):
3232
with self.settings(WEBPACK_LOADER={
3333
'DEFAULT': {
3434
'CACHE': False,
35-
'BUNDLE_DIR_NAME': 'bundles/',
35+
'BUNDLE_DIR_NAME': 'django_webpack_loader_bundles/',
3636
'LOADER_CLASS': loader_class
3737
}
3838
}):
@@ -54,7 +54,7 @@ def test_good_custom_loader(self):
5454
with self.settings(WEBPACK_LOADER={
5555
'DEFAULT': {
5656
'CACHE': False,
57-
'BUNDLE_DIR_NAME': 'bundles/',
57+
'BUNDLE_DIR_NAME': 'django_webpack_loader_bundles/',
5858
'LOADER_CLASS': loader_class,
5959
}
6060
}):

tests/app/tests/test_webpack.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
from webpack_loader.utils import get_loader
2121

2222

23-
BUNDLE_PATH = os.path.join(settings.BASE_DIR, 'assets/bundles/')
23+
BUNDLE_PATH = os.path.join(settings.BASE_DIR, 'assets/django_webpack_loader_bundles/')
2424
DEFAULT_CONFIG = 'DEFAULT'
2525

2626

@@ -30,7 +30,7 @@ def setUp(self):
3030
self.cleanup_bundles_folder()
3131

3232
def cleanup_bundles_folder(self):
33-
rmtree('./assets/bundles', ignore_errors=True)
33+
rmtree('./assets/django_webpack_loader_bundles', ignore_errors=True)
3434

3535
def compile_bundles(self, config, wait=None):
3636
if wait:
@@ -44,7 +44,7 @@ def test_config_check(self):
4444
from webpack_loader.errors import BAD_CONFIG_ERROR
4545

4646
with self.settings(WEBPACK_LOADER={
47-
'BUNDLE_DIR_NAME': 'bundles/',
47+
'BUNDLE_DIR_NAME': 'django_webpack_loader_bundles/',
4848
'STATS_FILE': 'webpack-stats.json',
4949
}):
5050
errors = webpack_cfg_check(None)
@@ -69,8 +69,8 @@ def test_simple_and_css_extract(self):
6969
self.assertEqual(len(chunks), 1)
7070

7171
files = assets['assets']
72-
self.assertEqual(files['main.css']['path'], os.path.join(settings.BASE_DIR, 'assets/bundles/main.css'))
73-
self.assertEqual(files['main.js']['path'], os.path.join(settings.BASE_DIR, 'assets/bundles/main.js'))
72+
self.assertEqual(files['main.css']['path'], os.path.join(settings.BASE_DIR, 'assets/django_webpack_loader_bundles/main.css'))
73+
self.assertEqual(files['main.js']['path'], os.path.join(settings.BASE_DIR, 'assets/django_webpack_loader_bundles/main.js'))
7474

7575
def test_default_ignore_config_ignores_map_files(self):
7676
self.compile_bundles('webpack.config.sourcemaps.js')
@@ -95,8 +95,8 @@ def test_js_gzip_extract(self):
9595
self.assertEqual(len(chunks), 1)
9696

9797
files = assets['assets']
98-
self.assertEqual(files['main.css']['path'], os.path.join(settings.BASE_DIR, 'assets/bundles/main.css'))
99-
self.assertEqual(files['main.js.gz']['path'], os.path.join(settings.BASE_DIR, 'assets/bundles/main.js.gz'))
98+
self.assertEqual(files['main.css']['path'], os.path.join(settings.BASE_DIR, 'assets/django_webpack_loader_bundles/main.css'))
99+
self.assertEqual(files['main.js.gz']['path'], os.path.join(settings.BASE_DIR, 'assets/django_webpack_loader_bundles/main.js.gz'))
100100

101101
def test_static_url(self):
102102
self.compile_bundles('webpack.config.publicPath.js')
@@ -115,26 +115,26 @@ def test_code_spliting(self):
115115
self.assertEquals(len(chunks), 1)
116116

117117
files = assets['assets']
118-
self.assertEqual(files['main.js']['path'], os.path.join(settings.BASE_DIR, 'assets/bundles/main.js'))
119-
self.assertEqual(files['vendors.js']['path'], os.path.join(settings.BASE_DIR, 'assets/bundles/vendors.js'))
118+
self.assertEqual(files['main.js']['path'], os.path.join(settings.BASE_DIR, 'assets/django_webpack_loader_bundles/main.js'))
119+
self.assertEqual(files['vendors.js']['path'], os.path.join(settings.BASE_DIR, 'assets/django_webpack_loader_bundles/vendors.js'))
120120

121121
def test_templatetags(self):
122122
self.compile_bundles('webpack.config.simple.js')
123123
self.compile_bundles('webpack.config.app2.js')
124124
view = TemplateView.as_view(template_name='home.html')
125125
request = self.factory.get('/')
126126
result = view(request)
127-
self.assertIn('<link type="text/css" href="/static/bundles/main.css" rel="stylesheet" />', result.rendered_content)
128-
self.assertIn('<script type="text/javascript" src="/static/bundles/main.js" async charset="UTF-8"></script>', result.rendered_content)
127+
self.assertIn('<link type="text/css" href="/static/django_webpack_loader_bundles/main.css" rel="stylesheet" />', result.rendered_content)
128+
self.assertIn('<script type="text/javascript" src="/static/django_webpack_loader_bundles/main.js" async charset="UTF-8"></script>', result.rendered_content)
129129

130-
self.assertIn('<link type="text/css" href="/static/bundles/app2.css" rel="stylesheet" />', result.rendered_content)
131-
self.assertIn('<script type="text/javascript" src="/static/bundles/app2.js" ></script>', result.rendered_content)
130+
self.assertIn('<link type="text/css" href="/static/django_webpack_loader_bundles/app2.css" rel="stylesheet" />', result.rendered_content)
131+
self.assertIn('<script type="text/javascript" src="/static/django_webpack_loader_bundles/app2.js" ></script>', result.rendered_content)
132132
self.assertIn('<img src="/static/my-image.png"/>', result.rendered_content)
133133

134134
view = TemplateView.as_view(template_name='only_files.html')
135135
result = view(request)
136-
self.assertIn("var contentCss = '/static/bundles/main.css'", result.rendered_content)
137-
self.assertIn("var contentJS = '/static/bundles/main.js'", result.rendered_content)
136+
self.assertIn("var contentCss = '/static/django_webpack_loader_bundles/main.css'", result.rendered_content)
137+
self.assertIn("var contentJS = '/static/django_webpack_loader_bundles/main.js'", result.rendered_content)
138138

139139
self.compile_bundles('webpack.config.publicPath.js')
140140
view = TemplateView.as_view(template_name='home.html')
@@ -173,8 +173,8 @@ def test_jinja2(self):
173173
with self.settings(**settings):
174174
request = self.factory.get('/')
175175
result = view(request)
176-
self.assertIn('<link type="text/css" href="/static/bundles/main.css" rel="stylesheet" />', result.rendered_content)
177-
self.assertIn('<script type="text/javascript" src="/static/bundles/main.js" async charset="UTF-8"></script>', result.rendered_content)
176+
self.assertIn('<link type="text/css" href="/static/django_webpack_loader_bundles/main.css" rel="stylesheet" />', result.rendered_content)
177+
self.assertIn('<script type="text/javascript" src="/static/django_webpack_loader_bundles/main.js" async charset="UTF-8"></script>', result.rendered_content)
178178

179179
def test_reporting_errors(self):
180180
self.compile_bundles('webpack.config.error.js')

tests/webpack.config.error.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module.exports = {
88
context: __dirname,
99
entry: './assets/js/bad_index',
1010
output: {
11-
path: path.resolve('./assets/bundles/'),
11+
path: path.resolve('./assets/django_webpack_loader_bundles/'),
1212
filename: "[name].js",
1313
},
1414

tests/webpack.config.gzipTest.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module.exports = {
88
context: __dirname,
99
entry: './assets/js/index',
1010
output: {
11-
path: path.resolve('./assets/bundles/'),
11+
path: path.resolve('./assets/django_webpack_loader_bundles/'),
1212
filename: "[name].js.gz"
1313
},
1414

tests/webpack.config.simple.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module.exports = {
88
context: __dirname,
99
entry: './assets/js/index',
1010
output: {
11-
path: path.resolve('./assets/bundles/'),
11+
path: path.resolve('./assets/django_webpack_loader_bundles/'),
1212
filename: "[name].js"
1313
},
1414

tests/webpack.config.sourcemaps.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ module.exports = {
99
entry: './assets/js/index',
1010
devtool: 'source-map',
1111
output: {
12-
path: path.resolve('./assets/bundles/'),
12+
path: path.resolve('./assets/django_webpack_loader_bundles/'),
1313
filename: "[name].js"
1414
},
1515

tests/webpack.config.split.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module.exports = {
88
context: __dirname,
99
entry: './assets/js/index',
1010
output: {
11-
path: path.resolve('./assets/bundles/'),
11+
path: path.resolve('./assets/django_webpack_loader_bundles/'),
1212
filename: "[name].js",
1313
chunkFilename: "[name].js"
1414
},

0 commit comments

Comments
 (0)