fix(config): resolve incorrect DaisyUI version detection

- Fixed redirect handling in fetch_redirect_location to prevent automatic following
- Added NoRedirectHandler to capture redirect responses without following them
- Updated HTTP tests to mock build_opener instead of urlopen directly
- Made DaisyUI-related tests version-agnostic for better maintainability
- Tests now focus on behavior rather than specific version numbers

Author: oliverandrich

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+### 🐛 Bug Fixes
+- **DaisyUI version detection**: Fixed incorrect version fetching when `TAILWIND_CLI_USE_DAISY_UI = True` enabled
+
 ## 4.4.0 (2025-09-21)
 
 ### 🔧 Technical Improvements

src/django_tailwind_cli/utils/http.py

@@ -8,7 +8,9 @@
 from collections.abc import Callable
 from urllib.error import HTTPError as UrllibHTTPError
 from urllib.error import URLError
-from urllib.request import Request, urlopen
+from urllib.request import Request, urlopen, HTTPRedirectHandler, build_opener
+from typing import IO
+from http.client import HTTPMessage
 
 if TYPE_CHECKING:
     pass
@@ -30,6 +32,30 @@ class RequestTimeoutError(RequestError):
     """Request timeout error."""
 
 
+class NoRedirectHandler(HTTPRedirectHandler):
+    """HTTP redirect handler that captures redirect information without following."""
+
+    def http_error_302(self, req: Request, fp: IO[bytes], code: int, msg: str, headers: HTTPMessage) -> IO[bytes]:  # noqa: ARG002
+        """Handle 302 Found redirects."""
+        return fp
+
+    def http_error_301(self, req: Request, fp: IO[bytes], code: int, msg: str, headers: HTTPMessage) -> IO[bytes]:  # noqa: ARG002
+        """Handle 301 Moved Permanently redirects."""
+        return fp
+
+    def http_error_303(self, req: Request, fp: IO[bytes], code: int, msg: str, headers: HTTPMessage) -> IO[bytes]:  # noqa: ARG002
+        """Handle 303 See Other redirects."""
+        return fp
+
+    def http_error_307(self, req: Request, fp: IO[bytes], code: int, msg: str, headers: HTTPMessage) -> IO[bytes]:  # noqa: ARG002
+        """Handle 307 Temporary Redirect redirects."""
+        return fp
+
+    def http_error_308(self, req: Request, fp: IO[bytes], code: int, msg: str, headers: HTTPMessage) -> IO[bytes]:  # noqa: ARG002
+        """Handle 308 Permanent Redirect redirects."""
+        return fp
+
+
 def fetch_redirect_location(url: str, timeout: int = 10) -> tuple[bool, str | None]:
     """Fetch redirect location from a URL.
 
@@ -44,11 +70,14 @@ def fetch_redirect_location(url: str, timeout: int = 10) -> tuple[bool, str | No
         RequestError: On network or HTTP errors
     """
     try:
+        # Create opener with no redirect handler to capture redirect responses
+        opener = build_opener(NoRedirectHandler)
+
         req = Request(url)
         # Set User-Agent to avoid blocking
         req.add_header("User-Agent", "django-tailwind-cli")
 
-        with urlopen(req, timeout=timeout) as response:
+        with opener.open(req, timeout=timeout) as response:
             # Check if it's a redirect status
             if response.getcode() in (301, 302, 303, 307, 308):
                 location = response.headers.get("Location")

tests/test_config.py

@@ -97,6 +97,72 @@ def test_get_version_with_official_repo_and_version_3(settings: SettingsWrapper)
         get_version()
 
 
+def test_get_version_with_daisyui_enabled_latest(settings: SettingsWrapper, mocker: MockerFixture):
+    """Test that DaisyUI uses the correct repository and correctly parses version."""
+    # Clear any existing cache
+    from django_tailwind_cli.config import _get_cache_path
+    from semver import Version
+
+    cache_path = _get_cache_path()
+    if cache_path.exists():
+        cache_path.unlink()
+
+    settings.TAILWIND_CLI_USE_DAISY_UI = True
+    settings.TAILWIND_CLI_VERSION = "latest"
+
+    # Mock successful redirect to a generic valid DaisyUI version
+    test_version = "9.8.7"
+    request_get = mocker.patch("django_tailwind_cli.utils.http.fetch_redirect_location")
+    request_get.return_value = (
+        True,
+        f"https://github.com/dobicinaitis/tailwind-cli-extra/releases/tag/v{test_version}",
+    )
+
+    r_version_str, r_version = get_version()
+
+    # Test that version string is correctly extracted (without 'v' prefix)
+    assert r_version_str == test_version
+
+    # Test that version is correctly parsed as semantic version
+    assert isinstance(r_version, Version)
+    assert str(r_version) == test_version
+
+    # Verify the correct DaisyUI repository URL was used (not standard Tailwind)
+    request_get.assert_called_once_with(
+        "https://github.com/dobicinaitis/tailwind-cli-extra/releases/latest/", timeout=10
+    )
+
+
+def test_get_version_with_daisyui_fallback_when_network_fails(settings: SettingsWrapper, mocker: MockerFixture):
+    """Test fallback behavior when DaisyUI is enabled but network request fails."""
+    # Clear any existing cache
+    from django_tailwind_cli.config import _get_cache_path, FALLBACK_VERSION
+    from semver import Version
+
+    cache_path = _get_cache_path()
+    if cache_path.exists():
+        cache_path.unlink()
+
+    settings.TAILWIND_CLI_USE_DAISY_UI = True
+    settings.TAILWIND_CLI_VERSION = "latest"
+
+    # Mock failed network request
+    request_get = mocker.patch("django_tailwind_cli.utils.http.fetch_redirect_location")
+    request_get.return_value = (False, None)
+
+    r_version_str, r_version = get_version()
+
+    # Should fall back to the configured fallback version
+    assert r_version_str == FALLBACK_VERSION
+    assert isinstance(r_version, Version)
+    assert str(r_version) == FALLBACK_VERSION
+
+    # Verify the correct DaisyUI repository URL was still used in the attempt
+    request_get.assert_called_once_with(
+        "https://github.com/dobicinaitis/tailwind-cli-extra/releases/latest/", timeout=10
+    )
+
+
 def test_get_version_with_unofficial_repo_and_version_3(settings: SettingsWrapper):
     settings.TAILWIND_CLI_VERSION = "3.4.13"
     settings.TAILWIND_CLI_SRC_REPO = "oliverandrich/my-tailwindcss-cli"
@@ -296,18 +362,25 @@ def test_daisy_ui_support(
     settings: SettingsWrapper,
     mocker: MockerFixture,
 ):
+    from semver import Version
+
     settings.TAILWIND_CLI_USE_DAISY_UI = True
+    test_version = "7.6.5"
     request_get = mocker.patch("django_tailwind_cli.utils.http.fetch_redirect_location")
-    request_get.return_value = (True, "https://github.com/dobicinaitis/tailwind-cli-extra/releases/tag/v2.1.4")
+    request_get.return_value = (
+        True,
+        f"https://github.com/dobicinaitis/tailwind-cli-extra/releases/tag/v{test_version}",
+    )
 
     c = get_config()
 
+    # Test DaisyUI configuration is properly applied
     assert c.use_daisy_ui
     assert "tailwindcss-extra" in str(c.cli_path)
     assert "dobicinaitis/tailwind-cli-extra" in c.download_url
 
+    # Test version parsing works correctly
     r_version_str, r_version = get_version()
-    assert r_version_str == "2.1.4"
-    assert r_version.major == 2
-    assert r_version.minor == 1
-    assert r_version.patch == 4
+    assert r_version_str == test_version
+    assert isinstance(r_version, Version)
+    assert str(r_version) == test_version

tests/test_http.py

@@ -21,35 +21,45 @@ def test_fetch_redirect_location_timeout_error(self):
         """Test timeout error handling."""
         mock_error = URLError(socket.timeout("timeout"))
 
-        with patch("django_tailwind_cli.utils.http.urlopen", side_effect=mock_error):
+        with patch("django_tailwind_cli.utils.http.build_opener") as mock_build_opener:
+            mock_opener = mock_build_opener.return_value
+            mock_opener.open.side_effect = mock_error
             with pytest.raises(http.RequestTimeoutError, match="Request timeout"):
                 http.fetch_redirect_location("https://example.com")
 
     def test_fetch_redirect_location_connection_error(self):
         """Test connection error handling."""
         mock_error = URLError(ConnectionRefusedError("connection refused"))
 
-        with patch("django_tailwind_cli.utils.http.urlopen", side_effect=mock_error):
+        with patch("django_tailwind_cli.utils.http.build_opener") as mock_build_opener:
+            mock_opener = mock_build_opener.return_value
+            mock_opener.open.side_effect = mock_error
             with pytest.raises(http.NetworkConnectionError, match="Connection error"):
                 http.fetch_redirect_location("https://example.com")
 
     def test_fetch_redirect_location_generic_error(self):
         """Test generic URL error handling."""
         mock_error = URLError("generic error")
 
-        with patch("django_tailwind_cli.utils.http.urlopen", side_effect=mock_error):
+        with patch("django_tailwind_cli.utils.http.build_opener") as mock_build_opener:
+            mock_opener = mock_build_opener.return_value
+            mock_opener.open.side_effect = mock_error
             with pytest.raises(http.RequestError, match="URL error"):
                 http.fetch_redirect_location("https://example.com")
 
     def test_fetch_redirect_location_timeout_error_direct(self):
         """Test direct timeout error handling."""
-        with patch("django_tailwind_cli.utils.http.urlopen", side_effect=TimeoutError("timeout")):
+        with patch("django_tailwind_cli.utils.http.build_opener") as mock_build_opener:
+            mock_opener = mock_build_opener.return_value
+            mock_opener.open.side_effect = TimeoutError("timeout")
             with pytest.raises(http.RequestTimeoutError, match="Socket timeout"):
                 http.fetch_redirect_location("https://example.com")
 
     def test_fetch_redirect_location_generic_exception(self):
         """Test generic exception handling."""
-        with patch("django_tailwind_cli.utils.http.urlopen", side_effect=ValueError("unexpected")):
+        with patch("django_tailwind_cli.utils.http.build_opener") as mock_build_opener:
+            mock_opener = mock_build_opener.return_value
+            mock_opener.open.side_effect = ValueError("unexpected")
             with pytest.raises(http.RequestError, match="Unexpected error"):
                 http.fetch_redirect_location("https://example.com")