Fix get_available_FIELD_transition on django>=3.2. Close #256 #262

Author: kmmbvnr

django_fsm/__init__.py

@@ -8,6 +8,7 @@
 
 import django
 from django.db import models
+from django.db.models import Field
 from django.db.models.query_utils import DeferredAttribute
 from django.db.models.signals import class_prepared
 from django_fsm.signals import pre_transition, post_transition
@@ -403,7 +404,14 @@ def _collect_transitions(self, *args, **kwargs):
         def is_field_transition_method(attr):
             return (inspect.ismethod(attr) or inspect.isfunction(attr)) \
                 and hasattr(attr, '_django_fsm') \
-                and attr._django_fsm.field in [self, self.name]
+                and (
+                    attr._django_fsm.field in [self, self.name]
+                    or (
+                        isinstance(attr._django_fsm.field, Field)
+                        and issubclass(self.model, attr._django_fsm.field.model)
+                        and attr._django_fsm.field.name == self.name
+                        and attr._django_fsm.field.creation_counter == self.creation_counter
+                    ))
 
         sender_transitions = {}
         transitions = inspect.getmembers(sender, predicate=is_field_transition_method)

django_fsm/tests/test_abstract_inheritance.py

@@ -0,0 +1,47 @@
+from django.db import models
+from django.test import TestCase
+
+from django_fsm import FSMField, transition, can_proceed
+
+
+class BaseAbstractModel(models.Model):
+    state = FSMField(default='new')
+
+    class Meta:
+        abstract = True
+
+    @transition(field=state, source='new', target='published')
+    def publish(self):
+        pass
+
+
+class InheritedFromAbstractModel(BaseAbstractModel):
+    @transition(field='state', source='published', target='sticked')
+    def stick(self):
+        pass
+
+
+class TestinheritedModel(TestCase):
+    def setUp(self):
+        self.model = InheritedFromAbstractModel()
+
+    def test_known_transition_should_succeed(self):
+        self.assertTrue(can_proceed(self.model.publish))
+        self.model.publish()
+        self.assertEqual(self.model.state, 'published')
+
+        self.assertTrue(can_proceed(self.model.stick))
+        self.model.stick()
+        self.assertEqual(self.model.state, 'sticked')
+
+    def test_field_available_transitions_works(self):
+        self.model.publish()
+        self.assertEqual(self.model.state, 'published')
+        transitions = self.model.get_available_state_transitions()
+        self.assertEqual(['sticked'], [data.target for data in transitions])
+
+    def test_field_all_transitions_works(self):
+        transitions = self.model.get_all_state_transitions()
+        self.assertEqual(set([('new', 'published'),
+                              ('published', 'sticked')]),
+                         set((data.source, data.target) for data in transitions))

django_fsm/tests/test_protected_field.py

@@ -19,6 +19,9 @@ class MultiProtectedAccessModel(models.Model):
     status1 = FSMField(default='new', protected=True)
     status2 = FSMField(default='new', protected=True)
 
+    class Meta:
+        app_label = 'django_fsm'
+
 
 class TestDirectAccessModels(TestCase):
     def test_multi_protected_field_create(self):