Fix pre commit + cleanup old compatibility code (#10)

Fix ruff settings

Author: pfouque

.github/workflows/lint.yml

@@ -0,0 +1,17 @@
+name: django-fsm linting
+
+on:
+  pull_request:
+  push:
+    branches: [main]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-python@v2
+      with:
+        python-version: '3.11'
+    - uses: pre-commit/action@v3.0.0

.github/workflows/tests.yml

@@ -1,8 +1,9 @@
 name: django-fsm testing
 
 on:
-  - push
-  - pull_request
+  pull_request:
+  push:
+    branches: [main]
 
 jobs:
   build:

.pre-commit-config.yaml

@@ -17,13 +17,6 @@ repos:
       - id: end-of-file-fixer
       - id: trailing-whitespace
 
-  - repo: https://github.com/asottile/pyupgrade
-    rev: v3.15.0
-    hooks:
-      - id: pyupgrade
-        args:
-          - "--py38-plus"
-
   - repo: https://github.com/adamchainz/django-upgrade
     rev: 1.15.0
     hooks:
@@ -32,14 +25,14 @@ repos:
 
 
   - repo: https://github.com/python-poetry/poetry
-    rev: 1.6.1
+    rev: 1.6.0
     hooks:
     -   id: poetry-check
-    -   id: poetry-lock
-    -   id: poetry-export
+    # -   id: poetry-lock
+    # -   id: poetry-export
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.0.291
+    rev: v0.1.3
     hooks:
       - id: ruff-format
       - id: ruff

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## django-fsm unreleased
 
+
+- Remove South support...if exists
 - Add support for django 5.0
 - Remove support for django < 3.2
 - Add support for python 3.12

CHANGELOG.rst

@@ -5,22 +5,13 @@
 from functools import partialmethod, wraps
 
 import django
+from django.apps import apps as django_apps
 from django.db import models
 from django.db.models import Field
 from django.db.models.query_utils import DeferredAttribute
 from django.db.models.signals import class_prepared
-from django_fsm.signals import pre_transition, post_transition
-
-try:
-    from django.apps import apps as django_apps
-
-    def get_model(app_label, model_name):
-        app = django_apps.get_app_config(app_label)
-        return app.get_model(model_name)
 
-
-except ImportError:
-    from django.db.models.loading import get_model
+from django_fsm.signals import pre_transition, post_transition
 
 
 __all__ = [
@@ -38,16 +29,6 @@ def get_model(app_label, model_name):
     "RETURN_VALUE",
 ]
 
-# South support; see http://south.aeracode.org/docs/tutorial/part4.html#simple-inheritance
-try:
-    from south.modelsinspector import add_introspection_rules
-except ImportError:
-    pass
-else:
-    add_introspection_rules([], [r"^django_fsm\.FSMField"])
-    add_introspection_rules([], [r"^django_fsm\.FSMIntegerField"])
-    add_introspection_rules([], [r"^django_fsm\.FSMKeyField"])
-
 
 class TransitionNotAllowed(Exception):
     """Raised when a transition is not allowed"""
@@ -297,7 +278,8 @@ def set_proxy(self, instance, state):
                 app_label = instance._meta.app_label
                 model_name = state_proxy
 
-            model = get_model(app_label, model_name)
+            model = django_apps.get_app_config(app_label).get_model(model_name)
+
             if model is None:
                 raise ValueError(f"No model found {state_proxy}")
 
@@ -374,9 +356,7 @@ def contribute_to_class(self, cls, name, **kwargs):
         super().contribute_to_class(cls, name, **kwargs)
         setattr(cls, self.name, self.descriptor_class(self))
         setattr(cls, f"get_all_{self.name}_transitions", partialmethod(get_all_FIELD_transitions, field=self))
-        setattr(
-            cls, f"get_available_{self.name}_transitions", partialmethod(get_available_FIELD_transitions, field=self)
-        )
+        setattr(cls, f"get_available_{self.name}_transitions", partialmethod(get_available_FIELD_transitions, field=self))
         setattr(
             cls,
             f"get_available_user_{self.name}_transitions",