Properly disable instrumentation for the template panel.

It's important to disconnect the signal at the end of a request because
the toolbar now stores panels for past request.

Fix #491 (presumably).

Author: aaugustin

debug_toolbar/panels/templates/panel.py

@@ -81,12 +81,8 @@ class TemplatesPanel(Panel):
     def __init__(self, *args, **kwargs):
         super(TemplatesPanel, self).__init__(*args, **kwargs)
         self.templates = []
-        template_rendered.connect(self._store_template_info)
 
     def _store_template_info(self, sender, **kwargs):
-        if not self.enabled:
-            return
-
         template, context = kwargs['template'], kwargs['context']
 
         # Skip templates that we are generating through the debug toolbar.
@@ -157,6 +153,12 @@ def get_urls(cls):
             url(r'^template_source/$', 'template_source', name='template_source'),
         )
 
+    def enable_instrumentation(self):
+        template_rendered.connect(self._store_template_info)
+
+    def disable_instrumentation(self):
+        template_rendered.disconnect(self._store_template_info)
+
     def process_response(self, request, response):
         template_context = []
         for template_data in self.templates:

tests/panels/test_template.py

@@ -15,11 +15,13 @@ class TemplatesPanelTestCase(BaseTestCase):
     def setUp(self):
         super(TemplatesPanelTestCase, self).setUp()
         self.panel = self.toolbar.get_panel_by_id('TemplatesPanel')
+        self.panel.enable_instrumentation()
         self.sql_panel = self.toolbar.get_panel_by_id('SQLPanel')
         self.sql_panel.enable_instrumentation()
 
     def tearDown(self):
         self.sql_panel.disable_instrumentation()
+        self.panel.disable_instrumentation()
         super(TemplatesPanelTestCase, self).tearDown()
 
     def test_queryset_hook(self):