Skip to content

fix: Admin complained about missing methods get_author and get_modified_date #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: Admin complained about missing methods get_author and get_modified_date #307

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
099e368
fix: Admin complained about missing methods get_author and get_modifi…
fsbraun Oct 28, 2025
b42d781
chore: Add types
fsbraun Oct 28, 2025
e466aa9
fix: Do not imply correlation of get_author and get_modified_state
fsbraun Oct 28, 2025
32b5b2b
Merge branch 'master' into fix/issue-302
fsbraun Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions djangocms_alias/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
from django.utils.translation import gettext_lazy as _
from parler.admin import TranslatableAdmin

from .cms_config import AliasCMSConfig
from .constants import (
CHANGE_ALIAS_URL_NAME,
DELETE_ALIAS_URL_NAME,
Expand All @@ -37,13 +36,6 @@
"AliasContentAdmin",
]

alias_admin_list_display = ["content__name", "category", "static", "used", "admin_list_actions"]
djangocms_versioning_enabled = AliasCMSConfig.djangocms_versioning_enabled

if djangocms_versioning_enabled:
alias_admin_list_display.insert(-1, "get_author")
alias_admin_list_display.insert(-1, "get_modified_date")


@admin.register(Category)
class CategoryAdmin(TranslatableAdmin):
Expand All @@ -64,7 +56,7 @@ def save_model(self, request, obj, form, change):

@admin.register(Alias)
class AliasAdmin(GrouperModelAdmin):
list_display = alias_admin_list_display
list_display = ["content__name", "category", "static", "used", "admin_list_actions"]
list_display_links = None
list_filter = (
SiteFilter,
Expand All @@ -87,6 +79,14 @@ def get_queryset(self, request):
# Annotate each Alias with a boolean indicating if related cmsplugins exist
return qs.annotate(cmsplugins_count=models.Count("cms_plugins"))

def get_list_display(self, request):
list_display = super().get_list_display(request)
if hasattr(self, "get_author"):
list_display = list(list_display)
list_display.insert(-1, "get_author")
list_display.insert(-1, "get_modified_date")
return list_display

@admin.display(description=_("Used"), boolean=True, ordering="cmsplugins_count")
def used(self, obj: Alias) -> bool | None:
if obj.static_code and obj.cmsplugins_count == 0:
Expand Down