Skip to content

Commit 68c4545

Browse files
committed
Fix "skip" button not appearing in some cases
1 parent 09566b9 commit 68c4545

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/components/Question.vue

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,8 @@
7171
v-bind:aria-label="language.ariaOk"
7272
>
7373
<span v-if="question.type === QuestionType.SectionBreak">{{ language.continue }}</span>
74-
<span v-else>
75-
<span v-if="showSkip()">{{ language.skip }}</span>
76-
<span v-else>{{ language.ok }}</span>
77-
</span>
74+
<span v-else-if="showSkip()">{{ language.skip }}</span>
75+
<span v-else>{{ language.ok }}</span>
7876
</button>
7977
<a
8078
class="f-enter-desc"
@@ -272,7 +270,9 @@
272270
showSkip() {
273271
const q = this.$refs.questionComponent
274272
275-
return q && !this.question.required && !q.hasValue
273+
// We might not have a reference to the question component at first
274+
// but we know that if we don't, it's definitely empty
275+
return !this.question.required && (!q || !q.hasValue)
276276
},
277277
278278
/**

0 commit comments

Comments
 (0)