Refactoring internal identifiers.

Author: terrier989

cryptography/lib/src/cryptography/mac_algorithm.dart

@@ -252,7 +252,7 @@ class _EmptyMacSink extends MacSink with DartMacSinkMixin {
   bool get isClosed => _isClosed;
 
   @override
-  Uint8List get macStateAsUint8List => _empty;
+  Uint8List get macBytes => _empty;
 
   @override
   void addSlice(List<int> chunk, int start, int end, bool isLast) {
@@ -303,7 +303,7 @@ class _MacSink extends MacSink with DartMacSinkMixin {
   bool get isClosed => _macFuture != null;
 
   @override
-  Uint8List get macStateAsUint8List {
+  Uint8List get macBytes {
     throw UnimplementedError();
   }
 

cryptography/lib/src/dart/_helpers.dart

@@ -90,10 +90,10 @@ class PackageCryptoHashSink extends DartHashSink {
   bool _isClosed = false;
 
   @override
-  final Uint8List hashBufferAsUint8List;
+  final Uint8List hashBytes;
 
-  PackageCryptoHashSink(this.hashBufferAsUint8List, this.hashAlgorithm,
-      this._sink, this._captureSink);
+  PackageCryptoHashSink(
+      this.hashBytes, this.hashAlgorithm, this._sink, this._captureSink);
 
   @override
   bool get isClosed => _isClosed;
@@ -130,7 +130,7 @@ class PackageCryptoHashSink extends DartHashSink {
     }
     _isClosed = true;
     _sink.close();
-    hashBufferAsUint8List.setAll(0, _captureSink._result!.bytes);
+    hashBytes.setAll(0, _captureSink._result!.bytes);
   }
 
   @override

cryptography/lib/src/dart/blake2b_impl_browser.dart

@@ -65,7 +65,7 @@ class Blake2bSink extends DartHashSink {
   final _hash = Uint32List(32);
 
   @override
-  late final Uint8List hashBufferAsUint8List = Uint8List.view(
+  late final Uint8List hashBytes = Uint8List.view(
     _hash.buffer,
     0,
     64,

cryptography/lib/src/dart/blake2b_impl_vm.dart

@@ -54,7 +54,7 @@ class Blake2bSink extends DartHashSink {
   );
 
   @override
-  late final Uint8List hashBufferAsUint8List = Uint8List.view(
+  late final Uint8List hashBytes = Uint8List.view(
     _hash.buffer,
     0,
     64,

cryptography/lib/src/dart/blake2s.dart

@@ -66,7 +66,7 @@ class _Blake2sSink extends DartHashSink {
   int _length = 0;
 
   @override
-  late final Uint8List hashBufferAsUint8List = Uint8List.view(
+  late final Uint8List hashBytes = Uint8List.view(
     _hash.buffer,
     0,
     32,

cryptography/lib/src/dart/dart_hash_algorithm.dart

@@ -49,7 +49,10 @@ mixin DartHashAlgorithmMixin implements DartHashAlgorithm {
 
 /// A [HashSink] that supports synchronous evaluation ([hashSync]).
 abstract class DartHashSink extends HashSink {
-  Uint8List get hashBufferAsUint8List;
+  /// Unsafe view at the current hash bytes.
+  ///
+  /// You must copy the bytes if you want to keep them.
+  Uint8List get hashBytes;
 
   bool get isClosed;
 
@@ -81,7 +84,7 @@ abstract class DartHashSink extends HashSink {
     if (!isClosed) {
       throw StateError('Not closed');
     }
-    return Hash(Uint8List.fromList(hashBufferAsUint8List));
+    return Hash(Uint8List.fromList(hashBytes));
   }
 
   void reset();

cryptography/lib/src/dart/dart_mac_algorithm.dart

@@ -105,8 +105,10 @@ mixin DartMacAlgorithmMixin implements DartMacAlgorithm {
 
 /// A mixin for pure Dart implementations of [MacSink]
 mixin DartMacSinkMixin implements MacSink {
-  /// View at bytes of the latest MAC.
-  Uint8List get macStateAsUint8List;
+  /// Unsafe view at the current MAC bytes.
+  ///
+  /// You must copy the bytes if you want to keep them.
+  Uint8List get macBytes;
 
   /// Re-initializes the sink.
   void initializeSync({
@@ -126,6 +128,6 @@ mixin DartMacSinkMixin implements MacSink {
     if (!isClosed) {
       throw StateError('Sink is not closed');
     }
-    return Mac(Uint8List.fromList(macStateAsUint8List));
+    return Mac(Uint8List.fromList(macBytes));
   }
 }

cryptography/lib/src/dart/hmac.dart

@@ -90,7 +90,7 @@ class _DartHmacSink extends MacSink with DartMacSinkMixin {
   bool get isClosed => _isClosed;
 
   @override
-  Uint8List get macStateAsUint8List => _outerSink.hashBufferAsUint8List;
+  Uint8List get macBytes => _outerSink.hashBytes;
 
   @override
   void addSlice(List<int> chunk, int start, int end, bool isLast) {
@@ -101,7 +101,7 @@ class _DartHmacSink extends MacSink with DartMacSinkMixin {
     innerSink.addSlice(chunk, start, end, isLast);
     if (isLast) {
       _isClosed = true;
-      final innerDigest = innerSink.hashBufferAsUint8List;
+      final innerDigest = innerSink.hashBytes;
       final outerSink = _outerSink;
       outerSink.addSlice(innerDigest, 0, innerDigest.length, true);
     }
@@ -135,7 +135,7 @@ class _DartHmacSink extends MacSink with DartMacSinkMixin {
     innerSink.reset();
     if (hmacKey.length > blockLength) {
       innerSink.addSlice(hmacKey, 0, hmacKey.length, true);
-      hmacKey = Uint8List.fromList(innerSink.hashBufferAsUint8List);
+      hmacKey = Uint8List.fromList(innerSink.hashBytes);
       innerSink.reset();
       eraseKey = true;
     }

cryptography/lib/src/dart/pbkdf2.dart

@@ -109,7 +109,7 @@ class DartPbkdf2 extends Pbkdf2 {
           nonce: nonce,
         );
         macState.addSlice(previous, 0, previous.length, true);
-        final macBytes = macState.macStateAsUint8List;
+        final macBytes = macState.macBytes;
 
         // XOR with the result
         for (var bi = 0; bi < block.length; bi++) {

cryptography/lib/src/dart/poly1305.dart

@@ -77,7 +77,7 @@ class DartPoly1305Sink extends MacSink with DartMacSinkMixin {
 
   @override
   // TODO: implement macStateAsUint8List
-  Uint8List get macStateAsUint8List => _mac!.bytes as Uint8List;
+  Uint8List get macBytes => _mac!.bytes as Uint8List;
 
   @mustCallSuper
   @override